Alex Netsch aaaf8532a7 Add close button to preview warning banner (vibe-kanban) (#1013)
* ## Summary

I've successfully fixed the issue where the red preview warning banner was blocking the preview even when a working output on a port was discovered.

### Root Cause
The issue was in `frontend/src/components/tasks/TaskDetails/PreviewTab.tsx:108-118`. The component had two separate "ready" states:
1. **`previewState.status === 'ready'`** - Set when a URL is detected in dev server logs (preview working)
2. **`isReady`** - Set when the web companion sends a 'ready' postMessage (optional, only for click-to-component)

The warning banner was showing whenever `!isReady` was true after 5 seconds, even if the preview was fully functional with a discovered URL.

### Solution
I added a check for `previewState.status !== 'ready'` to the warning condition at line 112. Now the warning banner only shows when:
- 5 seconds have elapsed
- No web companion ready message received
- **AND no URL was discovered** (preview actually broken)
- Dev server is running

### Result
The red warning banner will no longer appear when the preview is working correctly (URL discovered and iframe loaded), even if the web companion is not installed. It will only show when there's an actual problem with the preview not loading.

**File changed:** `frontend/src/components/tasks/TaskDetails/PreviewTab.tsx:112,123`

* ## Summary

I've successfully implemented a simple solution that shows two different types of warnings based on the actual state of the preview:

### Changes Made

**1. Modified `frontend/src/components/tasks/TaskDetails/PreviewTab.tsx`:**

- Added `X` icon import from lucide-react for the dismiss button
- Added new state: `showCompanionWarning` to track the companion info banner
- Updated the warning logic (lines 110-126) to differentiate between two scenarios:
  - **Critical Error (Red Alert)**: Shows when `previewState.status !== 'ready'` - dev server is running but no URL was discovered (actual preview problem)
  - **Companion Info (Blue Alert)**: Shows when `previewState.status === 'ready'` - preview is working but web companion is not detected
- Added dismissible blue info banner (lines 218-244) with:
  - Title: "Enable Click-to-Component"
  - Message about installing web companion
  - Link to installation guide
  - X button to dismiss (no localStorage, resets each time)
- Updated state management to clear both warnings appropriately

**2. Added translations to `frontend/src/i18n/locales/en/tasks.json`:**
- Added new `companionAlert` section with title, message, and link text

### Result

Now the UX works as follows:

1. **Preview is broken** (no URL discovered): Red destructive alert shows with all troubleshooting steps and "Stop Dev Server & Resolve Issues" button
2. **Preview is working** (URL discovered, iframe loaded): Blue info alert shows suggesting web companion installation, with dismiss button (X)
3. **Web companion detected**: No warnings shown

This allows users to:
- See their preview immediately without blocking errors
- Still discover the web companion feature through a friendly, dismissible notification
- Distinguish between critical errors and optional features
- Dismiss the companion warning if not interested (persists only for current session)

* Perfect! All review comments have been addressed. Let me create a summary:

## Summary of Changes

I've successfully addressed all three review comments:

### 1. **Why import X?** (Line 3)
The `X` icon from lucide-react is used for dismiss buttons on both alert banners (lines 225 and 240).

### 2. **Missing translations** (Line 100)
Added `companionAlert` translations to both additional language files:

**Spanish** (`frontend/src/i18n/locales/es/tasks.json:100-104`):
- title: "Habilitar Click-to-Component"
- message: "Instala el Web Companion para desbloquear la funcionalidad de clic para editar."
- link: "Ver guía de instalación"

**Japanese** (`frontend/src/i18n/locales/ja/tasks.json:100-104`):
- title: "Click-to-Componentを有効化"
- message: "Web Companionをインストールして、クリックして編集機能を有効にします。"
- link: "インストールガイドを表示"

### 3. **Critical error alert should be dismissible** (Line 122)
Modified the red destructive alert in `PreviewTab.tsx:186-229` to:
- Wrap content in a flex container with space for the close button
- Add an X button in the top-right corner (same pattern as companion warning)
- Keep the "Stop Dev Server & Resolve Issues" button for those who want to stop
- Allow dismissal for backend-only users who want to focus on logs

**Files changed:**
- `frontend/src/components/tasks/TaskDetails/PreviewTab.tsx` (lines 186-229)
- `frontend/src/i18n/locales/es/tasks.json` (lines 100-104)
- `frontend/src/i18n/locales/ja/tasks.json` (lines 100-104)

Both alerts (critical error and companion warning) are now dismissible, fully translated, and provide a better UX for different user scenarios.

* Cleanup script changes for task attempt a91eb42f-7923-473a-8e9c-7e471e9ccb3d

* Perfect! Let me create a summary:

## Summary - Simple Solution Implemented

I've reverted to a much simpler approach that solves all the problems with minimal changes:

### What Changed

**Single file modified:** `frontend/src/components/tasks/TaskDetails/PreviewTab.tsx`

**Changes:**
1. Added `X` import from lucide-react (line 3)
2. Made the warning alert dismissible by:
   - Wrapping the alert content in a flex container (line 178)
   - Adding an X button in the top-right corner (lines 211-218)
   - Clicking X calls `setShowHelp(false)` to dismiss the alert

### What This Solves

 **Original issue**: Users can dismiss false-positive warnings when preview is working
 **Backend users**: Can dismiss the alert and fullscreen the logs tab
 **Web companion discovery**: Warning still shows (includes companion installation info) but is dismissible
 **Simplicity**: Minimal code change, no complex logic, easy to understand

### Code Structure

The warning now has this structure:
```tsx
[Warning Title]                                    [X]
[Troubleshooting items 1-3]
[Stop Dev Server & Resolve Issues button]
```

Users can either:
- Click X to dismiss and continue working
- Click "Stop Dev Server & Resolve Issues" to stop and fix problems

**Note:** I kept the companion alert translations in `es/tasks.json` and `ja/tasks.json` in case you want to use them in the future, but they're not referenced in the code anymore.

* Done. All unused translations removed.

## Final Summary - Simple Solution

**Files changed:**
- `frontend/src/components/tasks/TaskDetails/PreviewTab.tsx`

**What changed:**
1. Added `X` import from lucide-react
2. Made the warning alert dismissible with an X button in the top-right corner

**What this solves:**
- Users can dismiss false-positive warnings
- Backend users can dismiss and focus on logs
- Web companion is still discoverable (warning shows but is dismissible)
- Minimal, clean code change

No unused code left behind.
2025-10-15 13:03:36 +01:00
2025-08-08 13:53:27 +01:00
2025-08-08 13:53:27 +01:00
2025-10-13 09:43:12 +00:00
2025-09-04 10:52:18 +01:00
2025-09-22 16:02:42 +01:00
2025-08-08 13:53:27 +01:00
2025-08-08 13:53:27 +01:00
2025-07-11 15:57:30 +01:00
2025-09-04 10:52:18 +01:00
2025-07-11 16:31:08 +01:00
2025-10-13 09:43:12 +00:00
2025-06-14 15:14:08 -04:00
2025-10-03 13:48:27 +01:00
2025-06-25 09:27:29 +01:00
2025-06-25 09:27:29 +01:00
2025-07-04 11:11:45 +02:00

Vibe Kanban Logo

Get 10X more out of Claude Code, Gemini CLI, Codex, Amp and other coding agents...

npm Build status Ask DeepWiki

Overview

AI coding agents are increasingly writing the world's code and human engineers now spend the majority of their time planning, reviewing, and orchestrating tasks. Vibe Kanban streamlines this process, enabling you to:

  • Easily switch between different coding agents
  • Orchestrate the execution of multiple coding agents in parallel or in sequence
  • Quickly review work and start dev servers
  • Track the status of tasks that your coding agents are working on
  • Centralise configuration of coding agent MCP configs

You can watch a video overview here.

Installation

Make sure you have authenticated with your favourite coding agent. A full list of supported coding agents can be found in the docs. Then in your terminal run:

npx vibe-kanban

Documentation

Please head to the website for the latest documentation and user guides.

Support

We use GitHub Discussions for feature requests. Please open a discussion to create a feature request. For bugs please open an issue on this repo.

Contributing

We would prefer that ideas and changes are first raised with the core team via GitHub Discussions or Discord, where we can discuss implementation details and alignment with the existing roadmap. Please do not open PRs without first discussing your proposal with the team.

Development

Prerequisites

Additional development tools:

cargo install cargo-watch
cargo install sqlx-cli

Install dependencies:

pnpm i

Running the dev server

pnpm run dev

This will start the backend. A blank DB will be copied from the dev_assets_seed folder.

Building the frontend

To build just the frontend:

cd frontend
pnpm build

Build from source

  1. Run build-npm-package.sh
  2. In the npx-cli folder run npm pack
  3. You can run your build with npx [GENERATED FILE].tgz

Environment Variables

The following environment variables can be configured at build time or runtime:

Variable Type Default Description
GITHUB_CLIENT_ID Build-time Ov23li9bxz3kKfPOIsGm GitHub OAuth app client ID for authentication
POSTHOG_API_KEY Build-time Empty PostHog analytics API key (disables analytics if empty)
POSTHOG_API_ENDPOINT Build-time Empty PostHog analytics endpoint (disables analytics if empty)
BACKEND_PORT Runtime 0 (auto-assign) Backend server port
FRONTEND_PORT Runtime 3000 Frontend development server port
HOST Runtime 127.0.0.1 Backend server host
DISABLE_WORKTREE_ORPHAN_CLEANUP Runtime Not set Disable git worktree cleanup (for debugging)

Build-time variables must be set when running pnpm run build. Runtime variables are read when the application starts.

Custom GitHub OAuth App (Optional)

By default, Vibe Kanban uses Bloop AI's GitHub OAuth app for authentication. To use your own GitHub app for self-hosting or custom branding:

  1. Create a GitHub OAuth App at GitHub Developer Settings
  2. Enable "Device Flow" in the app settings
  3. Set scopes to include user:email,repo
  4. Build with your client ID:
    GITHUB_CLIENT_ID=your_client_id_here pnpm run build
    
Description
Get 10X more out of Claude Code, Codex or any coding agent
https://www.vibekanban.com/
Readme Apache-2.0 48 MiB
Languages
Rust 51.1%
TypeScript 46.6%
CSS 1.1%
JavaScript 0.7%
PLpgSQL 0.2%
Other 0.2%