main
736 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Anthony Mahé
|
9766f9930d |
feat(i18n): add French (FR) language support (#2113)
* feat(i18n): add French (FR) language support - Add Fr variant to UiLanguage enum in Rust backend - Create French locale directory with 5 translation files: - common.json: Common UI elements (buttons, states, navigation) - settings.json: Settings pages translations - projects.json: Project management strings - tasks.json: Task-related strings - organization.json: Organization management strings - Update languages.ts with FR mapping and Français endonym - Update config.ts to import and register French resources Follows the pattern established by PR #994 (Korean) and PR #795 (Spanish) * fmt * fix i18n * types * fix(i18n): add missing customise key to fr/common.json * fix(i18n): add missing customise key to fr/common.json --------- Co-authored-by: Gabriel Gordon-Hall <ggordonhall@gmail.com> |
||
Louis Knight-Webb
|
6f7b0b6ebc |
feat: add 'Customise' option to variants dropdown (#2116)
Add a 'Customise' menu item to the variants dropdown in the chat box that navigates users to the Agent Settings page (/settings/agents) where they can configure executor variants. - Add onCustomise callback to VariantProps interface in ChatBoxBase - Render separator and Customise option with gear icon in dropdown - Add navigation handler in SessionChatBoxContainer and CreateChatBoxContainer - Add i18n translations for all supported locales Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> |
||
|
Louis Knight-Webb
|
14c9df626a |
Add ESLint rule to ban optional props in container components (Vibe Kanban) (#2115)
* Done. The ESLint rule is now in place, banning optional props in all ui-new components.
**Summary:**
- Added the rule to `frontend/.eslintrc.cjs` targeting `TSPropertySignature[optional=true]`
- The rule applies to all files under `src/components/ui-new/**/*.{ts,tsx}`
**Impact Assessment - 100 violations across:**
| Category | Files | Violations |
|----------|-------|------------|
| **primitives/** | 11 files | ~40 violations |
| **views/** | 5 files | ~15 violations |
| **containers/** | 5 files | ~10 violations |
| **dialogs/** | 7 files | ~15 violations |
| **Root-level** | 5 files | ~15 violations |
| **types/** | 1 file | 5 violations |
The most affected files are:
- `primitives/Dropdown.tsx` (14 violations)
- `primitives/RepoCard.tsx` (12 violations)
- `NewDisplayConversationEntry.tsx` (11 violations)
- `primitives/CommandBar.tsx` (5 violations)
Would you like me to start refactoring these components to comply with the new rule?
* Done. The rule now only applies to `containers/`.
**Summary:**
- Removed the optional props ban from the general `ui-new/**` override
- Added a new override specifically for `src/components/ui-new/containers/**/*.{ts,tsx}`
**Impact reduced from 100 to 48 violations**, all now in container components:
| File | Violations |
|------|------------|
| SessionChatBoxContainer.tsx | 11 |
| DiffViewCardWithComments.tsx | 9 |
| SearchableDropdownContainer.tsx | 6 |
| FileTreeContainer.tsx | 3 |
| PreviewControlsContainer.tsx | 3 |
| ChangesPanelContainer.tsx | 2 |
| LogsContentContainer.tsx | 2 |
| PreviewBrowserContainer.tsx | 2 |
| WorkspacesLayout.tsx | 2 |
| WorkspacesMainContainer.tsx | 2 |
| + 6 more files | 6 |
* All ESLint issues in `SessionChatBoxContainer.tsx` have been fixed. Here's a summary of the changes:
1. **Removed dead code**:
- Removed `taskId` prop (never passed by call site)
- Removed `workspaceId` aliasing and fallback (`propWorkspaceId ?? session?.workspace_id`)
2. **Updated interface** - Changed all optional props (`?`) to explicit types:
- Props that can be undefined use `Type | undefined` instead of `Type?`
- Props with defaults (`sessions`, `isNewSessionMode`) are now required in the interface
3. **Added explicit defaults** in destructuring for all props:
- `session = undefined`, `onSelectSession = undefined`, `projectId = undefined`, `onStartNewSession = undefined`, `workspaceId = undefined`
- `filesChanged = 0`, `linesAdded = 0`, `linesRemoved = 0`
- `sessions = []`, `isNewSessionMode = false`
* Done. I've refactored `SessionChatBoxContainer.tsx` to use a discriminated union for props. Here's a summary:
**Changes made:**
1. **Defined discriminated union type** with three modes:
- `existing-session`: Has a `session` (required), `onSelectSession`, `onStartNewSession`
- `new-session`: Has a `workspaceId` (required), `onSelectSession`
- `placeholder`: Has `workspaceId` (optional), no callbacks
2. **Updated component** to extract mode-specific values from props based on the discriminant
3. **Updated call site** (`WorkspacesMain.tsx`) to pass the correct mode and props based on state
**Benefits:**
- No more redundant `= undefined` defaults for props that are required in their respective modes
- Type safety ensures each mode has exactly the props it needs
- Self-documenting code with explicit mode discriminant
- ESLint and TypeScript checks pass
* Cleanup script changes for workspace f4ec6f6e-a524-4760-889a-7ec2ebbce4c6
* Both lint and type check pass. I've removed `workspaceId` from `PlaceholderProps` since it's not needed when the editor is disabled in placeholder mode.
* All tasks are complete. Here's a summary of the changes made:
## Summary
I've refactored `DiffViewCardWithComments.tsx` and its related files to fix 11 ESLint errors (9 in DiffViewCardWithComments, 1 in CommentWidgetLine, 1 in ReviewCommentRenderer).
### Changes Made:
1. **`DiffViewCardWithComments.tsx`** - Converted to use discriminated unions:
- `DiffInput` type: Changed optional props (`oldPath?`, `changeKind?`, `hasLineNumbers?`) to explicit union types (`oldPath: string | undefined`)
- `DiffViewCardWithCommentsProps`: Split into two modes using a discriminated union:
- `CollapsibleProps` (mode: 'collapsible') - requires `expanded` and `onToggle`
- `StaticProps` (mode: 'static') - always expanded, no toggle
- Base props (`status`, `className`, `projectId`, `attemptId`) now use `T | undefined` instead of `T?`
2. **`CommentWidgetLine.tsx`** - Changed `projectId?: string` to `projectId: string | undefined`
3. **`ReviewCommentRenderer.tsx`** - Changed `projectId?: string` to `projectId: string | undefined`
4. **`ChangesPanel.tsx`** (callsite) - Updated to pass the new required props:
- Added `mode="collapsible"`
- Added `status={undefined}`
- Added `className=""`
### Verification:
- ✅ ESLint passes for all modified files
- ✅ TypeScript type check passes
* Cleanup script changes for workspace f4ec6f6e-a524-4760-889a-7ec2ebbce4c6
* Done. Here's a summary of all changes:
## Summary
Refactored `DiffViewCardWithComments.tsx` and its callsites to fix ESLint issues:
### Changes Made:
1. **`DiffViewCardWithComments.tsx`**:
- Removed unused `status` prop and `ToolStatusDot` rendering
- Made `projectId` and `attemptId` required strings (no longer `undefined`)
- Removed conditional check for `attemptId` on the Open in IDE button (always shown now)
2. **`ChangesPanel.tsx`**:
- Made `projectId` and `attemptId` required strings
- Removed `status={undefined}` from the component call
3. **`CommentWidgetLine.tsx`**:
- Changed `projectId: string | undefined` to `projectId: string`
4. **`ReviewCommentRenderer.tsx`**:
- Changed `projectId: string | undefined` to `projectId: string`
5. **`ChangesPanelContainer.tsx`**:
- Made `className` and `attemptId` required props
- Added guard: if `projectId` is unavailable, renders empty panel
6. **`WorkspacesLayout.tsx`**:
- Added guard: only renders `ChangesPanelContainer` when `selectedWorkspace?.id` exists
- Passes required `className=""` prop
### Verification:
- ✅ TypeScript type check passes
- ✅ ESLint passes for all modified files
* Done. Changed `changeKind` from `DiffChangeKind | undefined` to `DiffChangeKind` in the `DiffInput` type. Both TypeScript and ESLint pass.
* Done. I've successfully refactored `SearchableDropdownContainer.tsx` to fix the 6 ESLint errors:
**Changes made:**
1. **`SearchableDropdownContainer.tsx`** (interface):
- `selectedValue: string | null` (removed `?`)
- `filterItem: ((item: T, query: string) => boolean) | null` (removed `?`, added `| null`)
- `contentClassName: string` (removed `?`)
- `placeholder: string` (removed `?`)
- `emptyMessage: string` (removed `?`)
- `getItemBadge: ((item: T) => string | undefined) | null` (removed `?`, added `| null`)
2. **`SearchableDropdownContainer.tsx`** (implementation):
- Removed default values from destructuring (`placeholder = 'Search'`, `emptyMessage = 'No items found'`)
- Changed `if (filterItem)` to `if (filterItem !== null)`
- Changed `getItemBadge={getItemBadge}` to `getItemBadge={getItemBadge ?? undefined}`
3. **`RepoCardSimple.tsx`** (callsite):
- Added `filterItem={null}`
- Changed `selectedValue={selectedBranch}` to `selectedValue={selectedBranch ?? null}` to handle the case when `selectedBranch` is `undefined`
All ESLint errors for `SearchableDropdownContainer.tsx` are now resolved, and TypeScript compiles without errors.
* Refactor FileTreeContainer to fix ESLint errors for optional props
- Make all props required in FileTreeContainerProps interface
- Add guard in RightSidebar to only render Changes section when
selectedWorkspace exists, ensuring workspaceId is always defined
- Remove redundant null check for onSelectFile callback
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* Refactor NewDisplayConversationEntry to fix ESLint errors for optional props
- Remove dead `task` prop from NewDisplayConversationEntry and ConversationListContainer
(was only passed to legacy DisplayConversationEntry for entry types that don't use it)
- Make `executionProcessId` and `taskAttempt` required props
- Convert internal helper component optional props from `prop?: T` to `prop: T | undefined`
to satisfy ESLint while preserving the same runtime behavior
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* Refactor VirtualizedProcessLogs to fix ESLint errors for optional props
Made search-related props required instead of optional:
- searchQuery: string (was optional)
- matchIndices: number[] (was optional)
- currentMatchIndex: number (was optional)
Updated callsites to provide explicit "no search" values where search
functionality is not used.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* Cleanup script changes for workspace f4ec6f6e-a524-4760-889a-7ec2ebbce4c6
* Refactor container components to fix ESLint errors for optional props
Made the following props required (parents always provide them):
- BrowseRepoButtonContainer: disabled
- CopyButton: disabled
- WorkspacesMainContainer: isNewSessionMode, onStartNewSession
- LogsContentContainer: className
- PreviewBrowserContainer: attemptId, className
- PreviewControlsContainer: attemptId, className
Changed to union types (legitimately optional values):
- LogsContentContainer: command: string | undefined
- ProjectSelectorContainer: selectedProjectName: string | undefined
Added guards in parent components to only render children when
required data is available (RightSidebar, WorkspacesLayout).
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* Cleanup script changes for workspace f4ec6f6e-a524-4760-889a-7ec2ebbce4c6
* Refactor WorkspacesLayout to fix ESLint errors for optional props
Extract create mode sections into dedicated container components:
- CreateModeProjectSectionContainer: project selector with useCreateMode
- CreateModeReposSectionContainer: repos list with branch auto-selection
- CreateModeAddReposSectionContainer: add repos section
This removes the ModeProviderProps interface with optional props that
violated the ESLint rule. Now CreateModeProvider is only rendered when
in create mode, and each container manages its own context access.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* Cleanup script changes for workspace f4ec6f6e-a524-4760-889a-7ec2ebbce4c6
---------
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
|
||
GitHub Action
|
d1d0b7eacd | chore: bump version to 0.0.155 | ||
|
Louis Knight-Webb
|
f2fdeb13fe |
Revert "don't hide tasks if streams fail (#2053)"
This reverts commit
|
||
|
GitHub Action
|
4ffd7c92b9 | chore: bump version to 0.0.154 | ||
|
Louis Knight-Webb
|
d941e9a5e0 |
Add integrated terminal with PTY backend and xterm.js frontend (Vibe Kanban) (#2104)
* integrated terminal
* ci
* persist terminal
* Done! I've moved the TerminalPanelContainer from the main panel area to the right sidebar. Here's a summary of the changes:
- Added `isTerminalVisible: boolean` to global state (defaults to `true`)
- Added `toggleTerminal()` and `setTerminalVisible(value)` actions
- Added `isTerminalVisible` to the persisted state and the `useWorkspacePanelState` hook
- Imported `TerminalPanelContainer` and `useUiPreferencesStore`
- Restructured the component to always include a terminal section at the bottom (when not in create mode and `isTerminalVisible` is true)
- Dynamic flex ratios:
- With upper content + terminal: flex-4 (content) / flex-2 (git) / flex-4 (terminal)
- Without upper content + terminal: flex-3 (git) / flex-7 (terminal)
- When terminal is hidden: original ratios preserved
- Removed the `TerminalPanelContainer` import
- Removed the TERMINAL case from the right main panel rendering
- Added `isTerminalVisible` to `ActionVisibilityContext` interface
- Updated `ToggleTerminalMode` action to use `toggleTerminal()` and check `isTerminalVisible`
- Added `isTerminalVisible` from `panelState` to the visibility context
The terminal now appears permanently at the bottom of the right sidebar (when visible), and the toggle button collapses/expands just the terminal section within the sidebar. The visibility state is persisted to localStorage.
* Frontend ESLint passes with no errors. The backend Rust error (`crates/utils/src/shell.rs:31`) is a pre-existing issue in the codebase, not related to my changes.
* `cargo check` passes now. The fix was adding `.to_path_buf()` to convert the `&Path` reference to an owned `PathBuf`.
* The code compiles. Done! I've added three environment variables in `crates/local-deployment/src/pty.rs:73-75`:
1. `ZDOTDIR=/nonexistent` - prevents zsh from loading `~/.zshrc`
2. `PS1="$ "` - sets the bash prompt
3. `PROMPT="$ "` - sets the zsh prompt
The terminal prompt will now show just `$ ` instead of `lkw@Louiss-MacBook-Pro vibe-kanban %`. Run `pnpm run dev:qa` and open the terminal panel to verify.
* Cleanup script changes for workspace 928e696e-5f40-4603-9227-798f0520e07f
* Done! The fix is simpler - using `cmd.arg("-f")` to tell zsh/bash to skip loading config files. This:
1. Removes the `ZDOTDIR=/nonexistent` that was causing errors
2. Adds `-f` flag which skips `.zshrc`/`.bashrc` loading
3. Keeps `PS1` and `PROMPT` env vars which will now be respected
Run `pnpm run dev:qa` and open the terminal to verify the prompt shows `$ `.
* Cleanup script changes for workspace 928e696e-5f40-4603-9227-798f0520e07f
* I've implemented the terminal theme integration. Here's a summary of the changes:
## Changes Made
**1. Created `frontend/src/utils/terminalTheme.ts`**
- `hslToHex()` function to convert HSL CSS variable format (`"210 40% 98%"`) to hex colors
- `getCssVariable()` helper to read CSS variables from the `.new-design` element
- `getTerminalTheme()` function that builds an xterm.js `ITheme` object from CSS variables:
- Uses `--console-background` and `--console-foreground` for main colors
- Uses `--console-success` and `--console-error` for green/red ANSI colors
- Provides appropriate ANSI color palettes for both light and dark modes
**2. Updated `frontend/src/components/ui-new/terminal/XTermInstance.tsx`**
- Imported `useTheme` hook and `getTerminalTheme` utility
- Replaced hardcoded Tokyo Night theme with dynamic `getTerminalTheme()` call
- Added effect to update terminal theme when app theme changes (`terminal.options.theme = getTerminalTheme()`)
The terminal will now:
- Initialize with colors matching the current theme
- Automatically update colors when switching between light and dark mode
- Use the console color variables defined in `index.css`
* Cleanup script changes for workspace 928e696e-5f40-4603-9227-798f0520e07f
* Now I understand the issue clearly. Here are the relevant variables:
| Variable | Light Mode | Dark Mode | Purpose |
|----------|------------|-----------|---------|
| `--_primary` | `0 0% 5%` (dark) | `240 4.8% 95.9%` (light) | Button background - **inverted** |
| `--_console-background` | `0 0% 100%` (white) | `0 0% 0%` (black) | Terminal background - **correct** |
| `--_console-foreground` | `0 0% 5%` (dark) | `210 40% 98%` (light) | Terminal text - **correct** |
| `--bg-primary` | `0 0% 100%` (white) | `0 0% 13%` (dark gray) | Page background |
The code was changed to use `--primary` but that's the wrong variable. For the terminal, you should use:
- `--console-background` / `--_console-background` for the background
- `--console-foreground` / `--_console-foreground` for the text
Or if you prefer to match other UI elements:
- `--bg-primary` for background
- `--text-high` for foreground text
Which approach would you prefer? The original `--console-*` variables were specifically designed for terminal styling, or we can use `--bg-primary`/`--text-high` to match the general UI background.
* Cleanup script changes for workspace 928e696e-5f40-4603-9227-798f0520e07f
* Done. The terminal will now use `--bg-primary` for the background and `--text-high` for the foreground text. This means:
- **Light mode**: White background (`0 0% 100%`) with dark text (`0 0% 5%`)
- **Dark mode**: Dark gray background (`0 0% 13%`) with light text (`0 0% 96%`)
* Done. The terminal will now use `--bg-secondary` for the background and `--text-high` for the foreground text. This means:
- **Light mode**: Light gray background (`0 0% 95%`) with dark text (`0 0% 5%`)
- **Dark mode**: Darker gray background (`0 0% 11%`) with light text (`0 0% 96%`)
* Let me know if you find any issues during testing or need adjustments!
* Cleanup script changes for workspace 928e696e-5f40-4603-9227-798f0520e07f
* terminal
* sidebar cleanup
* fix chat collapse
Amp-Thread-ID: https://ampcode.com/threads/T-019bc754-8db9-712a-a915-58d74d210cad
Co-authored-by: Amp <amp@ampcode.com>
* for the terminal on windows we need to default to powershell if avalibale for the pty (vibe-kanban 049dbf73)
only if powershell.exe cannot be resolved, we should use cmd.
* he colour theme used for the terminal ui isn't visible enough in light mode (vibe-kanban 5f50878a)
t I think we either don't override the ANSI colour mapping with our own, or it's not contrasted enough
* fmt
---------
Co-authored-by: Gabriel Gordon-Hall <ggordonhall@gmail.com>
Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: Solomon <abcpro11051@disroot.org>
|
||
Solomon
|
10f6a9171a |
feat: display context usage in UI for Codex and Claude Code (#1775)
* feat: display context usage in UI for Codex executor - Extract token usage data from Codex execution logs. - Track usage state within the `EntriesContext`. - Display a context usage progress bar in the next action card. * Add claude-code context token usage * fix type issue --------- Co-authored-by: Louis Knight-Webb <louis@bloop.ai> |
||
Alex Netsch
|
ee212c5e61 |
Add Claude Code Stop hook for uncommitted changes check (Vibe Kanban) (#2049)
* The implementation is complete. Here's a summary of the changes: ## Summary I added a check for commits made by the coding agent during execution. If commits were made, the cleanup script will now run. ### Changes Made **File: `crates/local-deployment/src/container.rs`** 1. **Added new method `has_commits_from_execution`** (lines 314-344): This method compares the `before_head_commit` (captured at execution start) with the current HEAD for each repo to detect if any commits were made during execution. 2. **Updated the `should_start_next` logic** (lines 477-490): The decision to run the cleanup script now checks both: - Whether uncommitted changes were just committed (`changes_committed`) - Whether the agent made any commits during execution (`has_commits_from_execution`) If either condition is true, the cleanup script runs. ### How It Works - Before: Cleanup script only ran if `try_commit_changes()` returned `true` (i.e., if there were uncommitted changes to commit) - After: Cleanup script runs if `try_commit_changes()` returned `true` **OR** if `has_commits_from_execution()` returns `true` (i.e., HEAD changed from what it was at execution start) This ensures that if a coding agent makes commits during its execution but leaves no uncommitted changes, the cleanup script will still run. * feat: add Claude Code hooks for cleanup scripts in worktrees When a workspace is created with repos that have cleanup scripts configured, automatically create .claude/settings.local.json with a "Stop" hook that runs the cleanup scripts when the agent finishes. - Add create_claude_hooks_config() to create .claude/hooks/run-cleanup.sh - Handle single-repo (agent in repo dir) vs multi-repo (agent in workspace root) - Also add has_commits_from_execution() to run cleanup when agent made commits Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * All tests pass. The fix is complete - the Claude Code hooks will now always be created regardless of whether repos have cleanup scripts configured. * Cleanup script changes for workspace bf914d08-cb51-49a4-89b9-ba56108c841a * Done. I've implemented the simplified `check-git-status.sh` hook using `include_str!`: 1. Created `crates/local-deployment/src/scripts/check-git-status.sh` - the script that checks for uncommitted changes and blocks the agent until they commit 2. Updated `crates/local-deployment/src/container.rs`: - Added `const CHECK_GIT_STATUS_SCRIPT: &str = include_str!("scripts/check-git-status.sh");` to embed the script at compile time - Simplified `create_claude_hooks_config()` to only write this one hook script (removed all the cleanup script logic) The hook will now be created in `.claude/hooks/check-git-status.sh` and configured in `.claude/settings.local.json` as a "Stop" hook for Claude Code workspaces. * Done. I've implemented the Stop hook via the protocol in `claude.rs`: **Summary of changes:** 1. **Created** `crates/executors/src/scripts/check-git-status.sh` - The script that checks for uncommitted changes 2. **Modified** `crates/executors/src/executors/claude.rs`: - Added `const CHECK_GIT_STATUS_SCRIPT` using `include_str!` to embed the script at compile time - Updated `get_hooks()` to always include a Stop hook with the script (using `shlex::try_quote` for proper escaping) - The Stop hook is now sent via `protocol_peer.initialize(hooks)` alongside any PreToolUse hooks 3. **Removed** from `crates/local-deployment/src/container.rs`: - Deleted `create_claude_hooks_config()` function - Deleted the const and call to create hooks - Deleted the `scripts/` directory Now the hook is sent via the protocol, so no files are created in the workspace that would show up as untracked. * Done. I've updated the implementation to use `settings.local.json` with the script inlined via `bash -c`: **Summary of changes:** 1. **Reverted `crates/executors/src/executors/claude.rs`**: - Removed `CHECK_GIT_STATUS_SCRIPT` const - Restored `get_hooks()` to only return PreToolUse hooks (no Stop hook) 2. **Moved script to `crates/local-deployment/src/scripts/check-git-status.sh`** 3. **Added `shlex = "1.3.0"` to `crates/local-deployment/Cargo.toml`** 4. **Updated `crates/local-deployment/src/container.rs`**: - Added `CHECK_GIT_STATUS_SCRIPT` const using `include_str!` - Added `create_claude_hooks_config()` function that: - Only runs for single-repo workspaces - Creates `.claude/settings.local.json` with the script inlined via `bash -c` using `shlex::try_quote` for proper escaping - No `.claude/hooks/` directory is created (script is fully inline) - Called from `create_workspace_config_files()` Since `settings.local.json` is already gitignored by Claude Code, this approach avoids the untracked file issue while keeping the script in a separate file for maintainability. * Cleanup script changes for workspace bf914d08-cb51-49a4-89b9-ba56108c841a * Done. The Claude hooks setup now only runs for Claude Code executor. **Changes made to `crates/local-deployment/src/container.rs`:** 1. Removed the call to `create_claude_hooks_config()` from `create_workspace_config_files()` (and changed parameter back to `_agent_working_dir`) 2. Added the hooks setup in `start_execution_inner()` with a check for Claude Code executor: ```rust if let Some(BaseCodingAgent::ClaudeCode) = executor_action.base_executor() { Self::create_claude_hooks_config( ¤t_dir, workspace.agent_working_dir.as_deref(), ) .await?; } ``` Now the `settings.local.json` with the Stop hook will only be created when running with the Claude Code executor, not for other executors like Codex, Gemini, etc. * Cleanup script changes for workspace bf914d08-cb51-49a4-89b9-ba56108c841a * Done. The implementation now explicitly checks the repo count: **Changes to `crates/local-deployment/src/container.rs`:** 1. **Updated call site in `start_execution_inner()`:** ```rust if let Some(BaseCodingAgent::ClaudeCode) = executor_action.base_executor() { let repos = WorkspaceRepo::find_repos_for_workspace(&self.db.pool, workspace.id).await?; if repos.len() == 1 { if let Some(agent_dir) = &workspace.agent_working_dir { Self::create_claude_hooks_config(¤t_dir.join(agent_dir)).await?; } } } ``` 2. **Simplified `create_claude_hooks_config()`:** - Now takes just `repo_dir: &Path` (the full path to the repo directory) - Removed the `agent_working_dir` parameter and internal check - The caller is responsible for ensuring this is only called for single-repo workspaces * Cleanup script changes for workspace bf914d08-cb51-49a4-89b9-ba56108c841a * Done. I've successfully implemented the Stop hook via protocol callbacks instead of the file-based approach. Here's a summary of the changes: ## Summary **Files modified:** 1. `crates/executors/src/executors/claude/client.rs`: - Added `working_dir: PathBuf` field to `ClaudeAgentClient` - Added `STOP_GIT_CHECK_CALLBACK_ID` constant - Updated `on_hook_callback()` to handle Stop git check callbacks - Added `check_git_status()` async function that checks for uncommitted changes - Added `find_git_repo_in_subdirs()` helper for multi-repo fallback 2. `crates/executors/src/executors/claude.rs`: - Updated `get_hooks()` to always include a Stop hook with callback ID - Passed `working_dir` to `ClaudeAgentClient::new()` in `spawn_internal()` - Added import for `STOP_GIT_CHECK_CALLBACK_ID` 3. `crates/local-deployment/src/container.rs`: - Removed `CHECK_GIT_STATUS_SCRIPT` constant - Removed `create_claude_hooks_config()` function - Removed the call to create file-based hooks in `start_execution_inner()` 4. `crates/local-deployment/Cargo.toml`: - Removed `shlex` dependency **Files deleted:** - `crates/local-deployment/src/scripts/check-git-status.sh` - `crates/local-deployment/src/scripts/` (empty directory) **Benefits of the new approach:** - No files created in the workspace (avoids untracked file issues) - Git status check runs dynamically via protocol callback - Supports single-repo workspaces with fallback to checking subdirectories - More portable - no dependency on bash or external scripts * Cleanup script changes for workspace bf914d08-cb51-49a4-89b9-ba56108c841a * Done. I've fixed the Stop hook response format. The changes: 1. **`check_git_status()`** now returns the correct format for Stop hooks: - When allowing stop: returns `{}` (empty object) - When blocking stop: returns `{"continue": false, "stopReason": "..."}` 2. **`on_hook_callback()`** now returns the Stop hook result directly without wrapping it in `hookSpecificOutput` The implementation now follows the Claude SDK documentation for Stop hooks, which use top-level `continue` and `stopReason` fields rather than the `hookSpecificOutput` wrapper used by PreToolUse hooks. * Done. I've updated the Stop hook response format to use `{"decision": "approve"}` or `{"decision": "block", "reason": "..."}` which matches the SDK callback format documented at code.claude.com/docs/en/hooks. * Fixed. Removed the unused `_agent_working_dir` parameter from `create_workspace_config_files` and updated both call sites. * Done. I've implemented the `RepoContext` struct to properly pass repository information from local-deployment to executors. Here's a summary of the changes: **Files modified:** 1. **`crates/executors/src/env.rs`**: - Added `RepoContext` struct with `workspace_root` and `repo_names` fields - Added `repo_paths()` method to get full paths to all repos - Added `repo_context: RepoContext` field to `ExecutionEnv` (required field) - Updated `ExecutionEnv::new()` to take `RepoContext` as parameter 2. **`crates/executors/src/executors/claude/client.rs`**: - Replaced `working_dir: PathBuf` with `repo_context: RepoContext` in `ClaudeAgentClient` - Updated `check_git_status()` to iterate over all repos and check each for uncommitted changes - Removed `find_git_repo_in_subdirs()` helper (no longer needed) 3. **`crates/executors/src/executors/claude.rs`**: - Updated `spawn_internal()` to pass `env.repo_context` to `ClaudeAgentClient` 4. **`crates/local-deployment/src/container.rs`**: - Added import for `RepoContext` - In `start_execution_inner()`: Load repos, build `RepoContext`, pass to `ExecutionEnv::new()` * Done. I've added the `commit_reminder` setting to `ClaudeCode`: 1. **Added `commit_reminder: Option<bool>` field** to the `ClaudeCode` struct in `claude.rs` 2. **Made the Stop hook conditional** - it now only registers when `commit_reminder` is `true` (defaults to `false`/off) 3. **Regenerated TypeScript types** so the frontend knows about the new field Users can enable the commit reminder by adding `"commit_reminder": true` to their profile configuration in `~/.config/vibe-kanban/profiles.json`. * Done. Removed all 10 obvious comments as requested. * Done. Now synthetic User messages (like the Stop hook feedback) will be rendered as `SystemMessage` entries in the logs. The implementation: 1. Added `is_synthetic: bool` field to `ClaudeJson::User` variant (with `#[serde(default, rename = "isSynthetic")]`) 2. When `is_synthetic` is true, any Text content in the message gets rendered as a `SystemMessage` entry * Fix tests * No findings in the latest commits I reviewed (048e3e1b5, 723ff78bd, c1caa1f73, 4af28b855, ad1334b94). Residual risk: I didn’t run tests, and the review is based on reading diffs only. Open questions / assumptions: - Assuming it’s intentional that the Stop hook is now opt-in via `commit_reminder` in `crates/executors/src/executors/claude.rs`. - Assuming workspaces always populate repo names; otherwise the Stop hook in `crates/executors/src/executors/claude/client.rs` will auto-approve when none are configured. Change summary: - Added repo context plumbed into executor env and multi-repo git status checks in `crates/executors/src/env.rs`, `crates/executors/src/executors/claude.rs`, `crates/executors/src/executors/claude/client.rs`, and `crates/local-deployment/src/container.rs`. - Introduced `commit_reminder` config and schema/types updates in `crates/executors/src/executors/claude.rs`, `shared/schemas/claude_code.json`, and `shared/types.ts`. - Render synthetic user messages as system log entries in `crates/executors/src/executors/claude.rs`. * Lint * Done. I've added the `commit_reminder` beta setting to the global Config: 1. **Backend Config** (`v8.rs`) - Added `commit_reminder: bool` field (defaults to `false`) 2. **Removed from ClaudeCode** - Removed per-profile field, now uses global setting 3. **ExecutionEnv** - Added `commit_reminder` field to pass setting to executors 4. **Container** - Reads setting from config and passes to `ExecutionEnv` 5. **Claude executor** - Uses `env.commit_reminder` when building hooks 6. **Frontend UI** - Added checkbox in Beta Features section 7. **i18n** - Added translation keys for all 6 locales (en, es, ja, ko, zh-Hans, zh-Hant) 8. **TypeScript types** - Regenerated via `pnpm run generate-types` Users can now enable the commit reminder feature from Settings > General > Beta Features. * All tests pass. Both `pnpm run lint` and `cargo test --workspace` complete successfully. --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> |
||
|
Louis Knight-Webb
|
0d6f51265b | don't hide tasks if streams fail (#2053) | ||
|
Louis Knight-Webb
|
010b03aafd |
Include workspace diff files in file typeahead results (Vibe Kanban) (#2083)
* The implementation is complete. Here's a summary of the changes made to `file-tag-typeahead-plugin.tsx`:
1. **Added import** for `useWorkspaceContext` from `@/contexts/WorkspaceContext`
2. **Created helper function** `getMatchingDiffFiles()` that:
- Takes a query and the `diffPaths` Set
- Filters paths that match the query (checking both filename and full path)
- Returns properly typed `DiffFileResult` objects with all required fields (`is_file`, `match_type`, `score`)
- Uses a high score value to ensure diff files rank above server results
3. **Modified `onQueryChange`** to:
- Extract `diffPaths` from WorkspaceContext
- Get matching local files from diffPaths first
- Fetch server results via `searchTagsAndFiles()`
- Deduplicate server file results by filtering out any paths already in local files
- Merge results with order: tags → local diff files → server files
The changes ensure that:
- Files from the current workspace diffs appear in typeahead results
- Diff files are ranked higher than server-sourced files
- No duplicate entries appear when a file exists in both sources
* Done. The fix involved two changes:
1. **`WorkspaceContext.tsx`** (line 78-81): Exported the `WorkspaceContext` so it can be used directly with `useContext`
2. **`file-tag-typeahead-plugin.tsx`**:
- Changed import from `useWorkspaceContext` to `WorkspaceContext`
- Added `useContext` to React imports
- Changed usage from `const { diffPaths } = useWorkspaceContext()` to:
```typescript
const workspaceContext = useContext(WorkspaceContext);
const diffPaths = workspaceContext?.diffPaths ?? new Set<string>();
```
Now when the WYSIWYG is used in the old UI (without a `WorkspaceProvider`), `workspaceContext` will be `null`, and `diffPaths` will default to an empty Set, meaning only server results will be shown. In the new UI with `WorkspaceProvider`, diff files will be included as expected.
* Done. The changes:
1. Added `MAX_FILE_RESULTS = 10` constant
2. Updated the result merging logic to:
- Limit local diff files to max 10
- Fill remaining slots with server files
- This ensures diffPaths files always appear first (prioritized)
File results are now capped at 10 total, preventing the menu from scrolling off the page.
* Cleanup script changes for workspace bda801c1-f48c-4ae8-948b-f0db6269d807
* Lint passes now. The fix was to wrap the `diffPaths` fallback in `useMemo` to ensure a stable reference when the context is not available.
|
||
|
Louis Knight-Webb
|
af8298744d |
Fix 'View Full Logs' button passing click event instead of process ID (Vibe Kanban) (#2080)
* The fix is complete. Here's a summary of the changes: **Problem**: Clicking "View Full Logs" button opened the logs panel but showed "Select a process to view logs" error because the process ID wasn't being passed to the logs panel context. **Root cause**: In `PreviewControlsContainer.tsx`, when `onViewProcessInPanel` was provided but `targetId` was falsy, the fallback path only switched the panel mode without setting which process to display. **Solution**: Modified `PreviewControlsContainer.tsx` to use `viewProcessInPanel` directly from the `LogsPanelContext` instead of relying on the prop. This ensures the process ID is always properly set when switching to the logs panel. **Changes made**: 1. `frontend/src/components/ui-new/containers/PreviewControlsContainer.tsx`: - Added import for `useLogsPanel` hook - Removed `onViewProcessInPanel` prop from interface - Use `viewProcessInPanel` from context directly - Updated `handleViewFullLogs` to call the context function 2. `frontend/src/components/ui-new/containers/RightSidebar.tsx`: - Removed unused `useLogsPanel` import - Removed `viewProcessInPanel` from destructuring - Removed `onViewProcessInPanel` prop from `PreviewControlsContainer` usage * All checks pass. The diagnostic logging is now in place. Here's a summary: ## Diagnostic Logging Added **Frontend** (`frontend/src/hooks/useLogStream.ts`): - Logs when WebSocket connection is opened with process ID - Logs successful connection - Logs errors with process ID - Logs close events with code and reason **Backend** (`crates/server/src/routes/execution_processes.rs`): - Logs when checking stream for an exec_id - Logs warning if no stream found - Logs when stream is found and WebSocket is being upgraded **Backend** (`crates/services/src/services/container.rs`): - Logs when looking up msg_store - Logs if in-memory store is found - Logs if falling back to DB - Logs DB record count or warnings if no logs found **Backend** (`crates/local-deployment/src/container.rs`): - Logs when creating a new store for a process - Logs when store is inserted into the map with map size ## Next Steps Run `pnpm run dev:qa`, reproduce the issue by: 1. Starting a dev server in a workspace 2. Clicking "View Full Logs" Then share the logs from: - **Browser console** (look for `[useLogStream]` messages) - **Backend terminal** (look for `stream_raw_logs`, `track_child_msgs_in_store` messages) * Cleanup script changes for workspace 5963230a-5419-40d6-89e9-b26519d38291 * The fix is complete. The issue was that `handleViewFullLogs` accepted an optional `processId` parameter, but when used as a button `onClick` handler, it received the click event instead. Since the click event object is truthy, the `??` operator didn't fall through to `activeProcess?.id`, causing the event object to be passed to `viewProcessInPanel()`. The fix removes the parameter so the function always uses `activeProcess?.id` directly. You can now test by running `pnpm run dev:qa` and clicking "View Full Logs" - it should correctly open the logs panel with the dev server logs. * All diagnostic logs have been removed. The fix is complete and all checks pass. |
||
|
Louis Knight-Webb
|
ede1511a50 |
fix: ScriptFixerDialog no longer overwrites unrelated scripts (Vibe Kanban) (#2078)
* All tasks are complete. Here's a summary of the changes made:
## Summary
Fixed the issue where `ScriptFixerDialog.tsx` was replacing cleanup and setup scripts with `null` when editing a dev server script.
### Changes Made:
1. **Added `serde_with` dependency** (`Cargo.toml` and `crates/db/Cargo.toml`)
- Added `serde_with = "3"` to enable the double option pattern
2. **Updated `UpdateRepo` struct** (`crates/db/src/models/repo.rs`)
- Changed all fields from `Option<T>` to `Option<Option<T>>` with the `double_option` serde helper
- Added `#[ts(optional, type = "...")]` annotations for proper TypeScript type generation
3. **Updated `Repo::update` method** (`crates/db/src/models/repo.rs`)
- Now properly handles three states:
- `None` = field absent → preserve existing value
- `Some(None)` = explicitly null → set to NULL
- `Some(Some(v))` = has value → update to value
4. **Updated `ScriptFixerDialog.tsx`** (`frontend/src/components/dialogs/scripts/ScriptFixerDialog.tsx`)
- Changed `handleSave` and `handleSaveAndTest` to only send the field being edited
- Removed `repos` from the dependency arrays since it's no longer used in the save functions
5. **Regenerated TypeScript types**
- `UpdateRepo` now has all fields as optional: `field?: type | null`
### Result:
The API now supports true partial updates. Clients can send only the fields they want to update, and existing values are preserved for omitted fields. Sending `null` explicitly will clear a field to NULL.
* Done. All Rust code has been formatted.
|
||
|
Louis Knight-Webb
|
75beab35d9 |
refactor: Clean up root-level files in ui-new folder (#2079)
## Summary Successfully cleaned up root level files in `frontend/src/components/ui-new/`: ### Deleted (unused files): - `MockConversationList.tsx` - not imported anywhere - `MockDisplayConversationEntry.tsx` - not imported anywhere ### Moved to `containers/`: - `ConversationList.tsx` → `containers/ConversationListContainer.tsx` - `NewDisplayConversationEntry.tsx` → `containers/NewDisplayConversationEntry.tsx` - `VirtualizedProcessLogs.tsx` → `containers/VirtualizedProcessLogs.tsx` ### Updated imports in: - `views/WorkspacesMain.tsx` - `views/PreviewControls.tsx` - `containers/LogsContentContainer.tsx` - `components/dialogs/scripts/ScriptFixerDialog.tsx` - `containers/ConversationListContainer.tsx` - `containers/NewDisplayConversationEntry.tsx` The root level of `ui-new/` is now clean with no files remaining. All components that use state or side effects were correctly placed in `containers/` to comply with ESLint rules. Both type check (`pnpm run check`) and lint (`pnpm run lint`) pass successfully. |
||
Anastasiia Solop
|
8ba3a50d0b |
The implementation is complete. Here's a summary of the changes made to frontend/src/components/ui-new/primitives/RepoCard.tsx: (#2073)
## Summary **Changes made:** 1. **Added `useMemo` import** (line 1) for memoizing the filtered options array 2. **Added logic to hide "Open pull request" when PR is open** (lines 101-109): - `hasPrOpen` checks if `prStatus === 'open'` - `availableActionOptions` filters out the 'pull-request' option when a PR is already open 3. **Added fallback for selected action** (lines 111-113): - `effectiveSelectedAction` ensures that if the user had previously selected 'pull-request' but a PR is now open, the button shows 'Merge' instead 4. **Updated SplitButton** to use `availableActionOptions` and `effectiveSelectedAction` (lines 286-291) **Behavior:** - When there is no open PR: Both "Open pull request" and "Merge" options are available - When there is an open PR (`prStatus === 'open'`): Only the "Merge" option is shown - When PR is closed or merged: The "Open pull request" option reappears (allowing users to create a new PR) |
||
Gabriel Gordon-Hall
|
e5920d7e00 | add antigravity icon (#2066) | ||
|
Louis Knight-Webb
|
e1b0ef70a4 |
feat: Remember panel state per workspace (Vibe Kanban) (#2064)
* I've successfully implemented workspace-specific panel state persistence. Here's a summary of the changes:
## Summary
### Changes Made
1. **`frontend/src/stores/useUiPreferencesStore.ts`**
- Added `WorkspacePanelState` type to track `rightMainPanelMode` and `isLeftMainPanelVisible` per workspace
- Added `workspacePanelStates: Record<string, WorkspacePanelState>` to store state keyed by workspace ID
- Updated `toggleLeftMainPanel`, `toggleRightMainPanelMode`, `setRightMainPanelMode`, and `setLeftMainPanelVisible` to accept an optional `workspaceId` parameter
- Added `getWorkspacePanelState` and `setWorkspacePanelState` actions
- Added `useWorkspacePanelState(workspaceId)` hook for easy consumption
- Updated `partialize` to persist `workspacePanelStates` to localStorage
2. **`frontend/src/components/ui-new/containers/WorkspacesLayout.tsx`**
- Changed from using `useUiPreferencesStore` directly to using `useWorkspacePanelState(workspaceId)` hook
- Panel state is now workspace-specific
3. **`frontend/src/components/ui-new/actions/useActionVisibility.ts`**
- Updated to use `useWorkspacePanelState` for visibility context
4. **`frontend/src/components/ui-new/actions/index.ts`**
- Updated `ToggleLeftMainPanel`, `ToggleChangesMode`, `ToggleLogsMode`, `TogglePreviewMode`, and `ToggleDevServer` actions to pass `currentWorkspaceId` when toggling panel modes
### Scope
**Workspace-specific:**
- `rightMainPanelMode` - Which panel (Preview/Changes/Logs) is open
- `isLeftMainPanelVisible` - Whether the chat panel is visible
**Stays global:**
- `isLeftSidebarVisible` - Workspace list sidebar (navigation element)
- `isRightSidebarVisible` - Git/Settings sidebar (global actions)
- Panel sizes (already work correctly)
### Testing
Verified the feature works:
1. Opened Preview panel in Workspace A
2. Navigated to Workspace B → Preview panel is closed (default state)
3. Navigated back to Workspace A → Preview panel is still open ✓
* Cleanup script changes for workspace c8b73e59-ac41-4c0f-be78-7b6499d514f9
* The refactoring is complete. Let me provide a summary of the changes:
## Summary
Refactored `useUiPreferencesStore.ts` to remove duplicate code paths for workspace-specific panel state:
### Changes Made
1. **`frontend/src/stores/useUiPreferencesStore.ts`**
- Removed legacy global state (`isLeftMainPanelVisible`, `rightMainPanelMode`) from State type and initialization
- Simplified 4 panel state actions by removing `else` branches for legacy behavior:
- `toggleLeftMainPanel` - now early-returns if no workspaceId
- `toggleRightMainPanelMode` - simplified to single set() call
- `setRightMainPanelMode` - simplified to single set() call
- `setLeftMainPanelVisible` - simplified
- Removed `resetForCreateMode` action (was only setting legacy state)
- Removed unused `useIsRightMainPanelVisible` hook
2. **`frontend/src/contexts/WorkspaceContext.tsx`**
- Removed the `useEffect` that called `resetForCreateMode()` on create mode
- Removed unused `useUiPreferencesStore` import
3. **`frontend/src/contexts/LogsPanelContext.tsx`**
- Updated to use `useWorkspacePanelState` with workspace ID from context
4. **`frontend/src/components/ui-new/containers/SessionChatBoxContainer.tsx`**
- Updated to use `useWorkspacePanelState` with workspace ID
### Impact
- **~50 lines removed** from the codebase
- **Cleaner code** - no more `if (workspaceId) ... else ...` branching in every action
- **Same behavior** - all callers were already passing workspaceId
* Cleanup script changes for workspace c8b73e59-ac41-4c0f-be78-7b6499d514f9
|
||
|
Louis Knight-Webb
|
1e8783331c | Fix script dialog (#2065) | ||
Britannio Jarrett
|
9106c8223a |
feat: Add Zed remote SSH support (Vibe Kanban) (#1666)
* Done. Added Zed remote SSH support using the `zed://ssh/` protocol URL format.
**Generated URL format**: `zed://ssh/{user}@{host}{path}`
Examples:
- `zed://ssh/192.168.1.10/home/user/.vimrc`
- `zed://ssh/brit@scepcy/home/brit/projects/scepsy/`
* Restored the comment.
* Done. Added Zed to the frontend condition so the remote SSH host/user fields now appear when Zed is selected as the editor.
* add antigravity as an option in settings
* use early return for zed case to remove extra match statement
|
||
|
GitHub Action
|
7b465cbae6 | chore: bump version to 0.0.153 | ||
|
Louis Knight-Webb
|
4a6e556ed2 |
Simplify WorkspaceSummary card hover UI with opacity fade and single action button (Vibe Kanban) (#2059)
* All changes are complete. Here's a summary of what was changed: ## Summary of Changes ### `WorkspaceSummary.tsx` 1. **Title truncation**: Replaced `truncate` class with CSS mask gradient that fades to transparent (no ellipsis dots) 2. **Simplified hover actions**: Removed pin and archive buttons, keeping only the "more options" (ListIcon) button 3. **Removed sliding animation**: The action button now uses simple opacity transition (`opacity-0 group-hover:opacity-100`) instead of the sliding animation 4. **Removed unused code**: `handleArchive`, `handlePin` functions and `ArchiveIcon` import removed 5. **Removed unused props**: `onArchive` and `onPin` props removed from interface ### `WorkspacesSidebar.tsx` - Removed `onArchiveWorkspace` and `onPinWorkspace` props from interface and destructuring ### `WorkspacesSidebarContainer.tsx` - Removed `handleArchiveWorkspace` and `handlePinWorkspace` callbacks - Removed unused imports (`useCallback`, `useActions`, `Actions`) All type checks pass. The pin and archive functionality is still accessible through the command bar (more options button). * Cleanup script changes for workspace 262a1c1d-87ae-40f5-a36d-f43758d18fed * Done. Changed `ListIcon` to `DotsThreeIcon` with `weight="bold"` for the more options button. * Done. Changed the icon size from `size-icon-xs` to `size-5` (20px) while keeping the bold weight. * Done. Added the `ArchiveWorkspace` action to the left side of the navbar in `NavbarActionGroups.left`. |
||
|
Anastasiia Solop
|
e80af6b8e5 |
Fix mobile preview scaling to fit container (Vibe Kanban) (#2057)
* The fix is in place. Let me summarize the changes made: ## Summary Fixed the mobile preview browser by implementing automatic scaling when the phone frame doesn't fit in the container. ### Changes made: **`frontend/src/components/ui-new/views/PreviewBrowser.tsx`:** 1. Exported constants `MOBILE_WIDTH`, `MOBILE_HEIGHT`, and `PHONE_FRAME_PADDING` for use in the container 2. Added `mobileScale` prop to the component interface 3. Changed the content area's overflow from always `overflow-auto` to `overflow-hidden` when in mobile mode (to prevent scrollbars when the scaled content is smaller) 4. Applied CSS `transform: scale()` to the phone frame when `mobileScale < 1`, using `origin-center` to scale from the center **`frontend/src/components/ui-new/containers/PreviewBrowserContainer.tsx`:** 1. Imported `useLayoutEffect` and the exported constants from `PreviewBrowser` 2. Added `mobileScale` state that calculates the appropriate scale factor 3. Added a `useLayoutEffect` that: - Only runs when in mobile mode - Uses `ResizeObserver` to track container size changes - Calculates scale based on available space vs. phone frame dimensions - Never scales up (only down when needed) 4. Passes `mobileScale` prop to the `PreviewBrowser` component The mobile preview will now automatically scale down to fit within the available container space, preventing the vertical cutoff issue. * Cleanup script changes for workspace abe7b640-b3ea-4716-850e-6fd096ac1a3e |
||
|
Louis Knight-Webb
|
ea5954c8f5 |
Refactor WorkspacesLayout (#2052)
* init refactor * changes context * wip * logs context * workspaces layout context breakdown * sidebar context * move diffs to workspace context * compress workspaces layout * refactors * types * always show archived |
||
|
Gabriel Gordon-Hall
|
4071993561 | remove rogue files (#2048) | ||
|
Alex Netsch
|
fbe61013b0 |
Done! I've added the missing i18n translation keys to all 6 locale files. The following keys were added to each common.json: (#1970)
- `logs.searchLogs` - Placeholder text for the search input in the logs panel - `logs.selectProcessToView` - Empty state message when no process is selected - `processes.noProcesses` - Empty state message when no processes exist - `search.matchCount` - Shows current match position (e.g., "1 of 5") - `search.noMatches` - Shown when search has no results All type checks pass (`pnpm run check` completed successfully). |
||
Theo Browne
|
d54a46209b |
sidebar ui changes, loading state fixes (#2039)
* tons of sidebar ui cleanup, loading states etc * lint fix * fix archive store * i18n --------- Co-authored-by: Louis Knight-Webb <louis@bloop.ai> |
||
Daniel Ehrhardt
|
0ccb1ecd0a |
feat: added Google Antigravity (#1726)
* feat: added Google Antigravity * Update types.ts * Update IdeIcon.tsx |
||
|
Louis Knight-Webb
|
7cf83ef5ef |
fix: improve typeahead selected item visibility in light mode (Vibe Kanban) (#2036)
* Done. I've updated both the Tags section and Files section in the typeahead plugin. The changes: 1. Added `border-l-2` to all items to create a left border 2. For selected items: `border-l-brand` (orange accent color) + `bg-muted` + `text-high` 3. For unselected items: `border-l-transparent` + `hover:bg-muted` + `text-muted-foreground` 4. Removed the redundant `text-foreground` class that was conflicting with `text-high` The selected item now has a visible orange/brand-colored left border indicator that provides clear visual feedback in both light and dark modes. * style |
||
|
GitHub Action
|
c861de8b29 | chore: bump version to 0.0.152 | ||
|
Theo Browne
|
cd579ca791 |
Replace allotment with react-resizable-panels and simplify layout (#2029)
* merge * switch out panel lib * fmt * remove allotment dep * bump lock * The position of the react resizable panel is lost when the page is reloaded in (vibe-kanban 6ac32e23) `WorkspacesLayout.tsx` , but should be stored in `useUiPreferencesStore.ts` `vibe-kanban/frontend/src/components/ui-new/containers/WorkspacesLayout.tsx` `vibe-kanban/frontend/src/stores/useUiPreferencesStore.ts` * remove redundant type * add dep --------- Co-authored-by: Louis Knight-Webb <louis@bloop.ai> |
||
|
Anastasiia Solop
|
5c95368ebf |
Add repository settings option to Git panel dropdown (Vibe Kanban) (#2028)
* All type checks pass. Let me provide a summary of the changes made:
## Summary
I've added a "Repository settings" option to the Git panel dropdown in the Workspaces UI. Here are the changes made:
### 1. `frontend/src/components/ui-new/primitives/RepoCard.tsx`
- Added `DotsThreeIcon` and `GearIcon` imports from phosphor-icons
- Added `onOpenSettings?: () => void` prop to the `RepoCardProps` interface
- Changed the dropdown trigger icon from `ArrowSquareOutIcon` to `DotsThreeIcon` (three dots)
- Added a new dropdown menu item "Repository settings" with a gear icon that calls `onOpenSettings`
### 2. `frontend/src/components/ui-new/views/GitPanel.tsx`
- Added `onOpenSettings?: (repoId: string) => void` prop to the `GitPanelProps` interface
- Added `onOpenSettings` to the destructured props
- Passed `onOpenSettings` callback to each `RepoCard` component
### 3. `frontend/src/components/ui-new/containers/WorkspacesLayout.tsx`
- Added `useNavigate` import from react-router-dom
- Added `const navigate = useNavigate()` in `GitPanelContainer`
- Added `handleOpenSettings` callback that navigates to `/settings/repos?repoId=${repoId}`
- Passed `onOpenSettings={handleOpenSettings}` to the `GitPanel` component
### 4. `frontend/src/i18n/locales/en/common.json`
- Added `"repoSettings": "Repository settings"` translation under the `actions` section
* All checks pass:
- ✅ i18n check - Translation keys are consistent across all locales
- ✅ Linter - No lint errors
- ✅ TypeScript type check - No type errors
|
||
Theo Browne
|
eeee9f6aea |
fix: resolve ESLint tsconfig.json path using absolute path (#2033)
Fix parsing error where ESLint was trying to read tsconfig.json from root directory instead of frontend directory. Use path.join(__dirname, 'tsconfig.json') to ensure correct resolution. |
||
|
Theo Browne
|
2af42a7600 |
Set up React Compiler (#2030)
- Added required deps: `react-compiler-runtime` + `babel-plugin-react-compiler` in `frontend/package.json:70` and `frontend/package.json:99`, plus `remote-frontend/package.json:20` and `remote-frontend/package.json:30` (lockfile updated in `pnpm-lock.yaml`). |
||
|
Anastasiia Solop
|
1fd114b75d |
I've fixed the bug in frontend/src/hooks/useLogStream.ts. Here's a summary of the issue and the fix: (#2027)
## Problem When multiple dev servers are running and the user switches between log tabs, logs from one dev server could appear in another dev server's tab. This happened because: 1. When `processId` changes (user switches tabs), the effect cleanup closes the old WebSocket 2. But WebSocket `close()` is asynchronous - the old WebSocket's event handlers can still fire 3. The old WebSocket's `onmessage` handler was still calling `setLogs()`, which would update the logs state even after switching to a different process ## Solution Added a `currentProcessIdRef` ref to track the current active `processId`, and a `capturedProcessId` variable that captures the processId when each WebSocket is opened. All event handlers now check if their captured processId matches the current one before updating state: 1. **`onopen`**: Closes the WebSocket immediately if processId has changed since opening 2. **`addLogEntry`**: Discards log entries if they're from a stale WebSocket 3. **`onerror`**: Ignores errors from stale WebSocket connections 4. **`onclose`**: Prevents retry logic from running for stale connections This ensures that each WebSocket connection only affects state when it's still the active connection for the currently selected process. |
||
|
GitHub Action
|
d17c41a73d | chore: bump version to 0.0.151 | ||
|
Gabriel Gordon-Hall
|
7bc8ece068 | workspace file search (#2002) | ||
|
Louis Knight-Webb
|
82a4e0fccf |
Workspace onboarding (#2013)
* cleanup navbar * re-enable dev server from command bar * Add the ability to open the command bar from the `NavbarContainer.tsx` : (vibe-kanban 58189151) - dots-three-outline icon - position next to settings `vibe-kanban/frontend/src/components/ui-new/containers/NavbarContainer.tsx` * `NavbarContainer.tsx` button to go back to old UI should navigate back to task rather than attempt (vibe-kanban 2b6f4c76) `index.ts` `vibe-kanban/frontend/src/components/ui-new/containers/NavbarContainer.tsx` `vibe-kanban/frontend/src/components/ui-new/actions/index.ts` * Add new setting: beta\_workspaces, and beta\_workspaces\_invitation\_sent (vibe-kanban e2e73cb9) - Stored in the `mod.rs` - This defaults to 'false' - If a user is considered an active user (they have created more than 50 task attempts), they should be proactively invited to join the beta of workspaces - The invite will be displayed as dialog in the old UI, triggered when the user opens the `TaskAttemptPanel.tsx` - The setting can be changed later in the `GeneralSettings.tsx` , right at the bottom in a section for beta features - When the user has beta\_workspaces set to true: - Previously when they open a task in the `TaskKanbanBoard.tsx` it would open a task attempt or task, now it will always open a task - And when clicking on a task attempt in the `TaskPanel.tsx` it will open in the new workspaces view (/workspaces/[WORKSPACE\_ID]) `vibe-kanban/frontend/src/components/panels/TaskAttemptPanel.tsx` `vibe-kanban/frontend/src/pages/settings/GeneralSettings.tsx` `vibe-kanban/crates/services/src/services/config/mod.rs` `vibe-kanban/frontend/src/components/tasks/TaskKanbanBoard.tsx` `vibe-kanban/frontend/src/components/panels/TaskPanel.tsx` * Introduce a way to give feedback (vibe-kanban 463fbf1d) - Icon in `NavbarContainer.tsx` next to settings - Also triggerable from command bar - Using posthog client, already installed `vibe-kanban/frontend/src/components/ui-new/containers/NavbarContainer.tsx` * Create a new dialog that shows when users use workspaces (ui-new) for the first time. It should (vibe-kanban b0e8344a) explain the features of workspaces. The component will consist of a popup with topics in a sidebar on the left and content (text and images) in a main section to the right. It does not use the existing Dialog component. It is accessible by clicking a help icon in the `NavbarContainer.tsx` and from the command bar via `pages.ts` Create the component and some seed content that I will edit: 1. Welcome to workspaces, here are some tips to get started 2. Use the command bar to navigate 3. Create workspaces in the sidebar, also view all your workspaces and the status of each here 4. Workspaces can be created with multiple repos 5. You can create multiple sessions for each workspace 6. Preview changes 7. View diffs, comment on them 8. If any any point you want to go back to the old UI, you can turn off workspaces in settings `vibe-kanban/frontend/src/components/ui-new/containers/NavbarContainer.tsx` `vibe-kanban/frontend/src/components/ui-new/actions/pages.ts` * Update `WorkspacesGuideDialog.tsx` : (vibe-kanban b4c5d731) - Make 600px height - Add new section: Context Bar > The context bar lets you switch between panes quickly. Drag it wherever works best for you. `vibe-kanban/frontend/src/components/ui-new/dialogs/WorkspacesGuideDialog.tsx`  * The `WorkspacesGuideDialog.tsx` appears every time I reload the page, it doesn't seem that we're (vibe-kanban 7fd9e0c8) saving that the user has already seen it once and it should no longer be auto shown `vibe-kanban/frontend/src/components/ui-new/dialogs/WorkspacesGuideDialog.tsx` * Please run `check-i18n.sh` and fix the issue (vibe-kanban d3323397) `vibe-kanban/scripts/check-i18n.sh` |
||
|
Louis Knight-Webb
|
4bdcc4cafb |
Right hand sidebar icon fix (#2017)
## Summary Fixed the issue where the right sidebar (Git Panel) was using the left sidebar icon. ### Changes made to `frontend/src/components/ui-new/actions/index.ts`: 1. **Added imports** (line 1): `forwardRef` and `createElement` from React 2. **Created `RightSidebarIcon`** (lines 54-63): A wrapper component that renders `SidebarSimpleIcon` with `transform: scaleX(-1)` to mirror it horizontally, making it point to the right 3. **Updated `ToggleGitPanel`** (line 455): Changed from `SidebarSimpleIcon` to `RightSidebarIcon` The fix uses CSS transform to flip the icon horizontally, maintaining visual consistency with the existing icon while correctly indicating that it controls the right sidebar. |
||
|
Gabriel Gordon-Hall
|
cdfb081cf8 |
feat: copy-file autocomplete (#2004)
* add repo file search endpoint and use for copy-file autocomplete * address feedback and fix i18n errors * remove unused i18n |
||
|
Louis Knight-Webb
|
33419c95f7 |
Improve the preview functionality (vibe-kanban) (#2010)
* preview styles
* All tasks are complete. Let me provide a summary of the changes made:
## Summary
I've implemented the preview functionality improvements as requested:
### Changes Made
**1. Rust Types (`crates/db/src/models/scratch.rs`)**
- Renamed `PreviewUrlOverrideData` → `PreviewSettingsData`
- Added new fields: `screen_size`, `responsive_width`, `responsive_height`
- Updated `ScratchPayload` and `ScratchType` enum to use `PreviewSettings`
**2. New Hook (`frontend/src/hooks/usePreviewSettings.ts`)**
- Created new `usePreviewSettings` hook (replaced `usePreviewUrlOverride`)
- Manages both URL override and screen size settings
- Persists screen size via the scratch system (per-workspace)
- Exports `ScreenSize` and `ResponsiveDimensions` types
**3. PreviewBrowserContainer (`frontend/src/components/ui-new/containers/PreviewBrowserContainer.tsx`)**
- Added URL controls (input, copy, open in new tab, refresh, clear override)
- Added stop button and related handlers
- Added screen size state management
- Added responsive dimensions resize handlers
**4. PreviewBrowser View (`frontend/src/components/ui-new/views/PreviewBrowser.tsx`)**
- Added floating toolbar above the iframe with:
- URL input with action buttons
- Screen size toggle (Desktop/Mobile/Responsive icons)
- Dimensions display for responsive mode
- Stop button
- Implemented three screen modes:
- **Desktop**: Full width/height (current behavior)
- **Mobile**: 390×844px centered with shadow
- **Responsive**: Draggable resize handles on right, bottom, and corner edges
**5. PreviewControls View (`frontend/src/components/ui-new/views/PreviewControls.tsx`)**
- Simplified to show only logs
- Removed URL input row and all control buttons
- Renamed section header to "Dev Server Logs"
**6. PreviewControlsContainer (`frontend/src/components/ui-new/containers/PreviewControlsContainer.tsx`)**
- Removed all URL-related state and handlers
- Now only manages logs display and process tab switching
All type checks pass. The screen size preference is persisted per-workspace using the existing scratch system.
* Cleanup script changes for workspace dd65dbe3-2e31-4897-8aa4-b2f8f7971ab7
* All ESLint and TypeScript checks pass. The implementation is complete.
## Summary of Changes
**Files Modified:**
1. **`crates/db/src/models/scratch.rs`** - Renamed `PreviewUrlOverrideData` → `PreviewSettingsData` with new fields for screen size persistence
2. **`crates/server/src/bin/generate_types.rs`** - Updated type export to use new name
3. **`shared/types.ts`** - Regenerated with new types (`PreviewSettingsData`, `ScratchType.PREVIEW_SETTINGS`)
4. **`frontend/src/hooks/usePreviewSettings.ts`** (new) - Replaces `usePreviewUrlOverride.ts`, adds screen size management
5. **`frontend/src/hooks/usePreviewUrlOverride.ts`** - Deleted
6. **`frontend/src/components/ui-new/containers/PreviewBrowserContainer.tsx`** - Added URL controls, stop button, and resize state management
7. **`frontend/src/components/ui-new/views/PreviewBrowser.tsx`** - Added floating toolbar with:
- URL input with copy/open/refresh/clear buttons
- Screen size toggle (Desktop/Mobile/Responsive icons)
- Responsive resize handles
- Stop button
8. **`frontend/src/components/ui-new/containers/PreviewControlsContainer.tsx`** - Simplified to logs only
9. **`frontend/src/components/ui-new/views/PreviewControls.tsx`** - Simplified to logs only
* Cleanup script changes for workspace dd65dbe3-2e31-4897-8aa4-b2f8f7971ab7
* All checks pass. Here's a summary of the changes made:
## Summary of Changes
### 1. Fixed infinite loop bug (`usePreviewSettings.ts`)
- Added `useMemo` to stabilize the `responsiveDimensions` object reference
- This prevents the useEffect in the container from re-triggering on every render
### 2. Updated toolbar to always show with floating style (`PreviewBrowser.tsx`)
- Toolbar is now always visible (not conditional on `isServerRunning && hasUrl`)
- Changed styling from `border-b border-border` to `rounded-md shadow-md m-base` for a floating appearance
- URL input and action buttons are disabled (with `opacity-50 cursor-not-allowed`) when no URL is available
- Start/Stop button in toolbar changes based on server state:
- Shows "Start" button when server is not running
- Shows "Stop" button when server is running
- Simplified the empty state content area to just show a message pointing to the toolbar's Start button
* All checks pass. The fix:
1. **Changed from state to refs** for `isResizing` and `resizeDirection` - these now don't trigger re-renders when they change
2. **Added `localDimensionsRef`** to capture the current dimensions for the `handleEnd` callback without adding it to the effect's dependency array
3. **Effect now only depends on `setResponsiveDimensions`** (a stable callback), so event listeners are registered once on mount and cleaned up on unmount
4. **No more race conditions** - the same event handlers persist throughout the entire drag operation
The resize should now:
- Stop immediately when you release the mouse
- Be smooth without choppiness (no effect re-runs during drag)
* The responsive resize fix is complete. Here's a summary of the changes made:
**In `PreviewBrowserContainer.tsx`:**
1. Added `isResizing` state to track when resizing is active (for UI purposes)
2. Added `setResponsiveDimensionsRef` to store the callback in a ref, preventing the resize effect from re-running when the callback identity changes
3. Changed the resize effect to use an empty dependency array (`[]`) since all external values are now accessed via refs
4. Updated `handleResizeStart` to set `isResizing(true)`
5. Updated `handleEnd` to set `isResizing(false)` and use `setResponsiveDimensionsRef.current`
6. Passed `isResizing` prop to the `PreviewBrowser` view
**In `PreviewBrowser.tsx`:**
1. Added `isResizing` prop to the interface and destructured it
2. Applied `pointer-events-none` class to the iframe when `isResizing` is true - this prevents the iframe from capturing mouse events during resize, ensuring smooth dragging
These changes fix both issues:
- **Resize not stopping**: The effect no longer re-registers listeners when `setResponsiveDimensions` changes
- **Choppy dragging**: The iframe no longer captures mouse events during resize
* All checks pass. The fix is complete. The resize now uses delta-based calculation:
1. **`startPosRef`**: Captures the mouse position when resize starts
2. **`startDimensionsRef`**: Captures the iframe dimensions when resize starts
3. **`handleMove`**: Calculates delta (current position - start position) and applies it to the starting dimensions
4. **`handleEnd`**: Clears both refs when resize ends
This approach works regardless of where the iframe is positioned in the container, fixing both:
- The mouse jump offset (no longer tries to position based on container edge)
- The 50% distance issue (delta is 1:1 with mouse movement)
* Cleanup script changes for workspace dd65dbe3-2e31-4897-8aa4-b2f8f7971ab7
* Done. The resize should now move at 1:1 with the cursor. Since the centered element grows on both sides equally, doubling the delta ensures the edge under the cursor moves the full distance you drag.
* Done! I've added a minimal dark phone frame around the iframe when in mobile mode. The changes:
- **Mobile mode** now wraps the iframe in a phone skeleton with:
- Dark bezel (`bg-gray-900`)
- Rounded outer corners (`rounded-[3rem]`)
- Padding for bezel width (`p-3`)
- Shadow (`shadow-xl`)
- Rounded inner screen area (`rounded-[2.5rem]`)
- **Desktop and responsive modes** remain unchanged
You can test it by running `pnpm run dev:qa` and switching to mobile view in the preview browser.
* styles
* I've completed the implementation. Here's a summary of the changes:
## Summary
Created two new reusable button components and updated PreviewBrowser.tsx to standardize button styles:
### New Components
1. **`IconButton.tsx`** (`frontend/src/components/ui-new/primitives/IconButton.tsx`)
- Standalone icon button with consistent styling
- Supports `default` and `tertiary` variants
- Includes proper hover states (`bg-secondary/50`), disabled states, and transitions
2. **`IconButtonGroup.tsx`** (`frontend/src/components/ui-new/primitives/IconButtonGroup.tsx`)
- Container component for grouped icon buttons with shared border
- `IconButtonGroupItem` for individual buttons with `active` state support
- Consistent styling with border, padding, and hover/active states
### Updated PreviewBrowser.tsx
- **URL action buttons** (Clear, Copy, Open in new tab, Refresh): Now use `IconButton` component with consistent hover backgrounds
- **Screen size toggle** (Desktop, Mobile, Responsive): Now uses `IconButtonGroup` and `IconButtonGroupItem` with proper active state styling
- **Start/Stop button**: Kept using `PrimaryButton` (already consistent)
### Visual Consistency Achieved
All toolbar buttons now share:
- Consistent padding (`p-half`)
- Consistent hover states (`bg-secondary/50` background)
- Consistent active states (`bg-secondary` background) for toggles
- Consistent disabled states (`opacity-40 cursor-not-allowed`)
- Consistent icon sizing (`size-icon-sm`) with `weight="bold"`
- Consistent border radius (`rounded-sm`)
* Done. The URL action buttons (Copy, Open in new tab, Refresh) are now grouped in an `IconButtonGroup` with a shared border, matching the visual style of the screen size toggle group.
The toolbar now has three visually consistent button groups:
1. **URL input** with optional clear override button
2. **URL actions group** (Copy, Open in new tab, Refresh) - bordered group
3. **Screen size toggle group** (Desktop, Mobile, Responsive) - bordered group
4. **Start/Stop button** (PrimaryButton)
* Done. All changes have been implemented:
1. **Added `iconClassName` prop to `IconButtonGroupItem`** - Supports passing custom classes to the icon (e.g., `animate-spin` for the spinner)
2. **Moved Clear button into URL Actions group** - The Clear Override button (X icon) is now inside the `IconButtonGroup` with Copy, Open, and Refresh buttons
3. **Replaced Pause button with `IconButtonGroupItem`** - The stop/pause button now uses the same `IconButtonGroup` styling as the other toolbar buttons, with spinner animation support when stopping
The toolbar now has consistent visual styling with three button groups:
- **URL Actions**: Clear (conditional), Copy, Open in new tab, Refresh
- **Screen Size Toggle**: Desktop, Mobile, Responsive
- **Stop button**: Pause icon (when server is running)
- **Start button**: Kept as `PrimaryButton` since it has a text label
* Cleanup script changes for workspace dd65dbe3-2e31-4897-8aa4-b2f8f7971ab7
* Done. The Start/Stop button is now a single `IconButtonGroup` with one `IconButtonGroupItem` that:
- Shows Play icon when server is stopped, Pause icon when running
- Shows Spinner icon with animation when starting or stopping
- Has the same size as all other toolbar button groups
* Cleanup script changes for workspace dd65dbe3-2e31-4897-8aa4-b2f8f7971ab7
* Done. Fixed the spinning Play icon bug by making the `iconClassName` logic match the icon selection logic exactly. Now `animate-spin` is only applied when actually showing the `SpinnerIcon`.
* Done. The entire toolbar (URL input, URL actions, screen size toggle) is now disabled when the dev server isn't running. Only the Play/Start button remains enabled so users can start the server.
* The changes compile correctly. Here's a summary of what was fixed:
## Summary
Fixed the "Fix Script" button showing at the wrong time in `PreviewBrowser.tsx`.
**Changes made:**
1. **`PreviewBrowser.tsx`** - Added `hasFailedDevServer?: boolean` prop and updated the condition on line 345 from `{handleFixDevScript && (` to `{hasFailedDevServer && handleFixDevScript && (`
2. **`PreviewBrowserContainer.tsx`** - Added failed dev server detection logic (lines 45-51) that checks for processes with `status === 'failed'` or `status === 'completed'` with non-zero exit code, and passed the `hasFailedDevServer` prop to the view
The "Fix Script" button will now only appear when the last dev server process actually failed, not when it was successful or killed.
* update styles
* All tasks completed. Here's a summary of the changes made:
## Summary
### 1. `IconButtonGroup.tsx` (lines 3, 50-65)
- Added import for `Tooltip` component
- Modified `IconButtonGroupItem` to wrap buttons with `<Tooltip>` when `title` prop is provided
- Removed native `title` attribute from button (tooltip handles it now)
### 2. `en/tasks.json` (lines 125-134)
Added new i18n keys under `preview.toolbar`:
- `clearUrlOverride`: "Clear URL override"
- `desktopView`: "Desktop view"
- `mobileView`: "Mobile view (390x844)"
- `responsiveView`: "Responsive view (resizable)"
- `startDevServer`: "Start dev server"
Added new `preview.loading` section:
- `startingServer`: "Starting dev server..."
- `waitingForServer`: "Waiting for server..."
### 3. `PreviewBrowser.tsx` (lines 160-254, 342-344)
Replaced all hardcoded strings with i18n translations using `t()`:
- URL action buttons (clear override, copy, open in tab, refresh)
- Screen size toggle buttons (desktop, mobile, responsive)
- Start/stop server button
- Loading state messages
All icon buttons now have proper accessible tooltips via the `Tooltip` component instead of native browser `title` attributes, and all strings are internationalized.
* style
* All i18n issues have been fixed. Here's a summary of the changes made:
**1. Added missing translation keys to all non-English locales (es, ja, ko, zh-Hans, zh-Hant):**
- `preview.loading.startingServer`
- `preview.loading.waitingForServer`
- `preview.toolbar.clearUrlOverride`
- `preview.toolbar.desktopView`
- `preview.toolbar.mobileView`
- `preview.toolbar.responsiveView`
- `preview.toolbar.startDevServer`
**2. Fixed hardcoded strings in `PreviewBrowser.tsx`:**
- Replaced dimension separator `x` with HTML entity `×`
- Internationalized the "no dev script" setup message with 3 new i18n keys:
- `preview.noServer.setupTitle`
- `preview.noServer.editDevScript`
- `preview.noServer.learnMore`
**3. Added the 3 new keys to all locale files (en, es, ja, ko, zh-Hans, zh-Hant)**
The `check-i18n.sh` script now passes with:
- 128 violations (down from 131 on main - a net improvement!)
- No duplicate keys
- Translation keys consistent across all locales
|
||
|
Anastasiia Solop
|
a3cdca742a |
Add conflict detection and resolution dialog to rebase/merge flow (Vibe Kanban) (#2001)
* I've implemented the changes to the rebase/merge flow in the new workspaces UI. Here's a summary of what was done:
## Summary of Changes
### 1. Created `ResolveConflictsDialog` component
**File:** `frontend/src/components/ui-new/dialogs/ResolveConflictsDialog.tsx`
A new dialog that:
- Shows when conflicts are detected before rebase/merge operations
- Displays the list of conflicted files (up to 5, with a count for additional)
- Asks the user whether to resolve conflicts in:
- **Current session** (default when a session exists)
- **New session** (toggle switch, similar to StartReviewDialog)
- When creating a new session, allows selecting agent/profile
- Sends the conflict resolution instructions to the agent automatically
### 2. Updated `GitRebase` action
**File:** `frontend/src/components/ui-new/actions/index.ts`
- Now checks for existing conflicts before opening the RebaseDialog
- If conflicts exist (`is_rebase_in_progress` or `conflicted_files.length > 0`), shows the ResolveConflictsDialog instead
- If no conflicts, proceeds with normal rebase flow
### 3. Updated `GitMerge` action
**File:** `frontend/src/components/ui-new/actions/index.ts`
- Same conflict detection logic as GitRebase
- If conflicts exist, shows the ResolveConflictsDialog
- If no conflicts, proceeds with normal merge confirmation flow
### 4. Added translations
**File:** `frontend/src/i18n/locales/en/tasks.json`
Added new translation keys under `resolveConflicts.dialog`:
- `title`: "Resolve Conflicts"
- `description`: "Conflicts were detected. Choose how you want the agent to resolve them."
- `sessionLabel`: "Session"
- `existingSession`: "Continue in current session"
- `newSession`: "New Session"
- `resolve`: "Resolve Conflicts"
- `resolving`: "Starting..."
### How it works
1. When a user clicks **Rebase** or **Merge** in the RepoCard dropdown
2. The system fetches the branch status to check for conflicts
3. If conflicts exist:
- The `ResolveConflictsDialog` opens
- User can choose to resolve in current session or new session
- Clicking "Resolve Conflicts" sends pre-built conflict resolution instructions to the agent
4. If no conflicts:
- Normal flow continues (RebaseDialog for rebase, ConfirmDialog for merge)
* The type check passes. Now the flow will be:
1. User clicks Rebase → RebaseDialog opens
2. User selects branch and clicks Rebase
3. If conflicts occur during rebase:
- The error is caught with type `merge_conflicts` or `rebase_in_progress`
- RebaseDialog closes
- ResolveConflictsDialog opens with conflict details
4. If no conflicts → Rebase succeeds and dialog closes
This handles the first-time rebase scenario where conflicts are detected *after* the rebase attempt, not before.
* Cleanup script changes for workspace f54c4bcf-8b64-4260-8cae-c8d0bda2a350
* The type check passes. The key changes I made:
1. **Await query invalidation**: Changed from fire-and-forget `invalidateQueries` to awaiting them with `Promise.all()`. This ensures the sessions list is refreshed before we try to select the new session.
2. **Select session after queries refresh**: Moved the `selectSession` call to after the queries have been invalidated and refetched, so the new session exists in the list.
3. **Simplified the boolean logic**: Used a single `creatingNewSession` variable instead of computing the condition twice.
This should fix the issue where the previous session "disappears" - it was likely being overwritten by the auto-select behavior in `useWorkspaceSessions` that fires when sessions change. Now we wait for that to settle before selecting the new session.
* The type check passes. Here's a summary of the updated flow:
## Updated Flow
### Merge Action:
1. **Check for existing conflicts** → If conflicts exist, show ResolveConflictsDialog
2. **Check if branch is behind** → If `commits_behind > 0`, show "Rebase Required" dialog that offers to open RebaseDialog
3. **Otherwise** → Show normal merge confirmation dialog
### Rebase Action:
1. **Check for existing conflicts** → If conflicts exist, show ResolveConflictsDialog
2. **Otherwise** → Show RebaseDialog
3. **If rebase fails with conflicts** → RebaseDialog catches the error and shows ResolveConflictsDialog
This way:
- Clicking Merge when behind will prompt to rebase first (avoiding the "Branches diverged" error)
- Clicking Rebase when conflicts already exist will show the resolve dialog immediately
- If rebase creates new conflicts, the RebaseDialog will catch it and show the resolve dialog
* Both the type check and i18n lint pass now. The i18n issues in the ResolveConflictsDialog have been fixed by:
1. Added new translation keys in `tasks.json`:
- `filesWithConflicts_one`: "{{count}} file has conflicts"
- `filesWithConflicts_other`: "{{count}} files have conflicts"
- `andMore`: "...and {{count}} more"
2. Updated `ResolveConflictsDialog.tsx` to use `t()` function with these keys instead of hardcoded strings.
* All checks pass. The i18n translations have been added to all 5 locale files (es, ja, ko, zh-Hans, zh-Hant) for the `resolveConflicts.dialog.*` keys:
- `title` - Resolve Conflicts
- `description` - Conflicts were detected...
- `sessionLabel` - Session
- `existingSession` - Continue in current session
- `newSession` - Start a new session
- `resolve` - Resolve Conflicts
- `resolving` - Starting...
- `filesWithConflicts_one` - {{count}} file has conflicts
- `filesWithConflicts_other` - {{count}} files have conflicts
- `andMore` - ...and {{count}} more
All checks now pass:
- `./scripts/check-i18n.sh` ✅ - No missing translation keys
- `pnpm run lint` ✅ - Both frontend and backend linting pass
- `pnpm run check` ✅ - TypeScript and Rust type checks pass
|
||
|
Gabriel Gordon-Hall
|
57e802e2c9 | per-repo diff stats (#1961) | ||
|
Anastasiia Solop
|
118650872b | fix styling of diffs in conversation (#1998) | ||
|
Louis Knight-Webb
|
4a0fad03c2 |
Display GitHub PR comments inline in diff view (Vibe Kanban) (#1991)
* The GitHub comments integration is now complete. Here's a summary of what was implemented:
## Summary
The GitHub PR comments integration for the new UI (ui-new) is now complete. All tasks have been implemented:
### Files Modified:
1. **`useUiPreferencesStore.ts`** - Added persistence key for `showGitHubComments` toggle
2. **`WorkspaceContext.tsx`** - Extended with PR comments data, helpers (`getGitHubCommentsForFile`, `gitHubFileCommentCounts`), and toggle state
3. **`CommentCard.tsx`** (new) - Shared primitive for displaying comments with three variants: `user`, `github`, `input`
4. **`GitHubCommentRenderer.tsx`** (new) - Read-only renderer for GitHub comments with GitHub logo, author, timestamp, and external link
5. **`ReviewCommentRenderer.tsx`** - Refactored to use `CommentCard` primitive
6. **`CommentWidgetLine.tsx`** - Refactored to use `CommentCard` primitive
7. **`DiffViewCardWithComments.tsx`** - Integrated GitHub comments into diff view, showing both user and GitHub comments with separate counts in the header
8. **`FileTreeNode.tsx`** - Added GitHub comment badge showing count next to files
9. **`FileTree.tsx`** - Added toggle button in header to show/hide GitHub comments
10. **`FileTreeContainer.tsx`** - Wired up the context to pass toggle state and comment counts to FileTree
11. **`common.json`** (i18n) - Added translation keys for show/hide GitHub comments
### Features:
- GitHub PR comments displayed inline next to relevant code in diff views
- Toggle button in file tree to show/hide GitHub comments (persisted)
- Comment count badges on files in the file tree
- Visual differentiation: user comments have orange styling (`bg-brand/20 border-brand`), GitHub comments have neutral styling (`bg-secondary border-border`)
- User comments take priority when both exist on the same line
* Cleanup script changes for workspace 881e2956-9cca-406d-835f-7ea8acbe550e
* All checks pass. Let me show a summary of the changes made:
## Summary of Fixes
All code review feedback has been addressed:
| # | Fix | File | Change |
|---|-----|------|--------|
| 1 | Date parsing | `GitHubCommentRenderer.tsx:9-27` | Replaced `try/catch` with `isNaN(date.getTime())` check |
| 2 | Comment priority | `DiffViewCardWithComments.tsx:258-260` | Added comment explaining user comments take priority |
| 3 | SplitSide.new | `WorkspaceContext.tsx:163-165` | Added comment explaining why `SplitSide.new` is correct |
| 4 | Multi-repo TODO | `WorkspaceContext.tsx:133-134` | Added TODO about supporting multiple repos |
| 5 | Loading state | `FileTreeContainer.tsx`, `FileTree.tsx` | Passed `isGitHubCommentsLoading` prop and added `opacity-50 animate-pulse` to button |
Type checks pass. Ready for commit.
* Fixed! The `FileTree.tsx` now uses the correct `Tooltip` component from `@/components/ui-new/primitives/Tooltip` instead of the old `@/components/ui/tooltip`.
Changes made:
- Updated import to use `import { Tooltip } from '../primitives/Tooltip'`
- Simplified the tooltip usage from the compound component pattern (`Tooltip` + `TooltipTrigger` + `TooltipContent`) to the simpler API (`<Tooltip content="...">...</Tooltip>`)
* The path matching bug has been fixed. Here's a summary of the changes:
## Summary of Bug Fix
**Problem**: GitHub comments weren't displaying because paths didn't match.
- GitHub API returns paths like: `frontend/src/components/ui-new/actions/index.ts`
- Diff paths are prefixed with repo name: `vibe-kanban/frontend/src/components/ui-new/actions/index.ts`
**Solution**: Use `endsWith` matching instead of exact string equality.
### Files Changed:
1. **`WorkspaceContext.tsx`**:
- Added `pathMatches` helper function that checks if paths match using `endsWith`
- Updated `getGitHubCommentsForFile` to use `pathMatches`
- Replaced `gitHubFileCommentCounts: Record<string, number>` with `getGitHubCommentCountForFile: (filePath: string) => number` function that also uses `pathMatches`
2. **`FileTree.tsx`**:
- Changed prop from `fileCommentCounts?: Record<string, number>` to `getGitHubCommentCountForFile?: (filePath: string) => number`
- Updated usage from `fileCommentCounts?.[node.path]` to `getGitHubCommentCountForFile?.(node.path)`
3. **`FileTreeContainer.tsx`**:
- Updated to pass the new `getGitHubCommentCountForFile` function instead of `gitHubFileCommentCounts` Record
* Cleanup script changes for workspace 881e2956-9cca-406d-835f-7ea8acbe550e
* Fixed! The `renderExtendLine` function now includes a null check for `lineData.data` to prevent the TypeError when switching diff modes. The fix adds:
```typescript
// Guard against undefined data (can happen when switching diff modes)
if (!lineData.data) return null;
```
This prevents the crash when the `@git-diff-view` library passes undefined data during mode transitions.
* Done! GitHub comments will now be shown by default. The change was a simple one-liner in `WorkspaceContext.tsx`:
```typescript
// Before:
false // Default to hidden
// After:
true // Default to shown
```
* The proper fix is complete. Here's a summary of the changes:
## Summary: Comments on deleted lines fix
**Problem**: GitHub comments on deleted lines weren't showing because we were placing all comments on `SplitSide.new`.
**Solution**: Pass through the `side` field from GitHub's API which indicates whether the comment is on the "LEFT" (old/deleted) or "RIGHT" (new/added) side.
### Files Changed:
1. **`crates/services/src/services/git_host/types.rs`**
- Added `side: Option<String>` field to `UnifiedPrComment::Review` variant
2. **`crates/services/src/services/git_host/github/mod.rs`**
- Pass `c.side` through when creating `UnifiedPrComment::Review`
3. **`crates/services/src/services/git_host/azure/cli.rs`**
- Added `side: None` to Azure DevOps (doesn't have this info)
4. **`shared/types.ts`** (regenerated)
- Now includes `side: string | null` in the review comment type
5. **`frontend/src/contexts/WorkspaceContext.tsx`**
- Updated normalization to use `comment.side === 'LEFT' ? SplitSide.old : SplitSide.new`
6. **`frontend/src/components/ui-new/containers/DiffViewCardWithComments.tsx`**
- Updated `extendData` building to place GitHub comments on the correct side (`oldFileData` or `newFileData`) based on `comment.side`
* The refactoring is complete. Here's a summary of the changes:
**Created new file:** `frontend/src/hooks/useGitHubComments.ts`
- Contains the `NormalizedGitHubComment` interface
- Contains all GitHub comments logic: fetching, toggle state, normalization, path matching helpers
**Updated:** `frontend/src/contexts/WorkspaceContext.tsx`
- Removed ~70 lines of GitHub comments logic
- Now imports and uses `useGitHubComments` hook
- Re-exports `NormalizedGitHubComment` type for consumers that import it from the context
The context file is now smaller and more focused on workspace management, while the GitHub comments functionality is encapsulated in its own dedicated hook.
* Cleanup script changes for workspace 881e2956-9cca-406d-835f-7ea8acbe550e
* Done. Removed the duplicate `formatRelativeTime` function from `GitHubCommentRenderer.tsx` and replaced it with an import from the existing `@/utils/date` utility.
* The i18n check now passes. All translation keys are consistent across locales. I added the missing `showGitHubComments` and `hideGitHubComments` translations to:
- Spanish (es)
- Japanese (ja)
- Korean (ko)
- Simplified Chinese (zh-Hans)
- Traditional Chinese (zh-Hant)
|
||
|
Louis Knight-Webb
|
bd034da2db |
Navigate away when deleting the currently selected workspace (Vibe Kanban) (#1984)
* Done! I've implemented the feature. Here's a summary of the changes to `vibe-kanban/frontend/src/components/ui-new/actions/index.ts`: 1. **Added `getNextWorkspaceId` helper function** (lines 184-196) - A reusable function that finds the next workspace to navigate to when removing a workspace from the active list 2. **Refactored `ArchiveWorkspace`** - Now uses the helper function instead of inline logic 3. **Updated `DeleteWorkspace`** - Added navigation logic that: - Only triggers when deleting the currently viewed workspace - Navigates to the next workspace in the list (or previous if at end) - Falls back to `/workspaces/create` if no other workspaces exist * Cleanup script changes for workspace a60eb506-5db1-4ba7-8ee6-26592885587b |
||
|
Louis Knight-Webb
|
c7cf72a57f |
Allow manual URL override in dev server preview (Vibe Kanban) (#1989)
* The implementation is complete and tested. Here's a summary of the changes made: I've implemented an editable URL bar in the Preview Controls that allows users to override the auto-detected dev server URL on a per-workspace basis. | File | Changes | |------|---------| | `crates/db/src/models/scratch.rs` | Added `PreviewUrlOverrideData` struct and `PreviewUrlOverride` variant to `ScratchPayload` enum | | `crates/server/src/bin/generate_types.rs` | Registered `PreviewUrlOverrideData::decl()` for TypeScript type generation | | `shared/types.ts` | Auto-generated with new `PreviewUrlOverrideData` type and updated `ScratchPayload` union | | `frontend/src/hooks/usePreviewUrlOverride.ts` | **New file** - Custom hook for managing URL override persistence via scratch system | | `frontend/src/components/ui-new/containers/PreviewControlsContainer.tsx` | Added URL override hook integration, merged auto-detected with override URL | | `frontend/src/components/ui-new/views/PreviewControls.tsx` | Replaced static `<span>` with editable `<input>`, added clear override button (X icon) | - **Editable URL bar**: Users can type a custom URL to override the auto-detected one - **Per-workspace persistence**: Override URL saved in the scratch system using workspace ID - **Debounced saves**: Changes are debounced (300ms) before saving to avoid excessive API calls - **Clear override button**: X button appears when override is active, allowing revert to auto-detected URL - **Visual distinction**: Override URLs show in normal text color, auto-detected in dim text * Cleanup script changes for workspace 3f3c315d-5cc2-43b0-9043-117c857f38b4 * The URL input fix is complete. Here's a summary of what was implemented: **Feature: Editable URL bar with per-workspace persistence** 1. **New scratch type** - Added `PreviewUrlOverride` to the Rust scratch system for persisting URL overrides per workspace 2. **New hook** - Created `usePreviewUrlOverride.ts` that wraps the scratch system with debounced saves (300ms delay) 3. **Container integration** - Updated `PreviewControlsContainer.tsx` to use the override URL when set, falling back to auto-detected URL 4. **View updates** - Updated `PreviewControls.tsx` with: - Editable input field instead of read-only display - Clear button (X icon) to revert to auto-detected URL - Local state management to prevent WebSocket updates from disrupting typing **Bug fix for typing issue:** - Added local state (`localValue`) and ref (`inputRef`) to track input value locally - The effect only syncs from server when input is not focused, preventing cursor jumping and character loss during typing * ESLint and Clippy both pass now. The fix moved the state management from the presentational view component (`PreviewControls.tsx`) to the container component (`PreviewControlsContainer.tsx`), which aligns with the codebase's architecture pattern of keeping views stateless. * I can see projects now. Let me click on the first project to access a workspace where I can test the URL override feature: * TypeScript check passes now. The fix was changing `RefObject<HTMLInputElement | null>` to `RefObject<HTMLInputElement>` in the props interface - the `null` is already implied in how React refs work. |
||
|
Louis Knight-Webb
|
d9fa2d1fa5 |
Always show a panel (#1988)
## Summary
**Fixed:** Invalid layout state where only left and right sidebars are visible (no main content area).
### Changes Made:
**1. `frontend/src/stores/useLayoutStore.ts`**
- Added `setMainPanelVisible` setter function to the type and implementation
- Added `useIsRightMainPanelVisible` derived selector hook that checks if Changes/Logs/Preview panel is visible
**2. `frontend/src/components/ui-new/containers/WorkspacesLayout.tsx`**
- Imported `useIsRightMainPanelVisible` from the layout store
- Added `setMainPanelVisible` to the destructured store values
- Replaced verbose `isChangesMode || isLogsMode || isPreviewMode` checks with the helper
- Added guard effect that ensures the left main panel (chat) is visible when the right main panel is hidden - this prevents the invalid state after page reload
The guard effect automatically opens the main panel whenever the layout would otherwise show only sidebars:
```typescript
// Ensure left main panel (chat) is visible when right main panel is hidden
// This prevents invalid state where only sidebars are visible after page reload
useEffect(() => {
if (!isMainPanelVisible && !isRightMainPanelVisible) {
setMainPanelVisible(true);
}
}, [isMainPanelVisible, isRightMainPanelVisible, setMainPanelVisible]);
```
|
||
|
Louis Knight-Webb
|
aad1bd092b | WYSIWYG editor will retain focus when the user clicks the '+' button in the sidebar. (#1987) | ||
|
Louis Knight-Webb
|
25c8ab29a9 |
Fix workspace actions in summary (#1986)
## Summary Fixed the "workspace not found" error when performing actions on non-selected workspaces. **Root cause**: The `getWorkspaceFromCache()` function only checked the React Query cache, but only the currently selected workspace had its full data cached. **Solution**: Modified the helper function to fetch from the API when data isn't in cache. **File modified**: `frontend/src/components/ui-new/actions/index.ts` **Changes**: 1. Renamed `getWorkspaceFromCache` → `getWorkspace` and made it async 2. Added fallback to `attemptsApi.get(workspaceId)` when cache miss occurs 3. Updated all 6 call sites to use `await getWorkspace()`: - `RenameWorkspace` (line 215) - `PinWorkspace` (line 229) - `ArchiveWorkspace` (line 246) - `DeleteWorkspace` (line 281) - `OpenInOldUI` (line 489) - `GitCreatePR` (line 630) |
||
|
Louis Knight-Webb
|
b87fb13e87 |
Dev server starting state (#1985)
**Changes:** 1. Added `useState` and `useEffect` to imports 2. Added `pendingStart` state to track when mutation has started but no running process exists yet 3. Added `useEffect` that clears `pendingStart` when `runningDevServers.length > 0` 4. Added `onMutate` callback to set `pendingStart = true` when mutation starts 5. Updated `onError` to clear `pendingStart` on failure 6. Updated `isStarting` return value to `startMutation.isPending || pendingStart` **How it works:** - When the user clicks "Start", `onMutate` fires immediately and sets `pendingStart = true` - This makes `isStarting = true`, showing the "starting" state in the UI - The `pendingStart` state persists even after the API request completes - Only when a running dev server process appears in the data (via the `useEffect`), `pendingStart` is cleared - If the mutation fails, `onError` clears `pendingStart` immediately This ensures the "starting" state is visible until the dev server process actually appears, rather than just during the brief API request time. |