Add a 'Customise' menu item to the variants dropdown in the chat box
that navigates users to the Agent Settings page (/settings/agents)
where they can configure executor variants.
- Add onCustomise callback to VariantProps interface in ChatBoxBase
- Render separator and Customise option with gear icon in dropdown
- Add navigation handler in SessionChatBoxContainer and CreateChatBoxContainer
- Add i18n translations for all supported locales
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
* Done. The ESLint rule is now in place, banning optional props in all ui-new components.
**Summary:**
- Added the rule to `frontend/.eslintrc.cjs` targeting `TSPropertySignature[optional=true]`
- The rule applies to all files under `src/components/ui-new/**/*.{ts,tsx}`
**Impact Assessment - 100 violations across:**
| Category | Files | Violations |
|----------|-------|------------|
| **primitives/** | 11 files | ~40 violations |
| **views/** | 5 files | ~15 violations |
| **containers/** | 5 files | ~10 violations |
| **dialogs/** | 7 files | ~15 violations |
| **Root-level** | 5 files | ~15 violations |
| **types/** | 1 file | 5 violations |
The most affected files are:
- `primitives/Dropdown.tsx` (14 violations)
- `primitives/RepoCard.tsx` (12 violations)
- `NewDisplayConversationEntry.tsx` (11 violations)
- `primitives/CommandBar.tsx` (5 violations)
Would you like me to start refactoring these components to comply with the new rule?
* Done. The rule now only applies to `containers/`.
**Summary:**
- Removed the optional props ban from the general `ui-new/**` override
- Added a new override specifically for `src/components/ui-new/containers/**/*.{ts,tsx}`
**Impact reduced from 100 to 48 violations**, all now in container components:
| File | Violations |
|------|------------|
| SessionChatBoxContainer.tsx | 11 |
| DiffViewCardWithComments.tsx | 9 |
| SearchableDropdownContainer.tsx | 6 |
| FileTreeContainer.tsx | 3 |
| PreviewControlsContainer.tsx | 3 |
| ChangesPanelContainer.tsx | 2 |
| LogsContentContainer.tsx | 2 |
| PreviewBrowserContainer.tsx | 2 |
| WorkspacesLayout.tsx | 2 |
| WorkspacesMainContainer.tsx | 2 |
| + 6 more files | 6 |
* All ESLint issues in `SessionChatBoxContainer.tsx` have been fixed. Here's a summary of the changes:
1. **Removed dead code**:
- Removed `taskId` prop (never passed by call site)
- Removed `workspaceId` aliasing and fallback (`propWorkspaceId ?? session?.workspace_id`)
2. **Updated interface** - Changed all optional props (`?`) to explicit types:
- Props that can be undefined use `Type | undefined` instead of `Type?`
- Props with defaults (`sessions`, `isNewSessionMode`) are now required in the interface
3. **Added explicit defaults** in destructuring for all props:
- `session = undefined`, `onSelectSession = undefined`, `projectId = undefined`, `onStartNewSession = undefined`, `workspaceId = undefined`
- `filesChanged = 0`, `linesAdded = 0`, `linesRemoved = 0`
- `sessions = []`, `isNewSessionMode = false`
* Done. I've refactored `SessionChatBoxContainer.tsx` to use a discriminated union for props. Here's a summary:
**Changes made:**
1. **Defined discriminated union type** with three modes:
- `existing-session`: Has a `session` (required), `onSelectSession`, `onStartNewSession`
- `new-session`: Has a `workspaceId` (required), `onSelectSession`
- `placeholder`: Has `workspaceId` (optional), no callbacks
2. **Updated component** to extract mode-specific values from props based on the discriminant
3. **Updated call site** (`WorkspacesMain.tsx`) to pass the correct mode and props based on state
**Benefits:**
- No more redundant `= undefined` defaults for props that are required in their respective modes
- Type safety ensures each mode has exactly the props it needs
- Self-documenting code with explicit mode discriminant
- ESLint and TypeScript checks pass
* Cleanup script changes for workspace f4ec6f6e-a524-4760-889a-7ec2ebbce4c6
* Both lint and type check pass. I've removed `workspaceId` from `PlaceholderProps` since it's not needed when the editor is disabled in placeholder mode.
* All tasks are complete. Here's a summary of the changes made:
## Summary
I've refactored `DiffViewCardWithComments.tsx` and its related files to fix 11 ESLint errors (9 in DiffViewCardWithComments, 1 in CommentWidgetLine, 1 in ReviewCommentRenderer).
### Changes Made:
1. **`DiffViewCardWithComments.tsx`** - Converted to use discriminated unions:
- `DiffInput` type: Changed optional props (`oldPath?`, `changeKind?`, `hasLineNumbers?`) to explicit union types (`oldPath: string | undefined`)
- `DiffViewCardWithCommentsProps`: Split into two modes using a discriminated union:
- `CollapsibleProps` (mode: 'collapsible') - requires `expanded` and `onToggle`
- `StaticProps` (mode: 'static') - always expanded, no toggle
- Base props (`status`, `className`, `projectId`, `attemptId`) now use `T | undefined` instead of `T?`
2. **`CommentWidgetLine.tsx`** - Changed `projectId?: string` to `projectId: string | undefined`
3. **`ReviewCommentRenderer.tsx`** - Changed `projectId?: string` to `projectId: string | undefined`
4. **`ChangesPanel.tsx`** (callsite) - Updated to pass the new required props:
- Added `mode="collapsible"`
- Added `status={undefined}`
- Added `className=""`
### Verification:
- ✅ ESLint passes for all modified files
- ✅ TypeScript type check passes
* Cleanup script changes for workspace f4ec6f6e-a524-4760-889a-7ec2ebbce4c6
* Done. Here's a summary of all changes:
## Summary
Refactored `DiffViewCardWithComments.tsx` and its callsites to fix ESLint issues:
### Changes Made:
1. **`DiffViewCardWithComments.tsx`**:
- Removed unused `status` prop and `ToolStatusDot` rendering
- Made `projectId` and `attemptId` required strings (no longer `undefined`)
- Removed conditional check for `attemptId` on the Open in IDE button (always shown now)
2. **`ChangesPanel.tsx`**:
- Made `projectId` and `attemptId` required strings
- Removed `status={undefined}` from the component call
3. **`CommentWidgetLine.tsx`**:
- Changed `projectId: string | undefined` to `projectId: string`
4. **`ReviewCommentRenderer.tsx`**:
- Changed `projectId: string | undefined` to `projectId: string`
5. **`ChangesPanelContainer.tsx`**:
- Made `className` and `attemptId` required props
- Added guard: if `projectId` is unavailable, renders empty panel
6. **`WorkspacesLayout.tsx`**:
- Added guard: only renders `ChangesPanelContainer` when `selectedWorkspace?.id` exists
- Passes required `className=""` prop
### Verification:
- ✅ TypeScript type check passes
- ✅ ESLint passes for all modified files
* Done. Changed `changeKind` from `DiffChangeKind | undefined` to `DiffChangeKind` in the `DiffInput` type. Both TypeScript and ESLint pass.
* Done. I've successfully refactored `SearchableDropdownContainer.tsx` to fix the 6 ESLint errors:
**Changes made:**
1. **`SearchableDropdownContainer.tsx`** (interface):
- `selectedValue: string | null` (removed `?`)
- `filterItem: ((item: T, query: string) => boolean) | null` (removed `?`, added `| null`)
- `contentClassName: string` (removed `?`)
- `placeholder: string` (removed `?`)
- `emptyMessage: string` (removed `?`)
- `getItemBadge: ((item: T) => string | undefined) | null` (removed `?`, added `| null`)
2. **`SearchableDropdownContainer.tsx`** (implementation):
- Removed default values from destructuring (`placeholder = 'Search'`, `emptyMessage = 'No items found'`)
- Changed `if (filterItem)` to `if (filterItem !== null)`
- Changed `getItemBadge={getItemBadge}` to `getItemBadge={getItemBadge ?? undefined}`
3. **`RepoCardSimple.tsx`** (callsite):
- Added `filterItem={null}`
- Changed `selectedValue={selectedBranch}` to `selectedValue={selectedBranch ?? null}` to handle the case when `selectedBranch` is `undefined`
All ESLint errors for `SearchableDropdownContainer.tsx` are now resolved, and TypeScript compiles without errors.
* Refactor FileTreeContainer to fix ESLint errors for optional props
- Make all props required in FileTreeContainerProps interface
- Add guard in RightSidebar to only render Changes section when
selectedWorkspace exists, ensuring workspaceId is always defined
- Remove redundant null check for onSelectFile callback
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* Refactor NewDisplayConversationEntry to fix ESLint errors for optional props
- Remove dead `task` prop from NewDisplayConversationEntry and ConversationListContainer
(was only passed to legacy DisplayConversationEntry for entry types that don't use it)
- Make `executionProcessId` and `taskAttempt` required props
- Convert internal helper component optional props from `prop?: T` to `prop: T | undefined`
to satisfy ESLint while preserving the same runtime behavior
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* Refactor VirtualizedProcessLogs to fix ESLint errors for optional props
Made search-related props required instead of optional:
- searchQuery: string (was optional)
- matchIndices: number[] (was optional)
- currentMatchIndex: number (was optional)
Updated callsites to provide explicit "no search" values where search
functionality is not used.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* Cleanup script changes for workspace f4ec6f6e-a524-4760-889a-7ec2ebbce4c6
* Refactor container components to fix ESLint errors for optional props
Made the following props required (parents always provide them):
- BrowseRepoButtonContainer: disabled
- CopyButton: disabled
- WorkspacesMainContainer: isNewSessionMode, onStartNewSession
- LogsContentContainer: className
- PreviewBrowserContainer: attemptId, className
- PreviewControlsContainer: attemptId, className
Changed to union types (legitimately optional values):
- LogsContentContainer: command: string | undefined
- ProjectSelectorContainer: selectedProjectName: string | undefined
Added guards in parent components to only render children when
required data is available (RightSidebar, WorkspacesLayout).
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* Cleanup script changes for workspace f4ec6f6e-a524-4760-889a-7ec2ebbce4c6
* Refactor WorkspacesLayout to fix ESLint errors for optional props
Extract create mode sections into dedicated container components:
- CreateModeProjectSectionContainer: project selector with useCreateMode
- CreateModeReposSectionContainer: repos list with branch auto-selection
- CreateModeAddReposSectionContainer: add repos section
This removes the ModeProviderProps interface with optional props that
violated the ESLint rule. Now CreateModeProvider is only rendered when
in create mode, and each container manages its own context access.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* Cleanup script changes for workspace f4ec6f6e-a524-4760-889a-7ec2ebbce4c6
---------
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
* integrated terminal
* ci
* persist terminal
* Done! I've moved the TerminalPanelContainer from the main panel area to the right sidebar. Here's a summary of the changes:
- Added `isTerminalVisible: boolean` to global state (defaults to `true`)
- Added `toggleTerminal()` and `setTerminalVisible(value)` actions
- Added `isTerminalVisible` to the persisted state and the `useWorkspacePanelState` hook
- Imported `TerminalPanelContainer` and `useUiPreferencesStore`
- Restructured the component to always include a terminal section at the bottom (when not in create mode and `isTerminalVisible` is true)
- Dynamic flex ratios:
- With upper content + terminal: flex-4 (content) / flex-2 (git) / flex-4 (terminal)
- Without upper content + terminal: flex-3 (git) / flex-7 (terminal)
- When terminal is hidden: original ratios preserved
- Removed the `TerminalPanelContainer` import
- Removed the TERMINAL case from the right main panel rendering
- Added `isTerminalVisible` to `ActionVisibilityContext` interface
- Updated `ToggleTerminalMode` action to use `toggleTerminal()` and check `isTerminalVisible`
- Added `isTerminalVisible` from `panelState` to the visibility context
The terminal now appears permanently at the bottom of the right sidebar (when visible), and the toggle button collapses/expands just the terminal section within the sidebar. The visibility state is persisted to localStorage.
* Frontend ESLint passes with no errors. The backend Rust error (`crates/utils/src/shell.rs:31`) is a pre-existing issue in the codebase, not related to my changes.
* `cargo check` passes now. The fix was adding `.to_path_buf()` to convert the `&Path` reference to an owned `PathBuf`.
* The code compiles. Done! I've added three environment variables in `crates/local-deployment/src/pty.rs:73-75`:
1. `ZDOTDIR=/nonexistent` - prevents zsh from loading `~/.zshrc`
2. `PS1="$ "` - sets the bash prompt
3. `PROMPT="$ "` - sets the zsh prompt
The terminal prompt will now show just `$ ` instead of `lkw@Louiss-MacBook-Pro vibe-kanban %`. Run `pnpm run dev:qa` and open the terminal panel to verify.
* Cleanup script changes for workspace 928e696e-5f40-4603-9227-798f0520e07f
* Done! The fix is simpler - using `cmd.arg("-f")` to tell zsh/bash to skip loading config files. This:
1. Removes the `ZDOTDIR=/nonexistent` that was causing errors
2. Adds `-f` flag which skips `.zshrc`/`.bashrc` loading
3. Keeps `PS1` and `PROMPT` env vars which will now be respected
Run `pnpm run dev:qa` and open the terminal to verify the prompt shows `$ `.
* Cleanup script changes for workspace 928e696e-5f40-4603-9227-798f0520e07f
* I've implemented the terminal theme integration. Here's a summary of the changes:
## Changes Made
**1. Created `frontend/src/utils/terminalTheme.ts`**
- `hslToHex()` function to convert HSL CSS variable format (`"210 40% 98%"`) to hex colors
- `getCssVariable()` helper to read CSS variables from the `.new-design` element
- `getTerminalTheme()` function that builds an xterm.js `ITheme` object from CSS variables:
- Uses `--console-background` and `--console-foreground` for main colors
- Uses `--console-success` and `--console-error` for green/red ANSI colors
- Provides appropriate ANSI color palettes for both light and dark modes
**2. Updated `frontend/src/components/ui-new/terminal/XTermInstance.tsx`**
- Imported `useTheme` hook and `getTerminalTheme` utility
- Replaced hardcoded Tokyo Night theme with dynamic `getTerminalTheme()` call
- Added effect to update terminal theme when app theme changes (`terminal.options.theme = getTerminalTheme()`)
The terminal will now:
- Initialize with colors matching the current theme
- Automatically update colors when switching between light and dark mode
- Use the console color variables defined in `index.css`
* Cleanup script changes for workspace 928e696e-5f40-4603-9227-798f0520e07f
* Now I understand the issue clearly. Here are the relevant variables:
| Variable | Light Mode | Dark Mode | Purpose |
|----------|------------|-----------|---------|
| `--_primary` | `0 0% 5%` (dark) | `240 4.8% 95.9%` (light) | Button background - **inverted** |
| `--_console-background` | `0 0% 100%` (white) | `0 0% 0%` (black) | Terminal background - **correct** |
| `--_console-foreground` | `0 0% 5%` (dark) | `210 40% 98%` (light) | Terminal text - **correct** |
| `--bg-primary` | `0 0% 100%` (white) | `0 0% 13%` (dark gray) | Page background |
The code was changed to use `--primary` but that's the wrong variable. For the terminal, you should use:
- `--console-background` / `--_console-background` for the background
- `--console-foreground` / `--_console-foreground` for the text
Or if you prefer to match other UI elements:
- `--bg-primary` for background
- `--text-high` for foreground text
Which approach would you prefer? The original `--console-*` variables were specifically designed for terminal styling, or we can use `--bg-primary`/`--text-high` to match the general UI background.
* Cleanup script changes for workspace 928e696e-5f40-4603-9227-798f0520e07f
* Done. The terminal will now use `--bg-primary` for the background and `--text-high` for the foreground text. This means:
- **Light mode**: White background (`0 0% 100%`) with dark text (`0 0% 5%`)
- **Dark mode**: Dark gray background (`0 0% 13%`) with light text (`0 0% 96%`)
* Done. The terminal will now use `--bg-secondary` for the background and `--text-high` for the foreground text. This means:
- **Light mode**: Light gray background (`0 0% 95%`) with dark text (`0 0% 5%`)
- **Dark mode**: Darker gray background (`0 0% 11%`) with light text (`0 0% 96%`)
* Let me know if you find any issues during testing or need adjustments!
* Cleanup script changes for workspace 928e696e-5f40-4603-9227-798f0520e07f
* terminal
* sidebar cleanup
* fix chat collapse
Amp-Thread-ID: https://ampcode.com/threads/T-019bc754-8db9-712a-a915-58d74d210cad
Co-authored-by: Amp <amp@ampcode.com>
* for the terminal on windows we need to default to powershell if avalibale for the pty (vibe-kanban 049dbf73)
only if powershell.exe cannot be resolved, we should use cmd.
* he colour theme used for the terminal ui isn't visible enough in light mode (vibe-kanban 5f50878a)
t I think we either don't override the ANSI colour mapping with our own, or it's not contrasted enough
* fmt
---------
Co-authored-by: Gabriel Gordon-Hall <ggordonhall@gmail.com>
Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: Solomon <abcpro11051@disroot.org>
* feat: display context usage in UI for Codex executor
- Extract token usage data from Codex execution logs.
- Track usage state within the `EntriesContext`.
- Display a context usage progress bar in the next action card.
* Add claude-code context token usage
* fix type issue
---------
Co-authored-by: Louis Knight-Webb <louis@bloop.ai>
* The implementation is complete. Here's a summary of the changes:
## Summary
I added a check for commits made by the coding agent during execution. If commits were made, the cleanup script will now run.
### Changes Made
**File: `crates/local-deployment/src/container.rs`**
1. **Added new method `has_commits_from_execution`** (lines 314-344): This method compares the `before_head_commit` (captured at execution start) with the current HEAD for each repo to detect if any commits were made during execution.
2. **Updated the `should_start_next` logic** (lines 477-490): The decision to run the cleanup script now checks both:
- Whether uncommitted changes were just committed (`changes_committed`)
- Whether the agent made any commits during execution (`has_commits_from_execution`)
If either condition is true, the cleanup script runs.
### How It Works
- Before: Cleanup script only ran if `try_commit_changes()` returned `true` (i.e., if there were uncommitted changes to commit)
- After: Cleanup script runs if `try_commit_changes()` returned `true` **OR** if `has_commits_from_execution()` returns `true` (i.e., HEAD changed from what it was at execution start)
This ensures that if a coding agent makes commits during its execution but leaves no uncommitted changes, the cleanup script will still run.
* feat: add Claude Code hooks for cleanup scripts in worktrees
When a workspace is created with repos that have cleanup scripts configured,
automatically create .claude/settings.local.json with a "Stop" hook that
runs the cleanup scripts when the agent finishes.
- Add create_claude_hooks_config() to create .claude/hooks/run-cleanup.sh
- Handle single-repo (agent in repo dir) vs multi-repo (agent in workspace root)
- Also add has_commits_from_execution() to run cleanup when agent made commits
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* All tests pass. The fix is complete - the Claude Code hooks will now always be created regardless of whether repos have cleanup scripts configured.
* Cleanup script changes for workspace bf914d08-cb51-49a4-89b9-ba56108c841a
* Done. I've implemented the simplified `check-git-status.sh` hook using `include_str!`:
1. Created `crates/local-deployment/src/scripts/check-git-status.sh` - the script that checks for uncommitted changes and blocks the agent until they commit
2. Updated `crates/local-deployment/src/container.rs`:
- Added `const CHECK_GIT_STATUS_SCRIPT: &str = include_str!("scripts/check-git-status.sh");` to embed the script at compile time
- Simplified `create_claude_hooks_config()` to only write this one hook script (removed all the cleanup script logic)
The hook will now be created in `.claude/hooks/check-git-status.sh` and configured in `.claude/settings.local.json` as a "Stop" hook for Claude Code workspaces.
* Done. I've implemented the Stop hook via the protocol in `claude.rs`:
**Summary of changes:**
1. **Created** `crates/executors/src/scripts/check-git-status.sh` - The script that checks for uncommitted changes
2. **Modified** `crates/executors/src/executors/claude.rs`:
- Added `const CHECK_GIT_STATUS_SCRIPT` using `include_str!` to embed the script at compile time
- Updated `get_hooks()` to always include a Stop hook with the script (using `shlex::try_quote` for proper escaping)
- The Stop hook is now sent via `protocol_peer.initialize(hooks)` alongside any PreToolUse hooks
3. **Removed** from `crates/local-deployment/src/container.rs`:
- Deleted `create_claude_hooks_config()` function
- Deleted the const and call to create hooks
- Deleted the `scripts/` directory
Now the hook is sent via the protocol, so no files are created in the workspace that would show up as untracked.
* Done. I've updated the implementation to use `settings.local.json` with the script inlined via `bash -c`:
**Summary of changes:**
1. **Reverted `crates/executors/src/executors/claude.rs`**:
- Removed `CHECK_GIT_STATUS_SCRIPT` const
- Restored `get_hooks()` to only return PreToolUse hooks (no Stop hook)
2. **Moved script to `crates/local-deployment/src/scripts/check-git-status.sh`**
3. **Added `shlex = "1.3.0"` to `crates/local-deployment/Cargo.toml`**
4. **Updated `crates/local-deployment/src/container.rs`**:
- Added `CHECK_GIT_STATUS_SCRIPT` const using `include_str!`
- Added `create_claude_hooks_config()` function that:
- Only runs for single-repo workspaces
- Creates `.claude/settings.local.json` with the script inlined via `bash -c` using `shlex::try_quote` for proper escaping
- No `.claude/hooks/` directory is created (script is fully inline)
- Called from `create_workspace_config_files()`
Since `settings.local.json` is already gitignored by Claude Code, this approach avoids the untracked file issue while keeping the script in a separate file for maintainability.
* Cleanup script changes for workspace bf914d08-cb51-49a4-89b9-ba56108c841a
* Done. The Claude hooks setup now only runs for Claude Code executor.
**Changes made to `crates/local-deployment/src/container.rs`:**
1. Removed the call to `create_claude_hooks_config()` from `create_workspace_config_files()` (and changed parameter back to `_agent_working_dir`)
2. Added the hooks setup in `start_execution_inner()` with a check for Claude Code executor:
```rust
if let Some(BaseCodingAgent::ClaudeCode) = executor_action.base_executor() {
Self::create_claude_hooks_config(
¤t_dir,
workspace.agent_working_dir.as_deref(),
)
.await?;
}
```
Now the `settings.local.json` with the Stop hook will only be created when running with the Claude Code executor, not for other executors like Codex, Gemini, etc.
* Cleanup script changes for workspace bf914d08-cb51-49a4-89b9-ba56108c841a
* Done. The implementation now explicitly checks the repo count:
**Changes to `crates/local-deployment/src/container.rs`:**
1. **Updated call site in `start_execution_inner()`:**
```rust
if let Some(BaseCodingAgent::ClaudeCode) = executor_action.base_executor() {
let repos = WorkspaceRepo::find_repos_for_workspace(&self.db.pool, workspace.id).await?;
if repos.len() == 1 {
if let Some(agent_dir) = &workspace.agent_working_dir {
Self::create_claude_hooks_config(¤t_dir.join(agent_dir)).await?;
}
}
}
```
2. **Simplified `create_claude_hooks_config()`:**
- Now takes just `repo_dir: &Path` (the full path to the repo directory)
- Removed the `agent_working_dir` parameter and internal check
- The caller is responsible for ensuring this is only called for single-repo workspaces
* Cleanup script changes for workspace bf914d08-cb51-49a4-89b9-ba56108c841a
* Done. I've successfully implemented the Stop hook via protocol callbacks instead of the file-based approach. Here's a summary of the changes:
## Summary
**Files modified:**
1. `crates/executors/src/executors/claude/client.rs`:
- Added `working_dir: PathBuf` field to `ClaudeAgentClient`
- Added `STOP_GIT_CHECK_CALLBACK_ID` constant
- Updated `on_hook_callback()` to handle Stop git check callbacks
- Added `check_git_status()` async function that checks for uncommitted changes
- Added `find_git_repo_in_subdirs()` helper for multi-repo fallback
2. `crates/executors/src/executors/claude.rs`:
- Updated `get_hooks()` to always include a Stop hook with callback ID
- Passed `working_dir` to `ClaudeAgentClient::new()` in `spawn_internal()`
- Added import for `STOP_GIT_CHECK_CALLBACK_ID`
3. `crates/local-deployment/src/container.rs`:
- Removed `CHECK_GIT_STATUS_SCRIPT` constant
- Removed `create_claude_hooks_config()` function
- Removed the call to create file-based hooks in `start_execution_inner()`
4. `crates/local-deployment/Cargo.toml`:
- Removed `shlex` dependency
**Files deleted:**
- `crates/local-deployment/src/scripts/check-git-status.sh`
- `crates/local-deployment/src/scripts/` (empty directory)
**Benefits of the new approach:**
- No files created in the workspace (avoids untracked file issues)
- Git status check runs dynamically via protocol callback
- Supports single-repo workspaces with fallback to checking subdirectories
- More portable - no dependency on bash or external scripts
* Cleanup script changes for workspace bf914d08-cb51-49a4-89b9-ba56108c841a
* Done. I've fixed the Stop hook response format. The changes:
1. **`check_git_status()`** now returns the correct format for Stop hooks:
- When allowing stop: returns `{}` (empty object)
- When blocking stop: returns `{"continue": false, "stopReason": "..."}`
2. **`on_hook_callback()`** now returns the Stop hook result directly without wrapping it in `hookSpecificOutput`
The implementation now follows the Claude SDK documentation for Stop hooks, which use top-level `continue` and `stopReason` fields rather than the `hookSpecificOutput` wrapper used by PreToolUse hooks.
* Done. I've updated the Stop hook response format to use `{"decision": "approve"}` or `{"decision": "block", "reason": "..."}` which matches the SDK callback format documented at code.claude.com/docs/en/hooks.
* Fixed. Removed the unused `_agent_working_dir` parameter from `create_workspace_config_files` and updated both call sites.
* Done. I've implemented the `RepoContext` struct to properly pass repository information from local-deployment to executors. Here's a summary of the changes:
**Files modified:**
1. **`crates/executors/src/env.rs`**:
- Added `RepoContext` struct with `workspace_root` and `repo_names` fields
- Added `repo_paths()` method to get full paths to all repos
- Added `repo_context: RepoContext` field to `ExecutionEnv` (required field)
- Updated `ExecutionEnv::new()` to take `RepoContext` as parameter
2. **`crates/executors/src/executors/claude/client.rs`**:
- Replaced `working_dir: PathBuf` with `repo_context: RepoContext` in `ClaudeAgentClient`
- Updated `check_git_status()` to iterate over all repos and check each for uncommitted changes
- Removed `find_git_repo_in_subdirs()` helper (no longer needed)
3. **`crates/executors/src/executors/claude.rs`**:
- Updated `spawn_internal()` to pass `env.repo_context` to `ClaudeAgentClient`
4. **`crates/local-deployment/src/container.rs`**:
- Added import for `RepoContext`
- In `start_execution_inner()`: Load repos, build `RepoContext`, pass to `ExecutionEnv::new()`
* Done. I've added the `commit_reminder` setting to `ClaudeCode`:
1. **Added `commit_reminder: Option<bool>` field** to the `ClaudeCode` struct in `claude.rs`
2. **Made the Stop hook conditional** - it now only registers when `commit_reminder` is `true` (defaults to `false`/off)
3. **Regenerated TypeScript types** so the frontend knows about the new field
Users can enable the commit reminder by adding `"commit_reminder": true` to their profile configuration in `~/.config/vibe-kanban/profiles.json`.
* Done. Removed all 10 obvious comments as requested.
* Done. Now synthetic User messages (like the Stop hook feedback) will be rendered as `SystemMessage` entries in the logs. The implementation:
1. Added `is_synthetic: bool` field to `ClaudeJson::User` variant (with `#[serde(default, rename = "isSynthetic")]`)
2. When `is_synthetic` is true, any Text content in the message gets rendered as a `SystemMessage` entry
* Fix tests
* No findings in the latest commits I reviewed (048e3e1b5, 723ff78bd, c1caa1f73, 4af28b855, ad1334b94). Residual risk: I didn’t run tests, and the review is based on reading diffs only.
Open questions / assumptions:
- Assuming it’s intentional that the Stop hook is now opt-in via `commit_reminder` in `crates/executors/src/executors/claude.rs`.
- Assuming workspaces always populate repo names; otherwise the Stop hook in `crates/executors/src/executors/claude/client.rs` will auto-approve when none are configured.
Change summary:
- Added repo context plumbed into executor env and multi-repo git status checks in `crates/executors/src/env.rs`, `crates/executors/src/executors/claude.rs`, `crates/executors/src/executors/claude/client.rs`, and `crates/local-deployment/src/container.rs`.
- Introduced `commit_reminder` config and schema/types updates in `crates/executors/src/executors/claude.rs`, `shared/schemas/claude_code.json`, and `shared/types.ts`.
- Render synthetic user messages as system log entries in `crates/executors/src/executors/claude.rs`.
* Lint
* Done. I've added the `commit_reminder` beta setting to the global Config:
1. **Backend Config** (`v8.rs`) - Added `commit_reminder: bool` field (defaults to `false`)
2. **Removed from ClaudeCode** - Removed per-profile field, now uses global setting
3. **ExecutionEnv** - Added `commit_reminder` field to pass setting to executors
4. **Container** - Reads setting from config and passes to `ExecutionEnv`
5. **Claude executor** - Uses `env.commit_reminder` when building hooks
6. **Frontend UI** - Added checkbox in Beta Features section
7. **i18n** - Added translation keys for all 6 locales (en, es, ja, ko, zh-Hans, zh-Hant)
8. **TypeScript types** - Regenerated via `pnpm run generate-types`
Users can now enable the commit reminder feature from Settings > General > Beta Features.
* All tests pass. Both `pnpm run lint` and `cargo test --workspace` complete successfully.
---------
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
* The implementation is complete. Here's a summary of the changes made to `file-tag-typeahead-plugin.tsx`:
1. **Added import** for `useWorkspaceContext` from `@/contexts/WorkspaceContext`
2. **Created helper function** `getMatchingDiffFiles()` that:
- Takes a query and the `diffPaths` Set
- Filters paths that match the query (checking both filename and full path)
- Returns properly typed `DiffFileResult` objects with all required fields (`is_file`, `match_type`, `score`)
- Uses a high score value to ensure diff files rank above server results
3. **Modified `onQueryChange`** to:
- Extract `diffPaths` from WorkspaceContext
- Get matching local files from diffPaths first
- Fetch server results via `searchTagsAndFiles()`
- Deduplicate server file results by filtering out any paths already in local files
- Merge results with order: tags → local diff files → server files
The changes ensure that:
- Files from the current workspace diffs appear in typeahead results
- Diff files are ranked higher than server-sourced files
- No duplicate entries appear when a file exists in both sources
* Done. The fix involved two changes:
1. **`WorkspaceContext.tsx`** (line 78-81): Exported the `WorkspaceContext` so it can be used directly with `useContext`
2. **`file-tag-typeahead-plugin.tsx`**:
- Changed import from `useWorkspaceContext` to `WorkspaceContext`
- Added `useContext` to React imports
- Changed usage from `const { diffPaths } = useWorkspaceContext()` to:
```typescript
const workspaceContext = useContext(WorkspaceContext);
const diffPaths = workspaceContext?.diffPaths ?? new Set<string>();
```
Now when the WYSIWYG is used in the old UI (without a `WorkspaceProvider`), `workspaceContext` will be `null`, and `diffPaths` will default to an empty Set, meaning only server results will be shown. In the new UI with `WorkspaceProvider`, diff files will be included as expected.
* Done. The changes:
1. Added `MAX_FILE_RESULTS = 10` constant
2. Updated the result merging logic to:
- Limit local diff files to max 10
- Fill remaining slots with server files
- This ensures diffPaths files always appear first (prioritized)
File results are now capped at 10 total, preventing the menu from scrolling off the page.
* Cleanup script changes for workspace bda801c1-f48c-4ae8-948b-f0db6269d807
* Lint passes now. The fix was to wrap the `diffPaths` fallback in `useMemo` to ensure a stable reference when the context is not available.
* Fix command builder whitespace handling
Add a seprate command for parameters that need to be split on whitespace boundaries, and default to not splitting.
The previous behaviour always split parameters, which caused copilot CLI to fail when a project had whitespace in the repository directory name; `error: too many arguments. Expected 0 arguments but got 1;.
The issue was not specific to copilot altough it only occured in copilot due to an implementation detail for copilot where it recevied a directory name which happened to contain the project name.
* make extend_shell_params private
* The fix is complete. Here's a summary of the changes:
**Problem**: Clicking "View Full Logs" button opened the logs panel but showed "Select a process to view logs" error because the process ID wasn't being passed to the logs panel context.
**Root cause**: In `PreviewControlsContainer.tsx`, when `onViewProcessInPanel` was provided but `targetId` was falsy, the fallback path only switched the panel mode without setting which process to display.
**Solution**: Modified `PreviewControlsContainer.tsx` to use `viewProcessInPanel` directly from the `LogsPanelContext` instead of relying on the prop. This ensures the process ID is always properly set when switching to the logs panel.
**Changes made**:
1. `frontend/src/components/ui-new/containers/PreviewControlsContainer.tsx`:
- Added import for `useLogsPanel` hook
- Removed `onViewProcessInPanel` prop from interface
- Use `viewProcessInPanel` from context directly
- Updated `handleViewFullLogs` to call the context function
2. `frontend/src/components/ui-new/containers/RightSidebar.tsx`:
- Removed unused `useLogsPanel` import
- Removed `viewProcessInPanel` from destructuring
- Removed `onViewProcessInPanel` prop from `PreviewControlsContainer` usage
* All checks pass. The diagnostic logging is now in place. Here's a summary:
## Diagnostic Logging Added
**Frontend** (`frontend/src/hooks/useLogStream.ts`):
- Logs when WebSocket connection is opened with process ID
- Logs successful connection
- Logs errors with process ID
- Logs close events with code and reason
**Backend** (`crates/server/src/routes/execution_processes.rs`):
- Logs when checking stream for an exec_id
- Logs warning if no stream found
- Logs when stream is found and WebSocket is being upgraded
**Backend** (`crates/services/src/services/container.rs`):
- Logs when looking up msg_store
- Logs if in-memory store is found
- Logs if falling back to DB
- Logs DB record count or warnings if no logs found
**Backend** (`crates/local-deployment/src/container.rs`):
- Logs when creating a new store for a process
- Logs when store is inserted into the map with map size
## Next Steps
Run `pnpm run dev:qa`, reproduce the issue by:
1. Starting a dev server in a workspace
2. Clicking "View Full Logs"
Then share the logs from:
- **Browser console** (look for `[useLogStream]` messages)
- **Backend terminal** (look for `stream_raw_logs`, `track_child_msgs_in_store` messages)
* Cleanup script changes for workspace 5963230a-5419-40d6-89e9-b26519d38291
* The fix is complete. The issue was that `handleViewFullLogs` accepted an optional `processId` parameter, but when used as a button `onClick` handler, it received the click event instead. Since the click event object is truthy, the `??` operator didn't fall through to `activeProcess?.id`, causing the event object to be passed to `viewProcessInPanel()`.
The fix removes the parameter so the function always uses `activeProcess?.id` directly.
You can now test by running `pnpm run dev:qa` and clicking "View Full Logs" - it should correctly open the logs panel with the dev server logs.
* All diagnostic logs have been removed. The fix is complete and all checks pass.
* All tasks are complete. Here's a summary of the changes made:
## Summary
Fixed the issue where `ScriptFixerDialog.tsx` was replacing cleanup and setup scripts with `null` when editing a dev server script.
### Changes Made:
1. **Added `serde_with` dependency** (`Cargo.toml` and `crates/db/Cargo.toml`)
- Added `serde_with = "3"` to enable the double option pattern
2. **Updated `UpdateRepo` struct** (`crates/db/src/models/repo.rs`)
- Changed all fields from `Option<T>` to `Option<Option<T>>` with the `double_option` serde helper
- Added `#[ts(optional, type = "...")]` annotations for proper TypeScript type generation
3. **Updated `Repo::update` method** (`crates/db/src/models/repo.rs`)
- Now properly handles three states:
- `None` = field absent → preserve existing value
- `Some(None)` = explicitly null → set to NULL
- `Some(Some(v))` = has value → update to value
4. **Updated `ScriptFixerDialog.tsx`** (`frontend/src/components/dialogs/scripts/ScriptFixerDialog.tsx`)
- Changed `handleSave` and `handleSaveAndTest` to only send the field being edited
- Removed `repos` from the dependency arrays since it's no longer used in the save functions
5. **Regenerated TypeScript types**
- `UpdateRepo` now has all fields as optional: `field?: type | null`
### Result:
The API now supports true partial updates. Clients can send only the fields they want to update, and existing values are preserved for omitted fields. Sending `null` explicitly will clear a field to NULL.
* Done. All Rust code has been formatted.
## Summary
Successfully cleaned up root level files in `frontend/src/components/ui-new/`:
### Deleted (unused files):
- `MockConversationList.tsx` - not imported anywhere
- `MockDisplayConversationEntry.tsx` - not imported anywhere
### Moved to `containers/`:
- `ConversationList.tsx` → `containers/ConversationListContainer.tsx`
- `NewDisplayConversationEntry.tsx` → `containers/NewDisplayConversationEntry.tsx`
- `VirtualizedProcessLogs.tsx` → `containers/VirtualizedProcessLogs.tsx`
### Updated imports in:
- `views/WorkspacesMain.tsx`
- `views/PreviewControls.tsx`
- `containers/LogsContentContainer.tsx`
- `components/dialogs/scripts/ScriptFixerDialog.tsx`
- `containers/ConversationListContainer.tsx`
- `containers/NewDisplayConversationEntry.tsx`
The root level of `ui-new/` is now clean with no files remaining. All components that use state or side effects were correctly placed in `containers/` to comply with ESLint rules. Both type check (`pnpm run check`) and lint (`pnpm run lint`) pass successfully.
## Summary
**Changes made:**
1. **Added `useMemo` import** (line 1) for memoizing the filtered options array
2. **Added logic to hide "Open pull request" when PR is open** (lines 101-109):
- `hasPrOpen` checks if `prStatus === 'open'`
- `availableActionOptions` filters out the 'pull-request' option when a PR is already open
3. **Added fallback for selected action** (lines 111-113):
- `effectiveSelectedAction` ensures that if the user had previously selected 'pull-request' but a PR is now open, the button shows 'Merge' instead
4. **Updated SplitButton** to use `availableActionOptions` and `effectiveSelectedAction` (lines 286-291)
**Behavior:**
- When there is no open PR: Both "Open pull request" and "Merge" options are available
- When there is an open PR (`prStatus === 'open'`): Only the "Merge" option is shown
- When PR is closed or merged: The "Open pull request" option reappears (allowing users to create a new PR)
* I've successfully implemented workspace-specific panel state persistence. Here's a summary of the changes:
## Summary
### Changes Made
1. **`frontend/src/stores/useUiPreferencesStore.ts`**
- Added `WorkspacePanelState` type to track `rightMainPanelMode` and `isLeftMainPanelVisible` per workspace
- Added `workspacePanelStates: Record<string, WorkspacePanelState>` to store state keyed by workspace ID
- Updated `toggleLeftMainPanel`, `toggleRightMainPanelMode`, `setRightMainPanelMode`, and `setLeftMainPanelVisible` to accept an optional `workspaceId` parameter
- Added `getWorkspacePanelState` and `setWorkspacePanelState` actions
- Added `useWorkspacePanelState(workspaceId)` hook for easy consumption
- Updated `partialize` to persist `workspacePanelStates` to localStorage
2. **`frontend/src/components/ui-new/containers/WorkspacesLayout.tsx`**
- Changed from using `useUiPreferencesStore` directly to using `useWorkspacePanelState(workspaceId)` hook
- Panel state is now workspace-specific
3. **`frontend/src/components/ui-new/actions/useActionVisibility.ts`**
- Updated to use `useWorkspacePanelState` for visibility context
4. **`frontend/src/components/ui-new/actions/index.ts`**
- Updated `ToggleLeftMainPanel`, `ToggleChangesMode`, `ToggleLogsMode`, `TogglePreviewMode`, and `ToggleDevServer` actions to pass `currentWorkspaceId` when toggling panel modes
### Scope
**Workspace-specific:**
- `rightMainPanelMode` - Which panel (Preview/Changes/Logs) is open
- `isLeftMainPanelVisible` - Whether the chat panel is visible
**Stays global:**
- `isLeftSidebarVisible` - Workspace list sidebar (navigation element)
- `isRightSidebarVisible` - Git/Settings sidebar (global actions)
- Panel sizes (already work correctly)
### Testing
Verified the feature works:
1. Opened Preview panel in Workspace A
2. Navigated to Workspace B → Preview panel is closed (default state)
3. Navigated back to Workspace A → Preview panel is still open ✓
* Cleanup script changes for workspace c8b73e59-ac41-4c0f-be78-7b6499d514f9
* The refactoring is complete. Let me provide a summary of the changes:
## Summary
Refactored `useUiPreferencesStore.ts` to remove duplicate code paths for workspace-specific panel state:
### Changes Made
1. **`frontend/src/stores/useUiPreferencesStore.ts`**
- Removed legacy global state (`isLeftMainPanelVisible`, `rightMainPanelMode`) from State type and initialization
- Simplified 4 panel state actions by removing `else` branches for legacy behavior:
- `toggleLeftMainPanel` - now early-returns if no workspaceId
- `toggleRightMainPanelMode` - simplified to single set() call
- `setRightMainPanelMode` - simplified to single set() call
- `setLeftMainPanelVisible` - simplified
- Removed `resetForCreateMode` action (was only setting legacy state)
- Removed unused `useIsRightMainPanelVisible` hook
2. **`frontend/src/contexts/WorkspaceContext.tsx`**
- Removed the `useEffect` that called `resetForCreateMode()` on create mode
- Removed unused `useUiPreferencesStore` import
3. **`frontend/src/contexts/LogsPanelContext.tsx`**
- Updated to use `useWorkspacePanelState` with workspace ID from context
4. **`frontend/src/components/ui-new/containers/SessionChatBoxContainer.tsx`**
- Updated to use `useWorkspacePanelState` with workspace ID
### Impact
- **~50 lines removed** from the codebase
- **Cleaner code** - no more `if (workspaceId) ... else ...` branching in every action
- **Same behavior** - all callers were already passing workspaceId
* Cleanup script changes for workspace c8b73e59-ac41-4c0f-be78-7b6499d514f9
* Done. Here's a summary of the fix:
## Summary
**Issue #1937** is legitimate - Windows users cannot connect MCP tools when `HOST=0.0.0.0` because Windows doesn't allow client connections to that address.
**Fix applied** in `crates/server/src/bin/mcp_task_server.rs`:
Added `MCP_HOST` and `MCP_PORT` environment variables that override `HOST` and `BACKEND_PORT`/`PORT` for MCP client connections.
**Priority order:**
- Host: `VIBE_BACKEND_URL` > `MCP_HOST` > `HOST` > `127.0.0.1`
- Port: `VIBE_BACKEND_URL` > `MCP_PORT` > `BACKEND_PORT` > `PORT` > port file
**Usage for Windows users with LAN access:**
```bash
HOST=0.0.0.0 MCP_HOST=127.0.0.1 pnpm run dev
```
The change is minimal (4 lines modified) and backwards compatible - existing setups without `MCP_HOST`/`MCP_PORT` work exactly as before.
* Done. I've added `MCP_HOST` and `MCP_PORT` to the Environment Variables table in the README with descriptions explaining their purpose and the Windows use case.
* Done. Added Zed remote SSH support using the `zed://ssh/` protocol URL format.
**Generated URL format**: `zed://ssh/{user}@{host}{path}`
Examples:
- `zed://ssh/192.168.1.10/home/user/.vimrc`
- `zed://ssh/brit@scepcy/home/brit/projects/scepsy/`
* Restored the comment.
* Done. Added Zed to the frontend condition so the remote SSH host/user fields now appear when Zed is selected as the editor.
* add antigravity as an option in settings
* use early return for zed case to remove extra match statement
Store the actual shell path in each UnixShell variant (as PathBuf)
instead of hardcoding /bin/* paths. Now when $SHELL is e.g.
/nix/store/.../zsh, the actual path is preserved and used.
Also filter fallback shells in get_fresh_path() to skip non-existent
paths on systems where /bin/* shells don't exist.
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
* All changes are complete. Here's a summary of what was changed:
## Summary of Changes
### `WorkspaceSummary.tsx`
1. **Title truncation**: Replaced `truncate` class with CSS mask gradient that fades to transparent (no ellipsis dots)
2. **Simplified hover actions**: Removed pin and archive buttons, keeping only the "more options" (ListIcon) button
3. **Removed sliding animation**: The action button now uses simple opacity transition (`opacity-0 group-hover:opacity-100`) instead of the sliding animation
4. **Removed unused code**: `handleArchive`, `handlePin` functions and `ArchiveIcon` import removed
5. **Removed unused props**: `onArchive` and `onPin` props removed from interface
### `WorkspacesSidebar.tsx`
- Removed `onArchiveWorkspace` and `onPinWorkspace` props from interface and destructuring
### `WorkspacesSidebarContainer.tsx`
- Removed `handleArchiveWorkspace` and `handlePinWorkspace` callbacks
- Removed unused imports (`useCallback`, `useActions`, `Actions`)
All type checks pass. The pin and archive functionality is still accessible through the command bar (more options button).
* Cleanup script changes for workspace 262a1c1d-87ae-40f5-a36d-f43758d18fed
* Done. Changed `ListIcon` to `DotsThreeIcon` with `weight="bold"` for the more options button.
* Done. Changed the icon size from `size-icon-xs` to `size-5` (20px) while keeping the bold weight.
* Done. Added the `ArchiveWorkspace` action to the left side of the navbar in `NavbarActionGroups.left`.
* The fix is in place. Let me summarize the changes made:
## Summary
Fixed the mobile preview browser by implementing automatic scaling when the phone frame doesn't fit in the container.
### Changes made:
**`frontend/src/components/ui-new/views/PreviewBrowser.tsx`:**
1. Exported constants `MOBILE_WIDTH`, `MOBILE_HEIGHT`, and `PHONE_FRAME_PADDING` for use in the container
2. Added `mobileScale` prop to the component interface
3. Changed the content area's overflow from always `overflow-auto` to `overflow-hidden` when in mobile mode (to prevent scrollbars when the scaled content is smaller)
4. Applied CSS `transform: scale()` to the phone frame when `mobileScale < 1`, using `origin-center` to scale from the center
**`frontend/src/components/ui-new/containers/PreviewBrowserContainer.tsx`:**
1. Imported `useLayoutEffect` and the exported constants from `PreviewBrowser`
2. Added `mobileScale` state that calculates the appropriate scale factor
3. Added a `useLayoutEffect` that:
- Only runs when in mobile mode
- Uses `ResizeObserver` to track container size changes
- Calculates scale based on available space vs. phone frame dimensions
- Never scales up (only down when needed)
4. Passes `mobileScale` prop to the `PreviewBrowser` component
The mobile preview will now automatically scale down to fit within the available container space, preventing the vertical cutoff issue.
* Cleanup script changes for workspace abe7b640-b3ea-4716-850e-6fd096ac1a3e
- `logs.searchLogs` - Placeholder text for the search input in the logs panel
- `logs.selectProcessToView` - Empty state message when no process is selected
- `processes.noProcesses` - Empty state message when no processes exist
- `search.matchCount` - Shows current match position (e.g., "1 of 5")
- `search.noMatches` - Shown when search has no results
All type checks pass (`pnpm run check` completed successfully).
* So `git-url-parse` can give us `owner()` and `repo()` through the provider. That's cleaner than manual string parsing.
Let me present the options to you:
**Option 1: `git-url-parse` crate**
- Pros: Specifically designed for git URLs, gives owner/repo directly via provider
- Cons: New dependency (though small)
**Option 2: `gix-url` crate**
- Pros: Part of gitoxide (well-maintained), robust parsing
- Cons: New dependency, still need to extract owner/repo from path
**Option 3: Keep current approach but improve it**
- Use the `url` crate we already have for HTTPS URLs
- Handle SSH URLs as a special case (they use `:` instead of `/`)
- Less string magic, more structured
**Option 4: Use `gh` CLI to parse**
- `gh repo view <url> --json owner,name`
- Pros: No new deps, `gh` handles all edge cases
- Cons: Requires network/auth, slower
Which approach would you prefer? I'd recommend **Option 1 (`git-url-parse`)** since it's purpose-built for this exact use case.
* Cleanup script changes for workspace a07fdbcf-0608-4a84-a012-53d4fee6d115
* Let me provide a summary of all the changes made:
## Summary
Fixed the hardcoded remote handling to support fork workflows. Here's what changed:
### 1. `crates/services/src/services/git.rs`
- **`default_remote_name()`**: Now prefers "origin" (git's convention) instead of arbitrarily picking the first remote
- **`get_remote_url()`**: New helper to get the URL of a specific remote by name
- **`get_remote_url_from_branch_or_default()`**: New helper that gets the remote URL for a branch, falling back to default remote
### 2. `crates/services/src/services/git/cli.rs`
- **`default_remote_name()`**: Same fix as above - prefers "origin"
- **`get_remote_url()`**: New method to get remote URL by name
### 3. `crates/services/src/services/git_host/github/cli.rs`
- **`get_repo_info_from_url()`**: New method that uses `gh repo view <url> --json owner,name` to parse owner/repo from a remote URL (no string magic!)
### 4. `crates/services/src/services/git_host/github/mod.rs`
- **`get_repo_info_from_url()`**: Async wrapper for the new CLI method
- **`create_pr()`**: Now uses `get_repo_info_from_url()` with the `remote_url` parameter to determine which repo to create the PR against
### 5. `crates/server/src/routes/task_attempts/pr.rs`
- **Key fix**: Now extracts the target remote URL from the `target_branch` (e.g., `upstream/main`) instead of from `workspace.branch` (your task branch)
- This enables fork workflows: push to your fork (`origin`), but create PR against upstream (the target branch's remote)
### How fork workflows now work:
1. User selects target branch like `upstream/main`
2. Code pushes task branch to `origin` (your fork)
3. Code extracts remote URL from `upstream` remote (the upstream repo)
4. PR is created against the upstream repo using `gh pr create --repo upstream-owner/repo`
* Cleanup script changes for workspace a07fdbcf-0608-4a84-a012-53d4fee6d115
* Build passes. The response structs are now at module level alongside the other `Gh*` response types, which is cleaner and more consistent with the existing code style.
* Build passes. Now `gh repo view <url>` is run from the repo directory, which helps with GitHub Enterprise authentication context.
* Done. Removed all the redundant comments.
* Build passes.
* Build passes. Now the default remote logic follows git's behavior:
1. Check `remote.pushDefault` config first (user's explicit preference)
2. Fall back to "origin" if it exists (git's convention from `git clone`)
3. Fall back to first remote if no "origin"
4. Default to "origin" if no remotes exist
* I've fixed the bug in `check_remote_branch_exists` at `git.rs:1454-1484`. The issue was that when checking if a remote branch exists, the function was:
1. Using `default_remote_name()` (which returns "origin") to strip the prefix from branch names like `upstream/main`
2. Looking up the URL from the default remote instead of the actual remote the branch belongs to
Now the function:
1. For remote branches (like `upstream/main`), extracts the actual remote name from the branch using `get_remote_name_from_branch_name()`
2. Strips the correct prefix (`upstream/` not `origin/`)
3. Uses the correct remote's URL for the `git ls-remote` check
This allows fork workflows where you select `upstream/main` as the target branch - it will now correctly check if `main` exists on the `upstream` remote's URL.
* Cleanup script changes for workspace a07fdbcf-0608-4a84-a012-53d4fee6d115
* Fix cross-fork PR creation by formatting head branch with fork owner
When creating a PR from a fork to upstream, GitHub requires the head branch
to be formatted as "owner:branch" (e.g., "LSRCT:vk/feature-branch").
Added head_repo_url to CreatePrRequest and updated GitHubProvider to
compare owners and prefix the head branch accordingly.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* Refactor PR remote handling: simplify by moving logic to caller
- Delete check_remote_branch_exists() from GitService (caller now composes
the check directly using GitCli)
- Add default_remote_name_for_path() convenience method
- Rewrite pr.rs remote handling to be explicit and linear:
1. Get push_remote and target_remote names
2. Get their URLs
3. Strip prefix to get base_branch
4. Check, push, create PR
The string split happens once, visibly at the call site.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* Remove origin preference in default_remote_name
Use first available remote instead of preferring "origin". The fallback
to "origin" only applies when there are no remotes configured at all.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* Fix PR creation when target branch not fetched locally
When the target branch doesn't exist as a local remote-tracking ref
(e.g., user types a branch name that exists on remote but isn't fetched),
fall back to using the push remote instead of failing with BranchNotFound.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* Reject cross-fork PRs for Azure DevOps
Azure DevOps fork PRs require different handling (--fork-id parameter).
Return a clear error instead of silently failing.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* Remove get_repo_info, always use explicit URL
The parameterless get_repo_info relied on gh CLI guessing the repo from
local git config. This is wrong for fork workflows where we need to
operate on a specific remote's repo. Now list_prs_for_branch and
get_pr_comments use the remote_url they're passed instead of ignoring it.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* Format git service default remote helper
* Fix clippy collapsible-if warnings
* Route remote branch checks through git service
* Remove Azure PR comment
* Consolidate git remote helpers
* Consolidate git remote resolution helpers
* Remove unnecessary comments
* Fix git service error match for remote check
* Remove unused GitCli::default_remote_name
GitService::default_remote_name (using git2) is used instead.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* Refactor unused vars
---------
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
* Done. I've updated both the Tags section and Files section in the typeahead plugin. The changes:
1. Added `border-l-2` to all items to create a left border
2. For selected items: `border-l-brand` (orange accent color) + `bg-muted` + `text-high`
3. For unselected items: `border-l-transparent` + `hover:bg-muted` + `text-muted-foreground`
4. Removed the redundant `text-foreground` class that was conflicting with `text-high`
The selected item now has a visible orange/brand-colored left border indicator that provides clear visual feedback in both light and dark modes.
* style
* perf: fix database query performance bottlenecks
- Add composite index on workspace_repos(workspace_id, repo_id) to optimize lookup queries that were taking up to 5 seconds
- Add composite index on merges(merge_type, pr_status) to optimize status filtering queries that were taking 2+ seconds
- Fix N+1 query pattern in workspace_repos.create_many by wrapping inserts in a transaction
- Fix N+1 query pattern in get_task_attempt_branch_status by batch fetching all merges upfront instead of querying per repo
These changes address significant performance bottlenecks identified in production logs where simple lookup queries were experiencing multi-second latencies.
* cargo fmt
* run sqlx prepare
---------
Co-authored-by: Solomon <abcpro11051@disroot.org>
* merge
* switch out panel lib
* fmt
* remove allotment dep
* bump lock
* The position of the react resizable panel is lost when the page is reloaded in (vibe-kanban 6ac32e23)
`WorkspacesLayout.tsx` , but should be stored in `useUiPreferencesStore.ts`
`vibe-kanban/frontend/src/components/ui-new/containers/WorkspacesLayout.tsx`
`vibe-kanban/frontend/src/stores/useUiPreferencesStore.ts`
* remove redundant type
* add dep
---------
Co-authored-by: Louis Knight-Webb <louis@bloop.ai>
* All type checks pass. Let me provide a summary of the changes made:
## Summary
I've added a "Repository settings" option to the Git panel dropdown in the Workspaces UI. Here are the changes made:
### 1. `frontend/src/components/ui-new/primitives/RepoCard.tsx`
- Added `DotsThreeIcon` and `GearIcon` imports from phosphor-icons
- Added `onOpenSettings?: () => void` prop to the `RepoCardProps` interface
- Changed the dropdown trigger icon from `ArrowSquareOutIcon` to `DotsThreeIcon` (three dots)
- Added a new dropdown menu item "Repository settings" with a gear icon that calls `onOpenSettings`
### 2. `frontend/src/components/ui-new/views/GitPanel.tsx`
- Added `onOpenSettings?: (repoId: string) => void` prop to the `GitPanelProps` interface
- Added `onOpenSettings` to the destructured props
- Passed `onOpenSettings` callback to each `RepoCard` component
### 3. `frontend/src/components/ui-new/containers/WorkspacesLayout.tsx`
- Added `useNavigate` import from react-router-dom
- Added `const navigate = useNavigate()` in `GitPanelContainer`
- Added `handleOpenSettings` callback that navigates to `/settings/repos?repoId=${repoId}`
- Passed `onOpenSettings={handleOpenSettings}` to the `GitPanel` component
### 4. `frontend/src/i18n/locales/en/common.json`
- Added `"repoSettings": "Repository settings"` translation under the `actions` section
* All checks pass:
- ✅ i18n check - Translation keys are consistent across all locales
- ✅ Linter - No lint errors
- ✅ TypeScript type check - No type errors
Fix parsing error where ESLint was trying to read tsconfig.json from root directory instead of frontend directory. Use path.join(__dirname, 'tsconfig.json') to ensure correct resolution.
- Added required deps: `react-compiler-runtime` + `babel-plugin-react-compiler` in `frontend/package.json:70` and `frontend/package.json:99`, plus `remote-frontend/package.json:20` and `remote-frontend/package.json:30` (lockfile updated in `pnpm-lock.yaml`).
## Problem
When multiple dev servers are running and the user switches between log tabs, logs from one dev server could appear in another dev server's tab. This happened because:
1. When `processId` changes (user switches tabs), the effect cleanup closes the old WebSocket
2. But WebSocket `close()` is asynchronous - the old WebSocket's event handlers can still fire
3. The old WebSocket's `onmessage` handler was still calling `setLogs()`, which would update the logs state even after switching to a different process
## Solution
Added a `currentProcessIdRef` ref to track the current active `processId`, and a `capturedProcessId` variable that captures the processId when each WebSocket is opened. All event handlers now check if their captured processId matches the current one before updating state:
1. **`onopen`**: Closes the WebSocket immediately if processId has changed since opening
2. **`addLogEntry`**: Discards log entries if they're from a stale WebSocket
3. **`onerror`**: Ignores errors from stale WebSocket connections
4. **`onclose`**: Prevents retry logic from running for stale connections
This ensures that each WebSocket connection only affects state when it's still the active connection for the currently selected process.
* The code compiles. The fix is complete. Here's a summary of what was changed:
**File: `crates/server/src/routes/containers.rs`**
1. Added `use uuid::Uuid;` import
2. Added `ContainerInfo` struct with `project_id`, `task_id`, and `attempt_id` fields
3. Added `get_container_info` handler that resolves the container reference and maps `workspace_id` → `attempt_id` for VSCode extension compatibility
4. Registered the `/containers/info` route
The VSCode extension can now call `GET /api/containers/info?ref={folder_path}` to auto-detect workspaces when opening a folder.
* Moved the doc comment to the route registration where it's more visible.
* Everything compiles. Let me summarize the logic:
**How the fix works:**
| Scenario | `container_ref` in DB | Path VSCode opens | Lookup method |
|----------|----------------------|-------------------|---------------|
| Multi-repo | `/workspaces/abc123` | `/workspaces/abc123` | Exact match ✓ |
| Single-repo | `/workspaces/abc123` | `/workspaces/abc123/my-repo` | Prefix match ✓ |
The `resolve_container_ref_by_prefix` method:
1. First tries exact match (handles multi-repo case)
2. Falls back to prefix match using SQLite GLOB: `path GLOB container_ref || '/*'` (handles single-repo case where path is a subfolder)
This should handle both cases correctly. The confidence is higher now because we've accounted for how "Open in IDE" behaves differently based on repo count.
* Everything compiles. Now the query handles both:
- Unix paths: `/workspaces/abc123/repo-name` matches `/workspaces/abc123` via `/*`
- Windows paths: `C:\workspaces\abc123\repo-name` matches `C:\workspaces\abc123` via `\*`
* Use std::path for cross-platform parent directory lookup
Instead of doing path prefix matching in SQL (which doesn't handle
Windows backslashes), we now:
1. Try exact match on the path
2. If not found, try the parent directory (handles single-repo case)
This uses std::path::Path::parent() which handles path separators
correctly on all platforms.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
* cleanup navbar
* re-enable dev server from command bar
* Add the ability to open the command bar from the `NavbarContainer.tsx` : (vibe-kanban 58189151)
- dots-three-outline icon
- position next to settings
`vibe-kanban/frontend/src/components/ui-new/containers/NavbarContainer.tsx`
* `NavbarContainer.tsx` button to go back to old UI should navigate back to task rather than attempt (vibe-kanban 2b6f4c76)
`index.ts`
`vibe-kanban/frontend/src/components/ui-new/containers/NavbarContainer.tsx`
`vibe-kanban/frontend/src/components/ui-new/actions/index.ts`
* Add new setting: beta\_workspaces, and beta\_workspaces\_invitation\_sent (vibe-kanban e2e73cb9)
- Stored in the `mod.rs`
- This defaults to 'false'
- If a user is considered an active user (they have created more than 50 task attempts), they should be proactively invited to join the beta of workspaces
- The invite will be displayed as dialog in the old UI, triggered when the user opens the `TaskAttemptPanel.tsx`
- The setting can be changed later in the `GeneralSettings.tsx` , right at the bottom in a section for beta features
- When the user has beta\_workspaces set to true:
- Previously when they open a task in the `TaskKanbanBoard.tsx` it would open a task attempt or task, now it will always open a task
- And when clicking on a task attempt in the `TaskPanel.tsx` it will open in the new workspaces view (/workspaces/[WORKSPACE\_ID])
`vibe-kanban/frontend/src/components/panels/TaskAttemptPanel.tsx`
`vibe-kanban/frontend/src/pages/settings/GeneralSettings.tsx`
`vibe-kanban/crates/services/src/services/config/mod.rs`
`vibe-kanban/frontend/src/components/tasks/TaskKanbanBoard.tsx`
`vibe-kanban/frontend/src/components/panels/TaskPanel.tsx`
* Introduce a way to give feedback (vibe-kanban 463fbf1d)
- Icon in `NavbarContainer.tsx` next to settings
- Also triggerable from command bar
- Using posthog client, already installed
`vibe-kanban/frontend/src/components/ui-new/containers/NavbarContainer.tsx`
* Create a new dialog that shows when users use workspaces (ui-new) for the first time. It should (vibe-kanban b0e8344a)
explain the features of workspaces. The component will consist of a popup with topics in a sidebar on the left and content (text and images) in a main section to the right. It does not use the existing Dialog component.
It is accessible by clicking a help icon in the `NavbarContainer.tsx` and from the command bar via `pages.ts`
Create the component and some seed content that I will edit:
1. Welcome to workspaces, here are some tips to get started
2. Use the command bar to navigate
3. Create workspaces in the sidebar, also view all your workspaces and the status of each here
4. Workspaces can be created with multiple repos
5. You can create multiple sessions for each workspace
6. Preview changes
7. View diffs, comment on them
8. If any any point you want to go back to the old UI, you can turn off workspaces in settings
`vibe-kanban/frontend/src/components/ui-new/containers/NavbarContainer.tsx`
`vibe-kanban/frontend/src/components/ui-new/actions/pages.ts`
* Update `WorkspacesGuideDialog.tsx` : (vibe-kanban b4c5d731)
- Make 600px height
- Add new section: Context Bar
> The context bar lets you switch between panes quickly. Drag it wherever works best for you.
`vibe-kanban/frontend/src/components/ui-new/dialogs/WorkspacesGuideDialog.tsx`
* The `WorkspacesGuideDialog.tsx` appears every time I reload the page, it doesn't seem that we're (vibe-kanban 7fd9e0c8)
saving that the user has already seen it once and it should no longer be auto shown
`vibe-kanban/frontend/src/components/ui-new/dialogs/WorkspacesGuideDialog.tsx`
* Please run `check-i18n.sh` and fix the issue (vibe-kanban d3323397)
`vibe-kanban/scripts/check-i18n.sh`
