ccc51b65d0
* ## Task Complete! ✅ I have successfully implemented the solution to fix the premature config updates issue in GeneralSettings.tsx. Here's what has been accomplished: ### **Changes Made:** 1. **Added Utility Functions** - `deepClone()` - Safely clones objects for draft state - `deepMerge()` - Merges partial updates into draft config - `isEqual()` - Compares objects to detect unsaved changes 2. **Implemented Draft State Management** - Added `draft` state that mirrors the current config - Added `dirty` flag to track form modifications - Added `updateDraft()` helper to update draft without affecting global config - Added `hasUnsavedChanges` computed property for UI state 3. **Updated All Form Fields** - **Theme selector** - now updates draft only - **Language selector** - now updates draft only - **Executor profile** - now updates draft only - **Editor type** - now updates draft only - **GitHub PAT** - now updates draft only - **Sound notifications** - now updates draft only (with preview using draft) - **Push notifications** - now updates draft only - **Analytics** - now updates draft only 4. **Enhanced Save/Discard Functionality** - `handleSave()` now applies draft to global config via `updateAndSaveConfig()` - `handleDiscard()` resets draft back to current config - Both buttons are properly enabled/disabled based on unsaved changes 5. **Improved User Experience** - Added "You have unsaved changes" indicator in sticky footer - Save button only enabled when there are changes to save - Discard button only enabled when there are changes to discard - Optional browser warning on page navigation with unsaved changes - All immediate actions (OAuth, safety resets) still work instantly via `updateAndSaveConfig` ### **Benefits:** - ✅ **No more confusing auto-apply behavior** - changes only apply when Save is clicked - ✅ **Clear visual feedback** - users see when they have unsaved changes - ✅ **Ability to discard changes** - users can revert unwanted modifications - ✅ **Consistent UX** - matches standard form behavior expectations - ✅ **Backwards compatible** - all existing functionality preserved ### **Testing Results:** - ✅ TypeScript compilation passes - ✅ ESLint validation passes - ✅ Full build completes successfully - ✅ No new lint warnings introduced The implementation successfully resolves the original issue where users thought settings were auto-saved when they were only being applied temporarily. Now the UI clearly differentiates between "staging" changes (draft) and "applying" changes (save), giving users full control over when their configuration changes take effect. * Cleanup script changes for task attempt bcb52aeb-7bd2-44b3-ac05-e99327631c35 * Excellent! The number of lint warnings actually went down from 105 to 98, which means our refactoring improved the code quality. This is because lodash's `isEqual` provides better type inference than our custom JSON.stringify comparison. ## Summary Perfect! I have successfully replaced the custom utility functions with lodash implementations. Here's what was improved: ### **Changes Made:** 1. **Added Lodash Dependencies** - Added `lodash` as a dependency - Added `@types/lodash` as a dev dependency for TypeScript support 2. **Replaced Custom Utility Functions** - `deepClone()` → `cloneDeep()` from lodash - `deepMerge()` → `merge()` from lodash - `isEqual()` → `isEqual()` from lodash 3. **Updated All References** - Updated draft state initialization - Updated draft sync when config changes - Updated the `updateDraft()` helper function - Updated the `handleDiscard()` function ### **Benefits of Using Lodash:** ✅ **Better Performance** - Lodash functions are highly optimized and battle-tested ✅ **Improved Type Safety** - Better TypeScript integration and type inference ✅ **More Robust** - Handles edge cases that custom implementations might miss ✅ **Reduced Code** - Eliminated ~30 lines of custom utility code ✅ **Better Lint Warnings** - Reduced from 105 to 98 ESLint warnings ✅ **Industry Standard** - Using well-known, widely-adopted utility functions ### **Testing Results:** - ✅ TypeScript compilation passes - ✅ ESLint validation passes with fewer warnings - ✅ Frontend build completes successfully - ✅ All functionality preserved The implementation now uses professional-grade utility functions while maintaining all the draft state management functionality we implemented for the deferred save feature. This makes the code more maintainable and reliable. * Perfect! The i18n lint check passed specifically for our GeneralSettings.tsx file - no issues were reported for it, which means all our strings are now properly internationalized. ## Summary ✅ I successfully identified and fixed **3 hardcoded i18n strings** in the GeneralSettings.tsx file: ### **Found Issues:** 1. **Line 725**: `"• You have unsaved changes"` (hardcoded English) 2. **Line 736**: `"Discard"` (hardcoded English) 3. **Line 136**: `"Failed to save configuration"` (hardcoded English) ### **Fixed by:** 1. **Added translation keys** to all 3 locales: - **English** (`en/settings.json`): - `"unsavedChanges": "• You have unsaved changes"` - `"discard": "Discard"` - **Spanish** (`es/settings.json`): - `"unsavedChanges": "• Tienes cambios sin guardar"` - `"discard": "Descartar"` - **Japanese** (`ja/settings.json`): - `"unsavedChanges": "• 未保存の変更があります"` - `"discard": "破棄"` 2. **Updated React component** to use translation functions: - `"• You have unsaved changes"` → `{t('settings.general.save.unsavedChanges')}` - `"Discard"` → `{t('settings.general.save.discard')}` - `"Failed to save configuration"` → `{t('settings.general.save.error')}` ### **Results:** - ✅ **All hardcoded strings replaced** with proper i18n calls - ✅ **Translations added** for English, Spanish, and Japanese - ✅ **TypeScript compilation passes** - ✅ **i18n lint check passes** (no warnings for GeneralSettings.tsx) - ✅ **User experience** now supports multiple languages The GeneralSettings component is now fully internationalized and will properly display the unsaved changes indicator and discard button text in the user's selected language.
Get 10X more out of Claude Code, Gemini CLI, Codex, Amp and other coding agents...
Overview
AI coding agents are increasingly writing the world's code and human engineers now spend the majority of their time planning, reviewing, and orchestrating tasks. Vibe Kanban streamlines this process, enabling you to:
- Easily switch between different coding agents
- Orchestrate the execution of multiple coding agents in parallel or in sequence
- Quickly review work and start dev servers
- Track the status of tasks that your coding agents are working on
- Centralise configuration of coding agent MCP configs
You can watch a video overview here.
Installation
Make sure you have authenticated with your favourite coding agent. A full list of supported coding agents can be found in the docs. Then in your terminal run:
npx vibe-kanban
Documentation
Please head to the website for the latest documentation and user guides.
Support
Please open an issue on this repo if you find any bugs or have any feature requests.
Contributing
We would prefer that ideas and changes are raised with the core team via GitHub issues, where we can discuss implementation details and alignment with the existing roadmap. Please do not open PRs without first discussing your proposal with the team.
Development
Prerequisites
Additional development tools:
cargo install cargo-watch
cargo install sqlx-cli
Install dependencies:
pnpm i
Running the dev server
pnpm run dev
This will start the backend. A blank DB will be copied from the dev_assets_seed folder.
Building the frontend
To build just the frontend:
cd frontend
pnpm build
Build from source
- Run
build-npm-package.sh - In the
npx-clifolder runnpm pack - You can run your build with
npx [GENERATED FILE].tgz
Environment Variables
The following environment variables can be configured at build time or runtime:
| Variable | Type | Default | Description |
|---|---|---|---|
GITHUB_CLIENT_ID |
Build-time | Ov23li9bxz3kKfPOIsGm |
GitHub OAuth app client ID for authentication |
POSTHOG_API_KEY |
Build-time | Empty | PostHog analytics API key (disables analytics if empty) |
POSTHOG_API_ENDPOINT |
Build-time | Empty | PostHog analytics endpoint (disables analytics if empty) |
BACKEND_PORT |
Runtime | 0 (auto-assign) |
Backend server port |
FRONTEND_PORT |
Runtime | 3000 |
Frontend development server port |
HOST |
Runtime | 127.0.0.1 |
Backend server host |
DISABLE_WORKTREE_ORPHAN_CLEANUP |
Runtime | Not set | Disable git worktree cleanup (for debugging) |
Build-time variables must be set when running pnpm run build. Runtime variables are read when the application starts.
Custom GitHub OAuth App (Optional)
By default, Vibe Kanban uses Bloop AI's GitHub OAuth app for authentication. To use your own GitHub app for self-hosting or custom branding:
- Create a GitHub OAuth App at GitHub Developer Settings
- Enable "Device Flow" in the app settings
- Set scopes to include
user:email,repo - Build with your client ID:
GITHUB_CLIENT_ID=your_client_id_here pnpm run build