* Perfect! Here's what I implemented:
I've added auto setup for adding the cursor-agent binary to the PATH. Here's what was done:
- Added a `ShellType` enum to represent bash and zsh shells
- Added a `detect_shell()` function that detects the user's current shell from the `$SHELL` environment variable
- Added a `config_file()` method on `ShellType` that returns the appropriate config file path (`~/.bashrc` for bash, `~/.zshrc` for zsh)
- Modified `get_setup_helper_action()` to use the new shell detection
- Added PATH configuration directly to the install script that:
- Detects the user's shell in Rust (not bash)
- Adds the export line to the appropriate shell config file
- Sources the config file to make the PATH available immediately in the current session
- Added `dirs = "5.0"` to reliably get the user's home directory
The implementation follows the pattern of doing shell detection in Rust (via `detect_shell()`) and keeping the bash script simpler, as requested. The PATH is now properly configured during the cursor-agent setup process.
Cleanup script changes for task attempt 4a4deda3-a27b-4635-9ab9-8aba961625f2
Done! I've simplified the implementation by:
1. **Removed the `ShellType` enum** - it was unnecessary complexity
2. **Created a simple `get_shell_config_file()` function** in `crates/utils/src/shell.rs` that:
- Detects the shell from the `$SHELL` environment variable
- Returns `~/.zshrc` for zsh, `~/.bashrc` for everything else
- Returns `None` if the home directory can't be determined
3. **Updated cursor_setup.rs** to use this straightforward function instead of the enum
The code is now simpler and more direct, while still doing exactly what's needed for the PATH setup.
Cleanup script changes for task attempt 4a4deda3-a27b-4635-9ab9-8aba961625f2
All set! The changes have been applied and verified.
Perfect! The code compiles. Now the login script sources the config file before calling `cursor-agent login`, so the PATH will be properly set when the login command runs.
* Fix cursor login and path refresh
* ## Problem Analysis
The workflow runs `cargo set-version` (line 103) which updates Cargo.lock, but the git commit (lines 113-114) doesn't stage Cargo.lock—only the package.json files and Cargo.toml files.
## Proposed Fix
**Simplest approach:** Add `Cargo.lock` to line 113:
```yaml
git add package.json pnpm-lock.yaml npx-cli/package.json frontend/package.json Cargo.lock
git add $(find . -name Cargo.toml)
```
**Optional enhancement:** Run `cargo generate-lockfile` after `cargo set-version` (line 103) to ensure the lockfile is fully regenerated.
The Oracle confirmed this is correct. Ready to proceed?
* Done! I've fixed the pre-release workflow by:
1. Adding `Cargo.lock` to the `git add` command (line 113)
2. Adding `cargo generate-lockfile` after `cargo set-version` (line 104) to ensure the lockfile is properly regenerated
This ensures Cargo.lock gets committed with all the version changes.
* Done! Removed the `cargo generate-lockfile` line.
* Lock mac-notification-sys on v0.6.6
While waiting for the macOS linker fix to be released 7798ad033f/build.rs (L26)
* Commit a working Cargo.lock instead
