daonanchao/vibe-kanban
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Pre release doesn't update lockfile (Vibe Kanban) (#1123)

Browse Source 
* ## Problem Analysis

The workflow runs `cargo set-version` (line 103) which updates Cargo.lock, but the git commit (lines 113-114) doesn't stage Cargo.lock—only the package.json files and Cargo.toml files.

## Proposed Fix

**Simplest approach:** Add `Cargo.lock` to line 113:

```yaml
git add package.json pnpm-lock.yaml npx-cli/package.json frontend/package.json Cargo.lock
git add $(find . -name Cargo.toml)
```

**Optional enhancement:** Run `cargo generate-lockfile` after `cargo set-version` (line 103) to ensure the lockfile is fully regenerated.

The Oracle confirmed this is correct. Ready to proceed?

* Done! I've fixed the pre-release workflow by:

1. Adding `Cargo.lock` to the `git add` command (line 113)
2. Adding `cargo generate-lockfile` after `cargo set-version` (line 104) to ensure the lockfile is properly regenerated

This ensures Cargo.lock gets committed with all the version changes.

* Done! Removed the `cargo generate-lockfile` line.
This commit is contained in:
Louis Knight-Webb
2025-10-29 14:55:56 +00:00
committed by GitHub
parent 5805ab9fc9
commit 0e2653a2c3
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
Cargo.lock generated
View File

@@ -933,7 +933,7 @@ checksum = "2a2330da5de22e8a3cb63252ce2abb30116bf5265e89c0e01bc17015ce30a476"
[[package]]
name = "db"
version = "0.0.112"
version = "0.0.113"
dependencies = [
"anyhow",
"async-trait",
@@ -969,7 +969,7 @@ dependencies = [
[[package]]
name = "deployment"
version = "0.0.112"
version = "0.0.113"
dependencies = [
"anyhow",
"async-trait",
@@ -1261,7 +1261,7 @@ dependencies = [
[[package]]
name = "executors"
version = "0.0.112"
version = "0.0.113"
dependencies = [
"agent-client-protocol",
"async-trait",
@@ -2406,7 +2406,7 @@ dependencies = [
[[package]]
name = "local-deployment"
version = "0.0.112"
version = "0.0.113"
dependencies = [
"anyhow",
"async-stream",
@@ -4013,7 +4013,7 @@ dependencies = [
[[package]]
name = "server"
version = "0.0.112"
version = "0.0.113"
dependencies = [
"anyhow",
"async-trait",
@@ -4059,7 +4059,7 @@ dependencies = [
[[package]]
name = "services"
version = "0.0.112"
version = "0.0.113"
dependencies = [
"anyhow",
"async-trait",
@@ -5234,7 +5234,7 @@ checksum = "b6c140620e7ffbb22c2dee59cafe6084a59b5ffc27a8859a5f0d494b5d52b6be"
[[package]]
name = "utils"
version = "0.0.112"
version = "0.0.113"
dependencies = [
"async-stream",
"axum",