* Done! I've implemented the "Copy all process logs" button for the `ViewProcessesDialog`. Here's a summary of the changes:
**Files modified:**
1. **`ProcessLogsViewer.tsx`** - Added `onLogsChange` callback prop and exported the `LogEntry` type
2. **`ProcessesTab.tsx`** - Added `onLogsChange` prop that passes through to ProcessLogsViewer, and clears logs when no process is selected
3. **`ViewProcessesDialog.tsx`** - Added the copy button with:
- State management for logs and copied feedback
- Copy button in the dialog header (right-aligned)
- Tooltip showing "Copy logs" / "Copied!"
- Button disabled when no logs are available
- Uses `Copy`/`Check` icons from lucide-react
4. **i18n files** (en, es, ko, ja) - Added translation keys:
- `copyLogs`: "Copy logs"
- `logsCopied`: "Copied!"
**Behavior:**
- The copy button appears in the dialog header next to the title
- When clicked, it copies all log content (joined by newlines) to clipboard
- Shows a checkmark icon for 2 seconds after successful copy
- Button is disabled when viewing the process list (no logs selected)
* Cleanup script changes for task attempt 2060681f-e4c3-46a7-aca3-3e9705b53248
* Fixed! I wrapped the `Tooltip` component in `TooltipProvider` as required by shadcn/ui. The error should now be resolved - the copy button should work properly.
* Done! I've made the following changes:
1. Removed the `Tooltip`, `TooltipProvider`, `TooltipContent`, and `TooltipTrigger` components
2. Added `mr-8` margin to position the button left of the dialog's native close button
3. Added `text-green-500` to the `Check` icon for green success feedback
The button should now be properly positioned and show a green checkmark when logs are copied.
* Done! Changed `text-green-500` to `text-success` so the check icon uses the theme's success color instead of a hardcoded green.
* Done! I've fixed the vertical alignment by:
1. Moving the button outside the `DialogHeader` and positioning it absolutely
2. Using `absolute right-12 top-4` to place it exactly to the left of the close button (which is at `right-4 top-4`)
3. Using `h-4 w-4` to match the close button's icon size
4. Added `rounded-sm opacity-70 hover:opacity-100` to match the close button's styling
The copy button should now be perfectly aligned with the close button.
* Done! I've moved the copy button to `ProcessesTab` next to the "Back to list" button. The changes:
1. **Removed** the absolute-positioned icon button from `ViewProcessesDialog`
2. **Added** a text button "Copy logs" / "Copied!" in `ProcessesTab` next to "Back to list"
3. **Moved** the i18n keys from `viewProcessesDialog` to `processes` section
4. The button uses the same styling as the "Back to list" button for consistency
5. Shows green "Copied!" text for 2 seconds after successful copy
* Done! I've made the following changes to address the review comment:
1. **`ProcessLogsViewer.tsx`**: Removed the `export` keyword from `LogEntry` type - it's now internal to the file
2. **`ProcessesTab.tsx`**: Changed import from `LogEntry` to `PatchType` from `shared/types`, and updated the state and callback types accordingly
The type check passes successfully.
* Done! I've addressed the review comment by:
1. **Lifted `useLogStream` to `ProcessesTab`** - Now `ProcessesTab` calls `useLogStream(selectedProcess?.id ?? '')` directly, giving it direct access to the logs for the copy button
2. **Removed the hacky `onLogsChange` callback** - No more `useEffect` to propagate logs up via callback
3. **Using `ProcessLogsViewerContent` directly** - `ProcessesTab` now imports and uses `ProcessLogsViewerContent` with the logs from `useLogStream`
4. **Kept `ProcessLogsViewer` as a simpler component** - The default export still exists for other potential consumers, but it's now a simple wrapper without the callback prop
The data flow is now cleaner:
- `ProcessesTab` owns the log data via `useLogStream`
- `ProcessLogsViewerContent` is a pure presentation component
- No callback prop threading needed
* Done! I've added proper translations for the i18n keys:
- **Spanish (es):** "Copiar registros" / "¡Copiado!"
- **Korean (ko):** "로그 복사" / "복사됨!"
- **Japanese (ja):** "ログをコピー" / "コピーしました！"
* I have bumped the `amp` version to `0.0.1764705684-g95eb77` in [crates/executors/src/executors/amp.rs](file:///private/var/folders/fr/0c4ky3392mb4yz5knw_wjdd00000gn/T/vibe-kanban/worktrees/5070-bump-amp/crates/executors/src/executors/amp.rs).
I verified the changes by running `cargo check --workspace`, which passed successfully.
* I have updated the `amp` version to `0.0.1764777697-g907e30` in [crates/executors/src/executors/amp.rs](file:///private/var/folders/fr/0c4ky3392mb4yz5knw_wjdd00000gn/T/vibe-kanban/worktrees/5070-bump-amp/crates/executors/src/executors/amp.rs).
I verified the changes by running `cargo check --workspace` (after resolving a transient `libsqlite3-sys` build issue).
**Summary**: Added a single guard condition to the `useEffect` that syncs `localMessage` from scratch data. When `isTextareaFocused` is true, the effect now returns early, preventing the cursor jump issue caused by the WebSocket sync overwriting the local message while the user is actively typing.
**Changes made:**
- Button backgrounds: `bg-foreground` → `bg-muted`
- Icon colors: `text-background` → `text-muted-foreground`
- Check icon (copied state): `text-green-600` → `text-success`
These semantic colors will now adapt correctly to both light and dark modes, following the established patterns in the codebase.
```
M crates/remote/scripts/prepare-db.sh
```
The changes in `crates/remote/scripts/prepare-db.sh` are pre-existing in this worktree, not something I introduced. My only change was to `crates/remote/src/db/organizations.rs`.
Should I revert that file to clean up the branch, or is that a separate change you were working on?
* Disable OAuth account deduplication by email
We intend to add explicit OAuth account linking in the future to replace this issue.
* remove unused function find_user_by_email
* WIP - Migrate task sharing to ElectricSQL + Tanstack DB
* WIP auth proxy
* Simplify electric host
* Electric token
Only set in cloud. Acts like a DB password.
* Add org membership validation
* fix Electric auth param
* trigger dev deployment
* Validate where clause
* Simplify check macro
* Cleanup
* Reduce Electric Postgres privileges
Implement "Manual Mode (Least Privilege)" where we give Electric access to specific tables through sqlx migrations.
https://electric-sql.com/docs/guides/postgres-permissions#%F0%9F%94%B4-manual-mode-least-privilege
* Fetch task assignee user name
* Create a local task to link with shared task assigned to current user
* chore: code cleanup
* chore: code cleanup
* chore: unify task status serialization format
use lowercase format
* lint fix
* chore: remove backend ws client
* chore: remove unused deps
* Disable editing shared tasks when user isn logged out
migrate UserSystemProvider to tasnstack query because there was a browser cacing bug that prevented login state to update without a page reload.
* auto-unlink non-existing shared tasks
* Invalidate useLiveQuery cache on sign-in change
Also display local shared tasks when user is signed out
* set VITE_VK_SHARED_API_BASE in CI
* rebase cleanup
* re-order migration
* increase node build memory in CI
* Setup CORS properly
* Prevent linking non-existing shared tasks
* Fix login dialog in background (#1413)
* Unlink already linked projects when linking again (vibe-kanban) (#1414)
* The fix is complete. Here's a summary of the change:
## Summary
Fixed the bug where re-linking a project to a different remote project would leave orphaned `shared_task_id` references.
**File modified:** `crates/server/src/routes/projects.rs:167-208`
**Change:** The `apply_remote_project_link` function now:
1. Fetches the existing project to check if it's already linked
2. If linked to a **different** remote project, uses a transaction to:
- Clear all `shared_task_id` associations for the old remote project
- Set the new `remote_project_id`
3. If no existing link, sets the new link directly
4. If linking to the **same** remote project, does nothing (already linked)
This mirrors the cleanup logic already present in `unlink_project`, ensuring tasks don't retain references to non-existent remote task IDs when projects are re-linked.
* You're right, let me think more carefully about the transaction.
Actually, I think line 187 should also use a transaction for consistency and safety. Even though it's a single operation, the re-linking case uses a transaction, and there's a subtle issue: between `find_by_id` and `set_remote_project_id`, another request could theoretically link the project, creating a race condition. Using a transaction would provide row-level locking.
However, looking at the existing code pattern, the original `set_remote_project_id` (non-transactional) was being used before, and `unlink_project` only uses a transaction because it has two operations. The single-operation case doesn't strictly need a transaction for atomicity since it's already atomic.
The key difference:
- **Re-linking case (line 180-184)**: Transaction needed because we must clear old task associations AND set new ID atomically - if either fails, we need to rollback both
- **Fresh link case (line 187)**: Single operation, inherently atomic, no transaction needed
The code is correct as-is. Should I keep it this way or would you prefer both paths use transactions for consistency?
* Done. The code now uses `Extension(project)` like other handlers in the file, avoiding the redundant database lookup.
* Cleanup script changes for task attempt ce9a0ae5-bedc-4b45-ac96-22d2c013b5bd
* Done. Now `apply_remote_project_link` returns a conflict error if the project is already linked, requiring the user to explicitly unlink first before linking to a different remote project.
* Both pass. Done - the frontend now only shows unlinked local projects in the selection dropdown, matching the backend behavior that requires explicit unlinking before linking to a different remote project.
* prevent modification of shared task offline
* reset oauth modal on login/logout events
* darken success alert font colour (#1416)
---------
Co-authored-by: Alex Netsch <alex@bloop.ai>
Co-authored-by: Louis Knight-Webb <louis@bloop.ai>
Co-authored-by: Gabriel Gordon-Hall <gabriel@bloop.ai>
* fix: No conversation found with session ID issue
Load session id after session is initialized.
* fmt
* claude: ignore session from message fragments
* fix tests
* Replace follow up section with WYSIWYG (vibe-kanban 55b58b24)
frontend/src/components/tasks/TaskFollowUpSection.tsx
frontend/src/components/ui/wysiwyg.tsx
* Delete all usage of image chip component (vibe-kanban 5c90eac1)
frontend/src/components/ui/wysiwyg/image-chip-markdown.ts
frontend/src/components/ui/wysiwyg/image-chip-node.tsx
* Trigger file / tag picker from WYSIWYG (vibe-kanban 3e73cf53)
LexicalTypeaheadMenuPlugin
frontend/src/components/ui/wysiwyg.tsx
frontend/src/components/ui/file-search-textarea.tsx (old)
* Editor state should be saved as JSON (vibe-kanban 4f9eec74)
Instead of saving markdown, we should save JSON eg `editorState.toJSON();`.
This will enable us to properly serialize custom Elements in the future.
frontend/src/components/ui/wysiwyg.tsx
frontend/src/components/tasks/follow-up/FollowUpEditorCard.tsx
* In WYSIWYG, the search dialog can exceed screen (vibe-kanban 25337029)
When searching for tags/files. Sometimes the dialog is cut off the bottom of the screen.
frontend/src/components/ui/wysiwyg.tsx
* Use WYSIWYG for tasks (vibe-kanban 5485d481)
Currently used for follow ups, we should also use for task
frontend/src/components/tasks/follow-up/FollowUpEditorCard.tsx
frontend/src/components/dialogs/tasks/TaskFormDialog.tsx
frontend/src/components/ui/wysiwyg.tsx
* Keyboard shortcuts when typing in WYSIWYG (vibe-kanban 04bd70bc)
We used to have a callback for:
- CMD+Enter
- Shift+CMD+Enter
In create task dialog:
- CMD+Enter = create and start
- Shift+CMD+Enter = create without start
In follow up:
- CMD+Enter = Follow up
- Shift+CMD+Enter = nothing
frontend/src/components/tasks/follow-up/FollowUpEditorCard.tsx
frontend/src/components/ui/wysiwyg.tsx
frontend/src/components/dialogs/tasks/TaskFormDialog.tsx
Ideally we can use the relevant Lexical plugin and callbacks, cleaning up the old `@/keyboard` hooks which no longer work.
* Trigger file / tag picker from WYSIWYG (vibe-kanban 3e73cf53)
LexicalTypeaheadMenuPlugin
frontend/src/components/ui/wysiwyg.tsx
frontend/src/components/ui/file-search-textarea.tsx (old)
* Use WYSIWYG for tasks (vibe-kanban 5485d481)
Currently used for follow ups, we should also use for task
frontend/src/components/tasks/follow-up/FollowUpEditorCard.tsx
frontend/src/components/dialogs/tasks/TaskFormDialog.tsx
frontend/src/components/ui/wysiwyg.tsx
* Introduce new user-message table and struct (vibe-kanban 09116513)
{
ID,
message_json: Value,
message_md: String
}
We'll also need some endpoints to CRUD them.
crates/db
crates/server
* Stream individual scratch (vibe-kanban 321b50a1)
crates/server/src/routes/scratch.rs
It should be possible to listen for updates made to a single scratch
* Refactor useScratch (vibe-kanban 51ea2317)
To consolidate the API stuff into frontend/src/lib/api.ts
* Update scratch API (vibe-kanban 878f40c5)
Primary key should come from: ID and scratch type combination
The frontend will provide both.
Scratch IDs should not be generated on the backend.
* Remove all usage of hook from follow up (vibe-kanban 2d691095)
Use of hooks that reside in frontend/src/hooks/follow-up/* should be removed, except for frontend/src/hooks/follow-up/useFollowUpSend.ts
From: frontend/src/components/tasks/TaskFollowUpSection.tsx
* Task follow up should use scratch (vibe-kanban d37d3b18)
The current task attempt ID should be used to save the content of the follow up box as scratch.
frontend/src/components/tasks/TaskFollowUpSection.tsx
* Use just markdown serialization for scratch (vibe-kanban 42f5507f)
frontend/src/hooks/useScratch.ts
crates/server/src/routes/scratch.rs
crates/db/src/models/scratch.rs
We are currently storing JSON + MD, however we should now store just MD and import/export the markdown into lexical.
* Consolidate MarkdownRenderer and WYSIWYG (vibe-kanban f61a7d40)
Currently we have an old implementation of markdown rendering in frontend/src/components/ui/markdown-renderer.tsx
But we have recently introduced the new WYSIWYG editor frontend/src/components/ui/wysiwyg.tsx
wysiwyg takes JSON as input, not raw markdown.
Ideally we could just use a single component and have a read only mode, removing Markdown Renderer and its dependencies and custom styling.
* WYSIWYG images (vibe-kanban 8cc3c0e7)
Create a Lexical plugin for images, with markdown import/export support.
Visually, images should be displayed as a small thumbnail with the path truncated.
Export/import should support standard markdown image format.
* Get image metadata endpoint (vibe-kanban 2c0dfbff)
Task attempt endpoint to get info, given the relative URL of an image.
We will also need an image that acts as a proxy to the file.
Info to return:
- Whether file exists
- Size of image
- Format
- File name
- Path
- URL to get image (the proxy URL)
The images are stored in the `.vibe-images` folder, relative to the task attempt container.
crates/server/src/routes/task_attempts.rs
* Inject relative path not absolute to image (vibe-kanban 007d589b)
Currently when we upload an image, it adds markdown with the full relative path of the image, eg:
/var/folders/m1/9q_ct1913z10v6wbnv54j25r0000gn/T/vibe-kanban-dev/worktrees/2702-testing-images/.vibe-images/b01e6b02-dbd0-464c-aa9f-a42a89f6d67b.png
However, we should change this to be the path relative to the worktree eg .vibe-images/b01e6b02-dbd0-464c-aa9f-a42a89f6d67b.png
* Improve image in WYSIWYG (vibe-kanban 53de9071)
frontend/src/components/ui/wysiwyg/nodes/image-node.tsx
Check if the image comes from `./vibe-images/...`, if so:
Use the API endpoints to get and display metadata.
Use the image proxy to display the thumbnail image.
Do not render non `.vibe-images` images, instead just show the path and show a question icon as a thumbnail.
* rebase fixes
* Add Lexical toolbar (vibe-kanban b8904ad9)
frontend/src/components/ui/wysiwyg.tsx
* Clicking image once should open dialog (vibe-kanban aab2e6f4)
frontend/src/components/ui/wysiwyg/nodes/image-node.tsx
* Style quotes better (vibe-kanban 54718e76)
frontend/src/components/ui/wysiwyg.tsx
* Auto detect multi-line code blocks (vibe-kanban ce33792d)
Currently when I type triple backticks it doesn't create a multi-line code block
frontend/src/components/ui/wysiwyg.tsx
* Update how image upload works on the backend (vibe-kanban 62d97322)
I am only referring to the image upload for sending a follow up message.
Currently we:
- upload an image
- when a follow up is made, send file IDs
- copy the image into container based on those file IDs
We should tweak this so that:
- upload an image
- immediately the image is copied into container
- the image file location is added to the markdown of the follow up message (on the frontend)
- when user makes follow up, the image is already in the container
crates/server/src/routes/images.rs
crates/server/src/routes/task_attempts/images.rs
* Use @lexical/code to render code (vibe-kanban 60605a2c)
frontend/src/components/ui/wysiwyg.tsx
* Save variant in scratch (vibe-kanban 06e1e255)
frontend/src/components/tasks/TaskFollowUpSection.tsx
* prepare db
* Solve follow up loading when empty (vibe-kanban 1991bf3d)
frontend/src/components/tasks/TaskFollowUpSection.tsx
Currently the loader shows when the scratch data is loading, but also when there is no scratch data - which means the user can never see the follow up inputs
* descriptive scratch error
* Triple backtick WYSIWYG not working properly (vibe-kanban 30b0114e)
When I paste in a multi-line code block, eg
```js
var x = 100;
```
It doesn't add a multi-line code block properly, instead it created two multi-line code blocks above and below the code.
frontend/src/components/ui/wysiwyg.tsx
* Safe scratch fail (vibe-kanban c3f99b37)
It's possible to get an error like:
scratch WS closed: Failed to get scratch item: invalid type: string "\\`\\`\\`js\n\nvar x = 100;\n\n\\`\\`\\` \n\n\n", expected struct DraftFollowUpData at line 1 column 49
In this situation the websocket should act in the same way when no scratch exists yet.
* Remove drafts (vibe-kanban 0af2e9aa)
crates/services/src/services/drafts.rs
crates/db/src/models/draft.rs
* Cleanup scratch (vibe-kanban 0baf9b69)
Remove:
- frontend/src/pages/TestScratch.tsx
- frontend/src/components/ScratchEditor.tsx
* Improve styling of WYSIWYG + attachment (vibe-kanban 042a18da)
frontend/src/components/ui/wysiwyg.tsx
The placeholder can overlap the attachment icon
* Introduce queued message service (vibe-kanban 442164ae)
- New service (crates/services/src/services/...) that holds an in memory store
- When the final executor_action finishes, if another follow up prompt (scratch ID) is queued then we can automatically begin executing it (crates/local-deployment/src/container.rs after finalize)
- New endpoint required to modify the queue for a task attempt.
- Scratch should be wiped after the execution process is created
- Scratch can't be edited while queued
- Add button to TaskFollowUpSection to make current scratch queued, or cancel queued item
* prepare db
* Follow up box does not reset after sending message (vibe-kanban c032bc21)
- Type follow up
- Press send
- Expect follow up to be reset, but it is not
frontend/src/components/tasks/TaskFollowUpSection.tsx
* bg
* Fix i18n (vibe-kanban a7ee5604)
i18next::translator: missingKey en-GB tasks followUp.queue Queue
* Reduce re-renders (vibe-kanban 86ec1b47)
frontend/src/components/ui/wysiwyg.tsx
frontend/src/components/tasks/TaskFollowUpSection.tsx
* Speed up button transitions (vibe-kanban be499249)
It takes 0.5-1s for the send button to go from no opacity to full opacity after I start typing
frontend/src/components/tasks/TaskFollowUpSection.tsx
* add icon to variant selection (vibe-kanban 92fca0e6)
frontend/src/components/tasks/TaskFollowUpSection.tsx
Dropdown should have settings-2
* Queued message functionality (vibe-kanban 21c7a725)
Say I have two messages to send:
- I send first
- I queue the second
- I now see "message queued" and the follow up editable text contains the second
- First finishes, second starts, no tasks are queued
- I still see "message queued" box but the follow up editable text gets wiped
frontend/src/components/tasks/TaskFollowUpSection.tsx
* variant width adjust
* Move the attach button (vibe-kanban b7f89e6e)
Attach button should be to the left of of the send button
frontend/src/components/ui/wysiwyg.tsx
frontend/src/components/tasks/TaskFollowUpSection.tsx
* Cleanup WYSIWYG (vibe-kanban 62997d6c)
Props, and upstream logic:
- make placeholder optional:
- remove defaultValue: this seems redundant as value is always controlled, there may also be related cleanups for uncontrolled mode
- remove onFocusChange: toggling states is unnecessary here
- remove enableCopyButton: this is always enabled when the editor is disabled
frontend/src/components/ui/wysiwyg.tsx
* cleanup scratch types
* further scratch cleanup
* Tweak queue (vibe-kanban 642aa7be)
If a task is stopped or fails, the next queued task runs, however this is not the desired behaviour. Instead the queued task should be removed from the queue
* Can't see attach button and queue at the same time (vibe-kanban 75ca5428)
frontend/src/components/tasks/TaskFollowUpSection.tsx
* move follow up hooks
* WYSIWYG code blocks should scroll horizontally (vibe-kanban 6c5dbc99)
frontend/src/components/ui/wysiwyg.tsx
* Refactor useDefaultVariant (vibe-kanban 10ec12ec)
I think we could change this so that it accepts a default variant and then returns what variant is currently selected, based on the user's preferences and if they select one from the dropdown
* Can't retry a task (vibe-kanban dfde6ad8)
It seems to retry functionality was removed fromfrontend/src/components/NormalizedConversation/UserMessage.tsx
* If execution startup is slow, scratch is not reset (vibe-kanban 6e721b8e)
frontend/src/components/tasks/TaskFollowUpSection.tsx
If you write out a follow up and then hit send, if you then navigate away from the page quickly the scratch will still be present when you visit the page, when the expected behaviour is that the previous text would be cleared
* Code highlighting for inline code block (vibe-kanban 956f1d5c)
Currently works for multi-line, can we get it working for multi-line
frontend/src/components/ui/wysiwyg.tsx
* Delete FileSearchTextArea (vibe-kanban 01107879)
Replace with frontend/src/components/ui/wysiwyg.tsx
not frontend/src/components/ui/file-search-textarea.tsx
* Tweak styles in task dialog (vibe-kanban 8dfe95a9)
frontend/src/components/dialogs/tasks/TaskFormDialog.tsx
- Placeholder for WYSIWYG too small, just use default
- Make title same size as WYSIWYG H1
* Refactor retry to use variant hook (vibe-kanban 69c969c9)
frontend/src/hooks/useVariant.ts
frontend/src/components/NormalizedConversation/RetryEditorInline.tsx
frontend/src/contexts/RetryUiContext.tsx
Removing all existing logic related to variant picking
* Refactor approval message styles (vibe-kanban b9a905e1)
Refactor the WYSIWYG implementation in thefrontend/src/components/NormalizedConversation/PendingApprovalEntry.tsx so the styles align with usage infrontend/src/components/tasks/TaskFollowUpSection.tsx
* Fix follow up box font (vibe-kanban 4fa9cd39)
When I start typing, it's a really small font for some reason
frontend/src/components/tasks/TaskFollowUpSection.tsx
* Remove double border for plan approval (vibe-kanban 3f12c591)
frontend/src/components/NormalizedConversation/PendingApprovalEntry.tsx
- Also multi-line code block colour is broken when looking at plans (but not single line strangely...)
* Retry Editor shouldn't call API directly (vibe-kanban 3df9cde5)
Should use hooks frontend/src/components/NormalizedConversation/RetryEditorInline.tsx
* Image metadata for task creation (vibe-kanban 8dd18a28)
We have an endpoint for image metadata in task attempt, but not for task
crates/server/src/routes/images.rs
This means we can't currently render the image (and metadata) in the WYSIWYG editorfrontend/src/components/dialogs/tasks/TaskFormDialog.tsx
* Add file upload to retry (vibe-kanban 8dffeed2)
frontend/src/components/NormalizedConversation/RetryEditorInline.tsx
Similar to:
frontend/src/components/tasks/TaskFollowUpSection.tsx
Infact we should reuse the same component as much as possible
* Remove the client side scratch deletion (vibe-kanban c6b0a613)
frontend/src/components/tasks/TaskFollowUpSection.tsx
This happens now on backend.
Also on backend when queued task is triggered we should also wipe the scratch.
* Queued task style (vibe-kanban 0c9bc110)
frontend/src/components/tasks/TaskFollowUpSection.tsx
When a message is queued it repeats the message under "will execute when current run finishes", however the message is visible anyway in the message box so we can remove that
* WYSIWYG base font size decrease
* Queueing a message change (vibe-kanban 30ee2d4d)
Currently when we queue a message I can see in the logs: Failed to save follow-up draft ApiError: Cannot edit scratch while a message is queued
I think this is because the following is happening:
- User types
- Clicks queue
- Debounce tries to save message
- Can't save message because of queue
**Summary:** Added CMD+Enter keyboard shortcut to the CreateAttemptDialog by:
1. Importing `useKeySubmitTask` and `Scope` from `@/keyboard`
2. Adding the `useKeySubmitTask` hook that calls `handleCreate` when:
- The dialog is visible (`modal.visible`)
- Creation is allowed (`canCreate` - profile and branch selected, not loading, not already creating)
This follows the same pattern used in other dialogs like `RestoreLogsDialog.tsx`.
1. **`worktree_manager.rs:112`**: Changed "Worktree already properly set up at path" from `debug!` to `trace!`
2. **`path.rs:9`**: Changed "Making path relative" from `tracing::debug!` to `tracing::trace!`
3. **`path.rs:21`**: Changed "Successfully made relative" from `tracing::debug!` to `tracing::trace!` (this is the successful outcome of the path relative operation, also routine)
These are the routine activity logs that fire frequently during normal operation. The other debug logs in these files are either on error/fallback paths or log less frequent events that are more useful for debugging.
OAuth tokens are revoked when the user revoke access to the OAuth app from the provider settings.
Some OAuth providers also revoke OAuth tokens when the user changes password.
keyboard shortcuts to navigate the kanban board.
In kanban boards with many tasks in a single column, when we use
keyboard shortcuts to select a task 'below the fold', the animation
restarts from the top of the kanban board, rather than preserving the
existing position.
* I have explored the codebase and confirmed that the GitHub integration now relies on the `gh` CLI instead of a Personal Access Token (PAT) configured in the settings. The setup process is "just-in-time", prompting the user to install or authenticate the CLI when they attempt to create a Pull Request.
I have updated the documentation to reflect these changes:
1. **`docs/integrations/github-integration.mdx`**: Rewrote the guide to explain the CLI-based workflow, including automatic setup on macOS and manual setup instructions for other platforms, as well as troubleshooting steps.
2. **`docs/getting-started.mdx`**: Updated the installation steps to remove the instruction to "Connect to GitHub in Settings" and instead mention the `gh` CLI requirement.
3. **`docs/configuration-customisation/global-settings.mdx`**: Removed the "GitHub Integration" section (since it no longer exists in Global Settings) and replaced it with a "Git Configuration" section describing the "Branch Prefix" setting, which is present in the UI.
I also verified that `docs/core-features/completing-a-task.mdx` remains accurate with the new workflow.
No images were needed as the process is now primarily CLI-driven or standard dialog-based, and I removed the outdated screenshots from the documentation files.
I ran `pnpm run check` to ensure no regressions were introduced, and it passed successfully.
### Summary of Changes
| File | Change |
| :--- | :--- |
| `docs/integrations/github-integration.mdx` | Rewritten to document `gh` CLI usage and troubleshooting |
| `docs/getting-started.mdx` | Removed outdated "Connect GitHub" step; added CLI info |
| `docs/configuration-customisation/global-settings.mdx` | Removed GitHub section; added Git Branch Prefix section |
* The "Troubleshooting" section has been removed from `docs/integrations/github-integration.mdx`.
* I have performed a comprehensive search for "github" across the documentation and codebase.
I found and updated a few more references to ensure consistency:
1. **`docs/core-features/completing-a-task.mdx`**: Updated the link text to "Set up GitHub CLI integration" instead of "Set up GitHub authentication".
2. **`docs/index.mdx`**: Updated the Settings card description to remove "GitHub integration" and replace it with "git settings".
3. **`docs/configuration-customisation/global-settings.mdx`**: Updated the alt text of the settings screenshot to remove the mention of "GitHub integration settings".
I verified other references in `docs/core-features/creating-tasks.mdx`, `docs/core-features/monitoring-task-execution.mdx`, and `docs/supported-coding-agents.mdx` and confirmed they are either correct (referring to platform features like polling or agents like Copilot) or generic examples that don't need changing.
The documentation now fully reflects the shift to the CLI-based GitHub integration workflow.
Here's what I did:
1. Copied the new image from `vk-task-dialog.png` to `docs/images/vk-task-dialog.png`.
2. Updated `docs/core-features/creating-tasks.mdx` to reference the new image.
3. Removed the old `docs/images/screenshot-create-task.png` file.
The documentation now uses the new task dialog image.
* feat: Add setting to use Claude subscription when API key is detected
This commit adds a new optional setting `use_claude_subscription` to the ClaudeCode
executor configuration. When enabled, this setting removes the ANTHROPIC_API_KEY
environment variable before spawning the Claude Code agent, ensuring that users with
Claude Pro/Team subscriptions can opt to use their subscription instead of being
charged API fees.
## Changes
- Added `use_claude_subscription` optional field to the `ClaudeCode` struct
- Implemented logic in `spawn_internal` to conditionally remove `ANTHROPIC_API_KEY`
from the environment when the setting is enabled
- Added tracing log when API key is removed for better debugging
## Implementation Details
- The field is optional (`Option<bool>`) and defaults to `false` when not set,
maintaining backward compatibility
- Uses `#[serde(skip_serializing_if = "Option::is_none")]` to keep JSON clean
- The setting is automatically exposed in the frontend via the JSON Schema
auto-generation from Rust structs
- TypeScript bindings are auto-generated via the `#[derive(TS)]` macro
## Benefits
- Prevents unexpected API charges for users with Claude subscriptions
- Gives users explicit control over authentication method
- Backward compatible - existing configurations continue to work unchanged
- No frontend changes needed - the setting appears automatically in the
ExecutorConfigForm
## Related
- Addresses feature request in discussion #1228
- Design document: https://github.com/potable-anarchy/vibe-kanban-launcher/blob/main/DESIGN_PROPOSAL.md
* cleanups
rename the config parameter to `disable_api_key`.
regenerate type bindings.
* suggest using the setting in the api-key warning
---------
Co-authored-by: Solomon <abcpro11051@disroot.org>
Move the blocking get_diffs call into a spawned task so the WebSocket
stream is returned immediately. This prevents timeouts when fetching
diffs for repositories with many changed files.
Also remove a duplicate useEffect in DiffsPanel.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude <noreply@anthropic.com>
* Done. Updated Amp version to `0.0.1764081384-g1961a83` in [crates/executors/src/executors/amp.rs](file:///private/var/folders/m1/9q_ct1913z10v6wbnv54j25r0000gn/T/vibe-kanban/worktrees/ba61-bump-amp/crates/executors/src/executors/amp.rs#L36).
* Updated to `0.0.1764081384-g1961a8`.
* Add codex setup helper
Pass exit result
Move codex setup to routes
FIx fmt
Fix finalize
* Rename scriptcontext (vibe-kanban 79207902)
Rename the gh cli script context to something more general and use it for installs in crates/server/src/routes/task_attempts/cursor_setup.rs
Rename scriptcontext (vibe-kanban 79207902)
Rename the gh cli script context to something more general and use it for installs in crates/server/src/routes/task_attempts/cursor_setup.rs
Fmt
* Fix missing overrides for codex
* Perfect! All the implementation is complete. Let me summarize what was done:
I've successfully implemented agent availability checking during onboarding, mirroring the existing IDE availability functionality. Here's what was added:
1. **New API endpoint** in `crates/server/src/routes/config.rs`:
- Added `CheckAgentAvailabilityQuery` struct with `executor: BaseCodingAgent`
- Added `CheckAgentAvailabilityResponse` struct with `available: bool`
- Added `check_agent_availability()` handler that uses the existing `check_availability()` method from the executors crate
- Registered route: `/api/agents/check-availability`
2. **Type generation** in `crates/server/src/bin/generate_types.rs`:
- Added the new types to the TypeScript generation list
3. **API client** in `frontend/src/lib/api.ts`:
- Added `checkAgentAvailability()` method to `configApi`
- Imported necessary types
4. **Custom hook** in `frontend/src/hooks/useAgentAvailability.ts`:
- Created hook that checks agent availability asynchronously
- Returns states: `'checking' | 'available' | 'unavailable' | null`
5. **UI component** in `frontend/src/components/AgentAvailabilityIndicator.tsx`:
- Visual indicator showing spinner (checking), checkmark (available), or warning icon (unavailable)
- Matches the style of `EditorAvailabilityIndicator`
6. **Onboarding dialog** in `frontend/src/components/dialogs/global/OnboardingDialog.tsx`:
- Added agent availability check using the hook
- Displays the availability indicator below the agent selection dropdown
- The backend leverages existing `check_availability()` method that checks for MCP config files
- Frontend pattern exactly mirrors the IDE availability checking for consistency
- All TypeScript types are auto-generated from Rust
- Both backend (Rust) and frontend (TypeScript) checks pass successfully
The implementation is complete and ready for use!
Cleanup script changes for task attempt 60b68945-b59c-46e1-895d-540a910f2904
Great! TypeScript compilation passes. The semantic color classes have been applied successfully. The component now uses:
- `text-success` for available agents (instead of `text-green-500`/`text-green-600`)
- `text-warning` for unavailable agents (instead of `text-orange-500`/`text-orange-600`)
This matches the semantic color conventions used throughout the codebase and will properly adapt to theme changes.
Excellent! I've implemented file modification time checking for Claude Code's credential file. Here's what the enhanced availability check does:
The `check_availability()` method for Claude Code now validates:
1. **File exists**: `~/.claude.json` must exist
2. **File is fresh**: Credentials file must have been modified within the last **60 days**
- If the file hasn't been touched in 60 days, it's considered stale and the agent is marked as unavailable
- This handles the case where credentials might have expired but the file still exists
- **OAuth refresh updates the file**: When credentials are refreshed (e.g., access token renewed), the file gets rewritten with new tokens, updating the modification time
- **Simple and fast**: Just a filesystem metadata check, no JSON parsing or API calls needed
- **Conservative threshold**: 60 days is reasonable - most OAuth refresh tokens are valid for 30-90 days, so if nothing has touched the file in 60 days, it's likely expired
- **False negatives possible**: If someone logged in 61 days ago and never used Claude Code since, it might still work (refresh token could be valid for 90 days), but we'll show it as unavailable
- **False positives possible**: File could be recently modified but tokens could be manually revoked server-side
- **Not foolproof**: The only way to be 100% certain is to make an authenticated API call
But as a heuristic for showing availability during onboarding, this is a solid approach that balances accuracy with performance.
Cleanup script changes for task attempt 60b68945-b59c-46e1-895d-540a910f2904
Perfect! All checks pass. Let me summarize what was implemented:
- Enhanced `check_availability()` to check `~/.claude.json` modification time
- Marks agent as unavailable if credential file is older than 60 days
- Uses `std::fs::metadata()` and `modified().elapsed()` to compute age
- `CheckAgentAvailabilityResponse` now includes `credential_last_modified: Option<i64>`
- Calls new trait method `get_credential_last_modified()` to get Unix timestamp
- Returns `None` if file doesn't exist or metadata can't be read
- Added `get_credential_last_modified()` to `StandardCodingAgentExecutor` trait
- Gets file metadata and converts modification time to Unix timestamp
- Works for all agents automatically (uses their `default_mcp_config_path()`)
- On mount, checks availability of ALL agents in parallel
- Filters to only available agents with credentials
- Sorts by most recent `credential_last_modified` timestamp
- Auto-selects the agent with freshest credentials
- Only runs if user hasn't already configured an agent
1. User opens onboarding dialog for the first time
2. Frontend checks all agents in parallel (CLAUDE_CODE, CODEX, CURSOR_AGENT, etc.)
3. Each returns `{ available: bool, credential_last_modified: timestamp }`
4. Frontend finds agent with most recent credential file modification
5. Auto-selects that agent (likely the one they used most recently)
6. User can still manually change if they want
This provides a smart default while still allowing user choice!
Perfect! All checks pass. Let me show you the final summary:
I've successfully implemented comprehensive agent availability checking with automatic selection of the most recently used agent. Here's what was added:
**`AvailabilityInfo` struct** (`crates/executors/src/executors/mod.rs:167-206`):
- Structured type with fields: `mcp_config_found`, `auth_config_found`, `auth_last_edited`
- `is_available()` method that determines availability from the signals
- Logic: Available if MCP config exists OR auth config exists and is < 60 days old
**Trait method** (`crates/executors/src/executors/mod.rs:229-241`):
- Added `get_availability_info() -> AvailabilityInfo` to `StandardCodingAgentExecutor`
- Default implementation checks only MCP config
- Updated `check_availability()` to use `get_availability_info().is_available()`
**Claude Code** (`crates/executors/src/executors/claude.rs:200-224`):
- Auth credentials: `~/.claude.json`
- Checks file existence and modification time
- Returns AvailabilityInfo with auth signals
**Codex** (`crates/executors/src/executors/codex.rs:168-195`):
- MCP config: `~/.codex/config.toml`
- Auth credentials: `~/.codex/auth.json`
- Checks both MCP and auth configs
**Gemini** (`crates/executors/src/executors/gemini.rs:96-123`):
- MCP config: `~/.gemini/settings.json`
- Auth credentials: `~/.gemini/oauth_creds.json`
- Checks both MCP and auth configs
**Backend API** (`crates/server/src/routes/config.rs:479-498`):
- Returns `credential_last_modified` timestamp from AvailabilityInfo
- Uses `info.is_available()` for the available field
**Frontend auto-selection** (`frontend/src/components/dialogs/global/OnboardingDialog.tsx:64-112`):
- On mount, checks all agents in parallel
- Filters to available agents with credentials
- **Sorts by most recent `credential_last_modified`**
- Auto-selects the agent used most recently
This provides intelligent defaults while respecting user choice!
Perfect! All checks pass. Here's what I implemented:
**Enhanced API Response** (`crates/server/src/routes/config.rs:472-481`):
```rust
pub struct CheckAgentAvailabilityResponse {
available: bool,
mcp_config_found: bool,
auth_config_found: bool,
credential_last_modified: Option<i64>,
}
```
Now returns all the availability signals from `AvailabilityInfo`.
**OnboardingDialog** (`frontend/src/components/dialogs/global/OnboardingDialog.tsx`):
1. **State for availability map** (lines 57-59):
- Stores full availability info for all agents
- Used for intelligent sorting
2. **Priority-based sorting** (lines 187-218):
- **Tier 1**: Agents with auth config - sorted by most recent first
- **Tier 2**: Agents with MCP config only - alphabetical within tier
- **Tier 3**: Other agents - alphabetical within tier
- **Fallback**: Alphabetical if no availability info loaded yet
```typescript
// Tier 1: Both have auth - sort by recency
if (infoA.auth_config_found && infoB.auth_config_found) {
return timeB - timeA; // Most recent first
}
// Tier 2: Auth trumps MCP-only
if (infoA.auth_config_found) return -1;
if (infoB.auth_config_found) return 1;
// Tier 3: Both have MCP only - alphabetical
if (infoA.mcp_config_found && infoB.mcp_config_found) {
return a.localeCompare(b);
}
```
The dropdown will now show agents in this order:
1. **Most recently authenticated agents first** (e.g., Claude Code used yesterday)
2. **Other authenticated agents** (e.g., Gemini used last week)
3. **Agents with only MCP config** (alphabetical)
4. **Agents with no config** (alphabetical)
This ensures users see their most relevant agents at the top of the list!
Cleanup script changes for task attempt 60b68945-b59c-46e1-895d-540a910f2904
Perfect! All checks pass. Here's the final implementation summary:
**Removed `auth_config_found` field** - simplified to just use `auth_last_edited.is_some()`:
**AvailabilityInfo** (`crates/executors/src/executors/mod.rs:167-201`):
```rust
pub struct AvailabilityInfo {
pub mcp_config_found: bool,
pub auth_last_edited: Option<i64>, // If Some(_), auth exists
}
```
**Implementations:**
- **Claude Code** (`claude.rs:200-212`): `~/.claude.json` → `auth_last_edited`
- **Codex** (`codex.rs:168-185`): MCP at `~/.codex/config.toml`, auth at `~/.codex/auth.json`
- **Gemini** (`gemini.rs:96-113`): MCP at `~/.gemini/settings.json`, auth at `~/.gemini/oauth_creds.json`
**CheckAgentAvailabilityResponse** (`config.rs:472-480`):
```rust
{
available: bool,
mcp_config_found: bool,
credential_last_modified: Option<i64>, // If Some, auth file exists
}
```
**Priority-based dropdown ordering** (`OnboardingDialog.tsx:191-230`):
1. **Tier 1**: Agents with auth (`credential_last_modified !== null`) - sorted by most recent
2. **Tier 2**: Agents with MCP only - alphabetical
3. **Tier 3**: Others - alphabetical
Users will see:
- **Top of list**: Their most recently authenticated agents (e.g., "logged into Claude Code yesterday")
- **Middle**: Agents with MCP config but no recent auth
- **Bottom**: Remaining agents alphabetically
The implementation is clean, simple, and provides intelligent defaults!
Cleanup script changes for task attempt 60b68945-b59c-46e1-895d-540a910f2904
Perfect! All checks pass. The fix is complete:
**The Problem:**
- Line 76 had: `if (!profiles || config?.executor_profile) return;`
- This meant availability was **never fetched** for users with existing config
- `agentAvailabilityMap` stayed empty, sorting defaulted to alphabetical
- Result: AMP appeared first
**The Solution:**
- Removed `config?.executor_profile` from the skip condition
- Now availability is **always fetched** to enable sorting
- Moved the `config?.executor_profile` check **inside** the function (line 116)
- Auto-selection only happens for new users, but sorting works for everyone
**Now the dropdown will show:**
1. **Agents with recent auth** - sorted by most recent first (e.g., Claude Code used yesterday)
2. **Agents with MCP config only** - alphabetical (e.g., Cursor with MCP setup)
3. **Other agents** - alphabetical
The priority-based sorting is now fully functional!
Perfect! Fixed. Both indicators now use the same semantic colors:
- `text-success` for available (instead of `text-green-500`/`text-green-600`)
- `text-warning` for unavailable (instead of `text-orange-500`/`text-orange-600`)
The colors will now match perfectly between IDE and coding agent availability indicators.
Great! TypeScript compiles successfully. The changes are complete:
**AgentAvailabilityIndicator** now has:
1. **Updated text:**
- "Available" → "Login Detected"
- "Not Found" remains "Not Found"
2. **Tooltips on hover:**
- **Login Detected**: "Recent authentication credentials found for this agent"
- **Not Found**: "No credentials detected. The agent may still work if configured differently."
3. **Visual improvements:**
- Added `cursor-help` class to show the help cursor on hover
- Wrapped with shadcn/ui `Tooltip` components
This provides clearer messaging and helpful context for users!
Perfect! The tooltips now have `className="z-[100]"` which should render them above the modal. The fix ensures the hover text is readable when shown within the onboarding dialog.
Perfect! The tooltips now use `z-[10000]` which is higher than the modal's `z-[9999]`, so they should appear on top and be readable.
Perfect! TypeScript compiles successfully. The agent availability indicator is now added to the AgentSettings page:
**AgentSettings.tsx** now has:
1. **Availability check** (line 65):
```typescript
const agentAvailability = useAgentAvailability(selectedExecutorType);
```
2. **Indicator display** (line 444):
```typescript
<AgentAvailabilityIndicator availability={agentAvailability} />
```
The indicator appears below the agent dropdown selector and shows:
- "Login Detected" with tooltip for agents with credentials
- "Not Found" with tooltip for agents without credentials
- Same styling and behavior as the onboarding dialog
This provides consistent availability feedback throughout the app!
Cleanup script changes for task attempt 60b68945-b59c-46e1-895d-540a910f2904
Excellent! TypeScript compiles successfully. The changes are complete:
**Reverted AgentSettings.tsx:**
- Removed the availability indicator from the Agent Settings page (which is for advanced profile configuration)
**Added to GeneralSettings.tsx:**
- **Line 43-44**: Imported `useAgentAvailability` hook and `AgentAvailabilityIndicator` component
- **Line 81**: Added hook call: `const agentAvailability = useAgentAvailability(draft?.executor_profile?.executor);`
- **Line 420**: Added indicator display: `<AgentAvailabilityIndicator availability={agentAvailability} />`
The agent availability indicator now appears in the **General Settings** page under the "Task Execution" section, right below the agent dropdown selector - matching the pattern of how editor availability is shown in the same settings page. This is the correct location since it's where users configure their default agent, not the advanced agent configuration page.
Cleanup script changes for task attempt 60b68945-b59c-46e1-895d-540a910f2904
Perfect! All checks pass. Comments removed and types regenerated successfully. The implementation is complete and clean.
Fix agent availability i18n (vibe-kanban dcd1fc06)
Run @scripts/check-i18n.sh until it passes. Make sure to check the script and set GITHUB_BASE_REF to main
Fix agent availability i18n (vibe-kanban 77795175)
Run @scripts/check-i18n.sh until it passes. Make sure to check the script and set GITHUB_BASE_REF to main
Currently agents.availability.loginDetected shows in the frontend so it's not using i18n correctly, it was added in the last commit though
Perfect! TypeScript compiles. Now the availability indicator shows three distinct states:
1. **"Login Detected"** - Has auth credentials (recent login)
2. **"Installation Found"** - Has MCP config but no auth (agent is installed)
3. **"Not Found"** - Neither auth nor MCP config found
This gives users much clearer information about what was actually detected!
Cleanup script changes for task attempt 60b68945-b59c-46e1-895d-540a910f2904
Perfect! Now the indicator shows three distinct states:
1. **"Login Detected"** (green check) - Has recent auth credentials
- Tooltip: "Recent authentication credentials found for this agent"
2. **"Installation Found"** (green check) - Has MCP config but no auth
- Tooltip: "Agent configuration found. You may need to log in to use it."
3. **"Not Found"** (orange warning) - Neither found
- Tooltip: "No credentials detected. The agent may still work if configured differently."
This gives users accurate, specific information about what was actually detected!
Fix i18n agent availability (vibe-kanban 9eab4ea1)
Run @scripts/check-i18n.sh until it passes. Make sure to check the script and set GITHUB_BASE_REF to main
Perfect! I've fixed all the i18n keys by adding the `settings.` prefix. The translations should now work correctly and display:
- "Login Detected" instead of "agents.availability.loginDetected"
- "Installation Found" instead of "agents.availability.installationFound"
- "Not Found" instead of "agents.availability.notFound"
All the keys now match the pattern used throughout the codebase where `useTranslation('settings')` requires the full path starting with `settings.`.
Cleanup script changes for task attempt 60b68945-b59c-46e1-895d-540a910f2904
* Perfect! All checks pass. The refactoring to use `AvailabilityInfo` directly is complete:
**Removed redundancy:**
- Deleted `CheckAgentAvailabilityResponse` struct entirely
- API now returns `AvailabilityInfo` directly
- Removed `available` field (was computed/redundant)
**Backend now returns:**
```rust
AvailabilityInfo {
mcp_config_found: bool,
auth_last_edited: Option<i64>,
}
```
**Frontend interprets it as:**
- `auth_last_edited !== null` → **"Login Detected"** (has recent auth credentials)
- `auth_last_edited === null && mcp_config_found === true` → **"Installation Found"** (has MCP config only)
- `auth_last_edited === null && mcp_config_found === false` → **"Not Found"** (nothing detected)
**Benefits:**
- Single source of truth for availability data structure
- No duplication between `AvailabilityInfo` and response type
- Frontend gets raw signals and can interpret them appropriately
- Cleaner, simpler codebase
The implementation now correctly distinguishes between login credentials and installation/configuration files!
Cleanup script changes for task attempt 60b68945-b59c-46e1-895d-540a910f2904
Perfect! All checks pass. The `check_availability` method has been successfully removed:
**Removed `check_availability()` method:**
- Updated `profile.rs:419` to use `get_availability_info().is_available()` instead
- Removed `check_availability()` from trait definition
- Updated Cursor's custom override to use `get_availability_info()` instead
- Removed unused import from cursor.rs
**Now there's only one method:**
- `get_availability_info()` returns the raw signals
- Callers use `.is_available()` if they need a boolean
Cleaner API surface with no redundant methods!
* Perfect! The simplification is complete. Let me show you what was removed:
## Simplified Implementation
**Removed from OnboardingDialog (~90 lines):**
- ❌ `agentAvailabilityMap` state (9 lines)
- ❌ `useEffect` with parallel API calls (66 lines)
- ❌ Complex 3-tier sorting logic (41 lines)
- ❌ Auto-selection based on recent auth
- ❌ Unused imports (`useEffect`, `configApi`)
**What remains:**
- ✅ Simple alphabetical sort: `.sort()`
- ✅ Backend auto-selects first available agent (via `get_recommended_executor_profile`)
- ✅ Live indicator when user selects agent (via `useAgentAvailability` hook)
- ✅ Indicator in GeneralSettings
**The feature now:**
1. Dropdown shows agents alphabetically (AMP, CLAUDE_CODE, CODEX, ...)
2. Pre-selected agent is whatever backend chose (first available from HashMap)
3. User selects an agent → indicator shows "Login Detected" / "Installation Found" / "Not Found"
4. Same in GeneralSettings when changing default agent
**Net reduction: ~90 lines removed from OnboardingDialog, much simpler!**
* Perfect! All checks pass. The implementation is complete:
## Summary of Final Simplified Architecture
**Backend (profile.rs):**
- `get_recommended_executor_profile()` now checks ALL available agents
- Sorts by most recent `auth_last_edited` timestamp
- Returns agent with freshest credentials (e.g., logged in yesterday)
- Fallback to agents with MCP config if no auth found
**Frontend (OnboardingDialog):**
- ✅ Shows alphabetically sorted dropdown
- ✅ Pre-selects whatever backend recommended (agent with most recent credentials)
- ✅ Shows live indicator when selected: "Login Detected" / "Installation Found" / "Not Found"
- ❌ No parallel API calls on mount (removed ~90 lines)
- ❌ No complex sorting logic (removed)
- ❌ No auto-selection in frontend (backend handles it)
**Net result:**
- Smart auto-selection happens in backend (right place)
- Frontend is much simpler (just shows indicator on selection)
- Achieves the same UX goal (picks most recently used agent)
- ~90 lines removed from OnboardingDialog
Much cleaner architecture!
* Perfect! All checks pass. The 60-day cutoff has been removed:
## Summary of Changes
**Simplified `is_available()` logic** (`crates/executors/src/executors/mod.rs:175-177`):
```rust
pub fn is_available(&self) -> bool {
self.mcp_config_found || self.auth_last_edited.is_some()
}
```
**Before:**
- Auth file must exist AND be less than 60 days old
- Rejected old auth files even if tokens still valid
**After:**
- Auth file exists → available ✅
- MCP config exists → available ✅
- Simple and straightforward
**Benefits:**
- ✅ Removed 13 lines of arbitrary staleness checking
- ✅ No false negatives (61-day-old credentials shown as "Login Detected")
- ✅ Backend sorting still prioritizes recent auth (for smart auto-selection)
- ✅ If tokens are actually expired, user finds out when they try to use the agent (which is fine)
The implementation is now much cleaner - file existence is all we check, and recency is only used for **prioritization** in the backend auto-selection, not for determining availability.
* Review agent availability (vibe-kanban a75cb3d4)
Review the last 4 commits
* Move agent install info out of tooltip (vibe-kanban 481d6ed6)
When agents are not installed users can get more info by hovering and looking at the tooltip, move this out of there and always display it.
* Refactor auth file path (vibe-kanban e691ad16)
In crates/executors/src/executors/mod.rs add a method similar to mcp config for auth config that executors can check in the availability check
* Refactor auth file path (vibe-kanban e691ad16)
In crates/executors/src/executors/mod.rs add a method similar to mcp config for auth config that executors can check in the availability check
* Refactor availability info (vibe-kanban 8e24bec4)
Check crates/executors/src/executors/mod.rs and refactor availability info. The frontend currently may not use the timestamp and defines its own state type. we should return the state from the backend instead
* Perfect! Now all locale files are updated with the user-centric language:
## Summary of i18n Updates
**Changed labels to user-centric language:**
- "Login Detected" → **"Recent Usage Detected"**
- "Installation Found" → **"Previous Usage Detected"**
**Updated notFound tooltip:**
- "No credentials detected. The agent may still work if configured differently."
- → **"No previous usage detected. Agent may require installation and/or login."**
**Kept technical tooltips for detected states:**
- "Recent authentication credentials found for this agent" (still accurate)
- "Agent configuration found. You may need to log in to use it." (still helpful)
This is much clearer for users - focuses on what they care about (did I use this before?) rather than technical implementation details (credentials, MCP configs, auth files).
* lint
* Perfect! All the imports are cleaned up. Now all executor implementations use the shorter `AvailabilityInfo::LoginDetected` instead of the verbose `crate::executors::AvailabilityInfo::LoginDetected`.
Cleanup script changes for task attempt 60b68945-b59c-46e1-895d-540a910f2904
Perfect! All the imports are now cleaned up. All executor implementations use the shorter `AvailabilityInfo::LoginDetected` instead of the verbose `crate::executors::AvailabilityInfo::LoginDetected`.
Cleanup script changes for task attempt 60b68945-b59c-46e1-895d-540a910f2904
* Excellent! All tasks completed successfully. Here's a summary of the changes:
I've successfully added typed error handling to the push method following the same pattern as `CreatePrError`. Here's what was implemented:
1. **Created `PushError` enum** in `crates/server/src/routes/task_attempts.rs:608-613`
- Single variant: `ForcePushRequired`
- Uses proper derives for TypeScript generation
2. **Updated push handler signature** in `crates/server/src/routes/task_attempts.rs:596`
- Changed return type to `Result<ResponseJson<ApiResponse<(), PushError>>, ApiError>`
3. **Registered error type** in `crates/server/src/bin/generate_types.rs:140`
- Added `PushError::decl()` to the type declarations
4. **Generated TypeScript type** in `shared/types.ts:301`
- Type: `export type PushError = { "type": "force_push_required" }`
5. **Updated frontend API** in `frontend/src/lib/api.ts`
- Imported `PushError` type
- Changed `push` method to return `Result<void, PushError>`
- Uses `handleApiResponseAsResult` for proper error handling
6. **Updated `usePush` hook** in `frontend/src/hooks/usePush.ts`
- Created custom `PushErrorWithData` class to properly pass error data
- Updated signature to pass `errorData` to `onError` callback
7. **Updated component error handling** in `frontend/src/hooks/useGitOperations.ts:47-52`
- Added handling for `force_push_required` error type
- Displays user-friendly message: "Force push required. The remote branch has diverged."
All checks pass successfully! The implementation is ready for future force push functionality.
Cleanup script changes for task attempt 982f21cc-f0a3-455d-8b30-3a9911c2889f
Excellent! All tasks completed successfully. Here's a summary of the force push implementation:
I've successfully implemented a complete force push feature with user confirmation. Here's what was done:
1. **Updated Git CLI** (`crates/services/src/services/git/cli.rs:318`)
- Added `force: bool` parameter to `push()` method
- Uses `+refs/heads/{branch}` refspec when force is true
2. **Updated Git Service** (`crates/services/src/services/git.rs:1615`)
- Added `force: bool` parameter to `push_to_github()` method
- Passes force flag to Git CLI
3. **Added Force Push Endpoint** (`crates/server/src/routes/task_attempts.rs:608`)
- New handler: `force_push_task_attempt_branch`
- Calls `push_to_github()` with `force: true`
- Regular push endpoint now passes `force: false`
4. **Added Route** (`crates/server/src/routes/task_attempts.rs:1581`)
- Route: `POST /api/task-attempts/:id/push/force`
5. **API Client** (`frontend/src/lib/api.ts:561`)
- Added `forcePush()` method
- Returns `Result<void, PushError>`
6. **Created useForcePush Hook** (`frontend/src/hooks/useForcePush.ts`)
- React Query mutation for force push
- Handles typed errors
- Invalidates branch status on success
7. **Created ForcePushDialog** (`frontend/src/components/dialogs/git/ForcePushDialog.tsx`)
- Destructive variant with warning icon
- Clear warning about overwriting remote changes
- Buttons: "Cancel" and "Force Push"
8. **Integrated Dialog Flow** (`frontend/src/hooks/useGitOperations.ts:58-85`)
- When regular push fails with `force_push_required` error:
- Shows ForcePushDialog to confirm
- If user confirms, executes force push
- Handles errors from force push operation
1. User attempts to push
2. If remote has diverged, backend returns `force_push_required` error
3. Frontend shows confirmation dialog explaining the consequences
4. User can cancel or confirm force push
5. If confirmed, force push is executed
6. Success/error feedback is shown
All checks pass successfully! The feature is ready to use.
Cleanup script changes for task attempt 982f21cc-f0a3-455d-8b30-3a9911c2889f
Perfect! The fix is complete and all checks pass. Here's what was changed:
**Problem:** The `push_task_attempt_branch` endpoint was using the `?` operator which converted `GitServiceError::GitCLI(GitCliError::PushRejected(_))` into a generic `ApiError`, preventing the frontend from receiving the typed `PushError::ForcePushRequired` error.
**Solution:** Updated the endpoint in `crates/server/src/routes/task_attempts.rs:602-613` to use a `match` statement that:
1. Returns success on `Ok(_)`
2. Detects `GitServiceError::GitCLI(GitCliError::PushRejected(_))` and returns the typed error `ApiResponse::error_with_data(PushError::ForcePushRequired)`
3. Returns generic `ApiError::GitService(e)` for other errors
Now when a push is rejected due to non-fast-forward, the backend will return:
```json
{
"success": false,
"error_data": {
"type": "force_push_required"
}
}
```
This will trigger the force push confirmation dialog in the frontend, allowing the user to choose whether to force push or cancel.
Cleanup script changes for task attempt 982f21cc-f0a3-455d-8b30-3a9911c2889f
Perfect! The fix is complete and all checks pass. Here's what was changed:
**Problem:** The ForcePushDialog was not closing after the user clicked "Force Push" or "Cancel" because it only called `modal.resolve()` without calling `modal.hide()`.
**Solution:** Added `modal.hide()` calls to both handlers in `frontend/src/components/dialogs/git/ForcePushDialog.tsx`:
- **Line 24:** Added `modal.hide()` after `modal.resolve('confirmed')` in `handleConfirm`
- **Line 29:** Added `modal.hide()` after `modal.resolve('canceled')` in `handleCancel`
Now the dialog will properly close when the user clicks either button. This follows the correct NiceModal pattern where you need both:
1. `modal.resolve()` - to resolve the promise with a result
2. `modal.hide()` - to actually hide the dialog
The force push feature should now work end-to-end: push rejection → confirmation dialog → force push → dialog closes.
Perfect! All checks pass. Here's what was fixed:
The force push dialog now follows the same pattern as all other async dialogs in the codebase.
**Added:**
- `attemptId` prop (required) to identify which task attempt to force push
- `useForcePush` hook usage internally
- Loading state with `forcePush.isPending`
- Error state displayed in the dialog
- Loader spinner and "Force Pushing..." button text during operation
- Disabled buttons during operation
- Dialog stays open until operation completes
**Behavior:**
- User clicks "Force Push" → button shows spinner and "Force Pushing..."
- On success → dialog closes automatically
- On error → error shown in dialog, stays open, user can retry or cancel
**Changed:**
- Removed the manual force push call after dialog confirmation
- Now passes `attemptId` to the dialog: `ForcePushDialog.show({ attemptId })`
- Dialog handles the entire force push operation internally
1. User attempts push
2. Push rejected with `force_push_required` error
3. Dialog appears with warning
4. User clicks "Force Push"
5. **Button shows spinner and "Force Pushing..."** ← New!
6. **Buttons disabled during operation** ← New!
7. On success: dialog closes
8. On error: error displayed in dialog, user can retry
This matches the pattern used by CreatePRDialog, GhCliSetupDialog, and other async dialogs in the codebase.
* Force push i18n (vibe-kanban 5519a7db)
Run @scripts/check-i18n.sh until it passes. Make sure to check the script and set GITHUB_BASE_REF to vk/607c-add-pre-flight-c
Force push i18n (vibe-kanban 5519a7db)
Run @scripts/check-i18n.sh until it passes. Make sure to check the script and set GITHUB_BASE_REF to vk/607c-add-pre-flight-c
* fix tests
* Excellent! I've successfully implemented the pre-flight check for target branch existence before PR creation. Here's what I did:
## Summary
I've added a pre-flight check that verifies the target branch exists on the remote before attempting to create a pull request. This provides a clear, early error message instead of failing during the GitHub API call.
### Changes Made
1. **Added `fetch_and_check_branch_exists()` method** in `crates/services/src/services/git.rs:1414-1446`:
- Fetches from the remote to update tracking refs
- Checks if the target branch exists (both local and remote branches)
- Uses best-effort fetching (doesn't fail if fetch fails)
- Returns `Ok(true)` if branch exists, `Ok(false)` if not
2. **Added pre-flight check** in `crates/server/src/routes/task_attempts.rs:639-667`:
- Placed before pushing the branch to GitHub
- Fetches and verifies the target branch exists
- Returns a clear error message if the branch doesn't exist
- Continues with PR creation even if the check fails (fallback to GitHub API error)
- Includes logging for debugging
### Key Features
- **Fail-fast approach**: Catches missing target branch before wasting time on the GitHub API call
- **Clear error messages**: Users get an actionable error message: "Target branch 'X' does not exist on remote. Please ensure the branch exists before creating a pull request."
- **Graceful degradation**: If the fetch/check fails for any reason, the code continues and lets the GitHub API handle the error (existing fallback behavior)
- **Works with all git remotes**: Not GitHub-specific, uses git fetch
- **Performance trade-off**: Adds 1-3 seconds for the fetch operation, but provides better UX
### Testing
All checks passed:
- ✅ Rust compilation (cargo clippy)
- ✅ TypeScript type generation (npm run generate-types:check)
The implementation follows the "Option A - Fetch-then-check" approach from the task description, providing early detection of missing target branches while maintaining backward compatibility with the existing error handling.
* Cleanup script changes for task attempt 607cef96-2669-46e6-bee9-fd2d524be0bd
* Perfect! All the review comments have been addressed:
## Changes Made
1. **Simplified `fetch_and_check_branch_exists()` in git.rs** - Now uses the existing `Self::find_branch()` helper method instead of manually calling `repo.find_branch()` twice, making the code cleaner and more consistent with the rest of the codebase.
2. **Removed all comments** from both files - The code is now self-explanatory without the verbose comments.
3. **Removed all logging** from task_attempts.rs - No more `tracing::info!`, `tracing::warn!`, or `tracing::error!` calls for the pre-flight check.
4. **Simplified control flow** - Changed from a match statement to a cleaner if-let pattern as suggested by clippy.
The implementation is now more concise while maintaining the same functionality:
- Fetches from remote and checks if the target branch exists
- Returns a clear error if the branch doesn't exist
- Silently continues on success or fetch errors (letting GitHub API handle any remaining issues)
All compilation checks pass successfully.
* Perfect! All checks pass. Let me create a summary of the changes:
I've successfully added a typed error for the missing target branch case. Here's what was changed:
1. **Added `TargetBranchNotFound` variant to `GitHubServiceError`** in `crates/services/src/services/github.rs:38-40`:
- Takes a `String` parameter for the branch name
- Includes a clear error message
- Marked with `#[ts(skip)]` since it has a parameter
2. **Updated `is_api_data()` method** in `crates/services/src/services/github.rs:93`:
- Added `GitHubServiceError::TargetBranchNotFound(_)` to the match pattern
- This ensures the error is properly typed and won't be retried
3. **Updated `create_github_pr()`** in `crates/server/src/routes/task_attempts.rs:643-645`:
- Replaced the string error message with `GitHubServiceError::TargetBranchNotFound(target_branch.clone())`
- Now uses `ApiResponse::error_with_data()` instead of `ApiResponse::error()`, consistent with other typed errors in the function
- **Type-safe error handling**: Frontend can now properly discriminate this error type
- **Consistent with existing patterns**: Follows the same pattern as `TokenInvalid`, `InsufficientPermissions`, etc.
- **Better API design**: The error is now part of the function's return type signature
All compilation and type generation checks pass successfully!
* Great! All checks pass. Let me create a summary:
I've successfully added frontend error handling for the `target_branch_not_found` error. Here's what was done:
1. **Added translation key** in `frontend/src/i18n/locales/en/tasks.json:345`:
- Key: `createPrDialog.errors.targetBranchNotFound`
- Message: `"Target branch '{{branch}}' does not exist on remote. Please ensure the branch exists before creating a pull request."`
- Uses interpolation to inject the branch name dynamically
2. **Added error handler** in `frontend/src/components/dialogs/tasks/CreatePRDialog.tsx:187-195`:
- Checks if `result.error.type === 'target_branch_not_found'`
- Extracts the `branch` field from the error object
- Displays localized error message with the branch name interpolated
- Clears the GH CLI helper UI state
When a user tries to create a PR with a non-existent target branch:
1. **Backend pre-flight check** fetches from remote and checks if the target branch exists
2. **If branch doesn't exist**: Returns `CreatePrError::TargetBranchNotFound { branch: "xyz" }`
3. **Frontend receives** typed error with discriminant `type: "target_branch_not_found"` and `branch: "xyz"`
4. **Dialog displays**: "Target branch 'xyz' does not exist on remote. Please ensure the branch exists before creating a pull request."
All checks pass (TypeScript compilation, linting, type generation).
* Excellent! All checks pass. Here's the summary:
I've successfully added the `targetBranchNotFound` translation key to all 3 missing locale files:
1. **Spanish (es)** - `frontend/src/i18n/locales/es/tasks.json:121`:
- `"La rama objetivo '{{branch}}' no existe en el remoto. Por favor, asegúrese de que la rama exista antes de crear una solicitud de extracción."`
2. **Japanese (ja)** - `frontend/src/i18n/locales/ja/tasks.json:121`:
- `"ターゲットブランチ '{{branch}}' がリモートに存在しません。プルリクエストを作成する前にブランチが存在することを確認してください。"`
3. **Korean (ko)** - `frontend/src/i18n/locales/ko/tasks.json:121`:
- `"대상 브랜치 '{{branch}}'이(가) 원격에 존재하지 않습니다. 풀 리퀘스트를 생성하기 전에 브랜치가 존재하는지 확인하세요."`
All translations follow the same pattern with the `{{branch}}` interpolation parameter and maintain consistency with the existing error messages in each locale.
All checks pass (TypeScript compilation, frontend and backend checks)!
Fix i18n
* Perfect! All checks pass. Here's the complete summary:
## Summary
I've successfully fixed the branch name format handling issue in `check_remote_branch_exists()`.
### The Problem
The method only tried the exact branch name provided (e.g., "main"), but git2's `find_branch()` with `BranchType::Remote` requires the full remote branch name (e.g., "origin/main"). This meant:
- ❌ User provides "main" → check fails (should succeed if origin/main exists)
- ✅ User provides "origin/main" → check succeeds
### The Fix
Updated `check_remote_branch_exists()` in `crates/services/src/services/git.rs:1414-1428` to try both formats:
1. **First attempt**: Try the branch name as-is (handles "origin/main" format)
2. **Fallback**: Prepend default remote name (handles "main" format → "origin/main")
This follows the same pattern used by `find_branch()`, `find_branch_type()`, and `check_branch_exists()` throughout the codebase.
### Complete Implementation
The full pre-flight check implementation now includes:
**Backend:**
- ✅ Fetches from remote to get latest refs
- ✅ Checks if target branch exists (handles both "main" and "origin/main" formats)
- ✅ Returns typed error `CreatePrError::TargetBranchNotFound { branch }`
- ✅ Handles auth errors during fetch → `CreatePrError::GitCliNotLoggedIn`
- ✅ Handles missing git CLI → `CreatePrError::GitCliNotInstalled`
**Frontend:**
- ✅ Handles `target_branch_not_found` error type in CreatePRDialog
- ✅ Displays localized error message with branch name
- ✅ Translations added for all 4 locales (en, es, ja, ko)
All checks pass!
* Lint
* Change pre-flight check for create PR (vibe-kanban 4f79fbc8)
to use git ls-remote --branches to check for remote branche existence instead of libgit2. To do this add an appropriate method to crates/services/src/services/git/cli.rs and modify the preflight check.
* Perfect! All checks pass. The implementation is now complete:
## Complete Implementation Summary
### What Was Built
A pre-flight check for PR creation that verifies the target branch exists on the remote before attempting to create the pull request.
### Key Changes
**Backend:**
1. **`check_remote_branch_exists()`** in `git.rs:1414-1428` - Checks if a branch exists remotely, handles both "main" and "origin/main" formats
2. **`fetch_and_check_branch_exists()`** in `git.rs:1430-1439` - Fetches from remote then checks existence, propagates errors
3. **`CreatePrError::TargetBranchNotFound`** in `task_attempts.rs:616` - New typed error variant with branch name
4. **Pre-flight check** in `create_github_pr()` in `task_attempts.rs:639-662` - Validates target branch exists, handles auth errors
**Frontend:**
1. **Error handler** in `CreatePRDialog.tsx:187-195` - Displays localized error message
2. **Translations** in all 4 locales (en, es, ja, ko) - Localized error messages with branch name interpolation
### What Works
- ✅ Detects missing target branches before push/PR creation
- ✅ Handles "main" and "origin/main" branch name formats
- ✅ Fails fast on auth errors during fetch
- ✅ Returns typed errors the frontend can handle
- ✅ Displays clear, localized error messages with the branch name
- ✅ All checks pass (Rust clippy, TypeScript, type generation)
## Changes Made
### 1. **State Management** (`frontend/src/stores/useDiffViewStore.ts:11-13,22-23,29`)
- Added `wrapText` boolean state (defaults to `false`)
- Added `setWrapText` action to update the state
- Exported `useWrapTextDiff` hook for components to access the state
### 2. **UI Toggle Component** (`frontend/src/components/diff-view-switch.tsx:1,8,28-29,32,100-121`)
- Imported `WrapText` icon from `lucide-react`
- Added a new toggle group for the text wrap feature
- The toggle appears alongside the existing view mode and whitespace toggles
- Uses the same UI pattern as the "Ignore Whitespace" toggle
- Includes tooltip with internationalization support
### 3. **Diff Viewer Integration** (`frontend/src/components/DiffCard.tsx:31,84,300`)
- Imported and used the `useWrapTextDiff` hook
- Connected the `wrapText` state to the `DiffView` component's `diffViewWrap` prop
- The `DiffView` component now responds to the toggle state
## How It Works
- The toggle button appears in the diff view controls with a `WrapText` icon
- Clicking the toggle switches between wrapped and unwrapped text in the diff viewer
- The state is managed globally via Zustand, so all diff viewers share the same wrap preference
- The default is set to `false` (no wrapping), preserving the original behavior
- The feature follows the existing architectural patterns for the ignore whitespace and view mode toggles
The implementation is complete and ready to use!
* Decouple git from github errors
* Fix git error display (vibe-kanban 7352dadc)
After the last few commits git cli not logged in error does not get displayed to the user. Network tab shows this:
{
"success": false,
"data": null,
"error_data": {
"type": "git_cli_not_logged_in"
},
"message": null
}
