* fix remote branch detection and worktree interactions
Refactor GitService to improve remote handling and branch management
fix: update branch selection logic to include all branches and improve condition checks
* Clippy, fmt
* Fix branch upstream setting in GitService to handle non-remote branches
* Remove force push from refspec in GitService to prevent non-fast-forward updates
* Add error handling for diverged branches in GitService
* Fix base-branch normalization robust for PRs
---------
Co-authored-by: Solomon <abcpro11051@disroot.org>
- Pasted content wasn't treated as nomral input. It didn't activate the send button and wasn't sent in followup unse user typed other things.
- Copy on click of worktree path didn't work.
- Cmd/Ctrl-Z didn't undo/redo
- Added "Add to vibe-kanban" action which adds the vscode editor selection to vibe-kanbans input box.
* Allow multiple merge for a single task attempt
Merge more than once (vibe-kanban 618829fc)
When creating a PR, new changes can be pushed after creation.
We need merge to work the same way, when changes have been made after the first merge, a second one should work.
Commit changes from coding agent for task attempt 548ff450-df77-47b2-a5ba-c88d0aa4a334
Merge more than once (vibe-kanban 618829fc)
When creating a PR, new changes can be pushed after creation.
We need merge to work the same way, when changes have been made after the first merge, a second one should work.
Remove pinned todo list (vibe-kanban cc66cda2)
Make a minimal change to remove the pinned todo list from the frontend
Remove pinned todo list (vibe-kanban cc66cda2)
Make a minimal change to remove the pinned todo list from the frontend
* Create merges table; remove task_attempt.merge_commit
Add merge model, replace ta.merge_commit with m.merge_commit
Fix frontend
* Move PR to merges table
* Refactor GitHub repository info retrieval to return structured data
* Fix frontend
* Reset task branch after PR merge
Add branch status handling to TaskDetailsProvider and related components
fmt
Add branch status handling to TaskDetailsProvider and related components
fmt
Test (vibe-kanban 1bf1a80f)
add test.txt
Show merged diff when no worktree present
Refresh branch status after PR creation
Test (vibe-kanban 1bf1a80f)
add test.txt
Test (vibe-kanban 1bf1a80f)
add test.txt
Show rebase when behind
Refactor container service to check if the container is clean before showing merged diff; remove unused BranchStatus import
Test (vibe-kanban a3c1b297)
add test.txt
Refactor branch status handling: rename BranchStatusResponse to BranchStatus and update related types and usages
Test (vibe-kanban) (#540)
* Remove test.txt
* Test (vibe-kanban aade357e)
add test.txt
* test.txt removed.
* Fix diff when merged and new commits have been made
* Remvoe logging (vibe-kanban) (#541)
* Test (vibe-kanban aade357e)
add test.txt
* Test (vibe-kanban aade357e)
add test.txt
* Perfect! I've successfully removed the "Fetching branch status" logging statement from the code. The logging has been removed from `crates/server/src/routes/task_attempts.rs:568-571`.
* Clear previous errors on successful PR creation, push, merge, and rebase actions
* Show branch in worktree dirty error message
* Add success indicators for push and merge actions in CurrentAttempt
* Refactor status display logic in CurrentAttempt for improved readability and maintainability
* Add target_branch_name to merge models and queries for direct and PR merges
* Enhance merge status display logic in CurrentAttempt for better clarity on direct merges
* Remove unnecessary condition check in attempt data fetching interval
* Clippy
* Add index for task_attempt_id in merges table to improve query performance
* Pass PR creation error
* Disable buttons (vibe-kanban 240346bf)
Instead of not showing the merge/pr buttons when theyre not available we should disable them. frontend/src/components/tasks/Toolbar/CurrentAttempt.tsx
* Perfect! The implementation is complete and passes all checks.
## Summary
Added browser window close protection to prevent data loss when users have unsaved changes in the task dialog:
- **Added `beforeunload` event listener** in [`TaskFormDialog.tsx`](file:///private/var/folders/m1/9q_ct1913z10v6wbnv54j25r0000gn/T/vibe-kanban/worktrees/vk-f59b-don-t-let/frontend/src/components/tasks/TaskFormDialog.tsx#L95-L111)
- **Integrates with existing `hasUnsavedChanges()` logic** - no duplication
- **Only active when dialog is open AND has unsaved content**
- **Automatic cleanup** when dialog closes or changes are saved
- **Browser-standard confirmation dialog** appears when user tries to close tab/window
The feature now protects against data loss from both dialog close (existing) and browser window close (new) scenarios.
* Cleanup script changes for task attempt f59bea00-6158-4cdd-ad19-1f30e40c1324
* Perfect! Now the browser window close protection works for both scenarios:
## Updated Implementation
**Create mode:** Warns when user has entered title or description content
**Edit mode:** Warns when user has modified title, description, or status from original values
The `beforeunload` event will now trigger when:
- **Creating a task** and typing content, then trying to close browser
- **Editing a task** and changing any field, then trying to close browser
Both the existing dialog close warning and new browser window close warning now protect against data loss in all editing scenarios.
* Cleanup script changes for task attempt f59bea00-6158-4cdd-ad19-1f30e40c1324
* Perfect! The collapse functionality has been successfully implemented. Here's what was added:
## Summary of Changes
**DiffCard.tsx:**
- Added `isCollapsed` and `onToggle` props
- Made the header clickable with hover effects
- Added a rotating chevron icon to indicate collapse state
- Only renders `DiffView` when not collapsed (performance optimization)
- Added accessibility attributes and keyboard support
- Prevented event bubbling on the "Open in IDE" button
**DiffTab.tsx:**
- Added `Set<string>` state to track collapsed files using stable file path identifiers
- Added toggle logic with proper React state management
- Added a sticky "Collapse All" / "Expand All" button with tri-state logic
- Connected collapse state to each DiffCard
The implementation follows all the Oracle's recommendations:
- Uses `Set<string>` with stable identifiers (file paths)
- Keeps state centralized in DiffTab
- Only renders DiffView when expanded for better performance
- Provides accessible clickable headers with proper ARIA attributes
- Includes keyboard support for toggling
The type checking and build process completed successfully with no errors related to our changes.
* Cleanup script changes for task attempt 9592ba9e-ff81-483b-b0f4-14bdf6461e24
* Done! The Collapse All button is now using the "xs" size.
* Perfect! The high-level stats display has been successfully implemented. Here's what was added:
## Summary of Changes
**Enhanced the sticky header to show:**
- **Files changed**: Shows count with proper singular/plural handling ("1 file" vs "3 files")
- **Total additions**: Green `+45` style matching existing DiffCard styling
- **Total deletions**: Red `-12` style matching existing DiffCard styling
- **Collapse All button**: Positioned on the right with proper spacing
**Key Features:**
- **Efficient calculation**: Extended existing `useMemo` to calculate both files and totals in a single pass
- **Proper edge case handling**: Handles undefined `additionLength`/`deletionLength` values
- **Consistent styling**: Uses same CSS variables as individual file stats (`--console-success`, `--console-error`)
- **Responsive layout**: Flexbox with proper gap and shrink controls
- **Accessibility**: Added `aria-live="polite"` for screen reader updates
- **Performance**: Only recalculates when diffs change, not on every render
The implementation follows all Oracle recommendations and maintains consistency with the existing codebase design patterns. The type checking passed successfully with no errors.
* Cleanup script changes for task attempt 9592ba9e-ff81-483b-b0f4-14bdf6461e24
* ## Implementation Complete ✅
I've successfully implemented the feature to skip running cleanup scripts when no changes are made during coding agent execution.
### **Changes Made**
1. **Modified [`GitService::commit()`](file:///private/var/folders/m1/9q_ct1913z10v6wbnv54j25r0000gn/T/vibe-kanban/worktrees/vk-92b8-skip-runni/crates/services/src/services/git.rs#L174-L218)**:
- Changed return type from `Result<(), GitServiceError>` to `Result<bool, GitServiceError>`
- Returns `Ok(false)` when no changes to commit
- Returns `Ok(true)` when changes are committed
2. **Updated [`Container` trait](file:///private/var/folders/m1/9q_ct1913z10v6wbnv54j25r0000gn/T/vibe-kanban/worktrees/vk-92b8-skip-runni/crates/services/src/services/container.rs#L125)**:
- Changed `try_commit_changes()` signature to return `Result<bool, ContainerError>`
3. **Updated [`LocalContainerService`](file:///private/var/folders/m1/9q_ct1913z10v6wbnv54j25r0000gn/T/vibe-kanban/worktrees/vk-92b8-skip-runni/crates/local-deployment/src/container.rs#L889-L954)**:
- Modified implementation to propagate commit feedback
- Returns `false` for non-commit operations, `true`/`false` based on git changes
4. **Enhanced [execution monitor logic](file:///private/var/folders/m1/9q_ct1913z10v6wbnv54j25r0000gn/T/vibe-kanban/worktrees/vk-92b8-skip-runni/crates/local-deployment/src/container.rs#L335-L374)**:
- Conditionally calls `try_start_next_action()` based on whether changes were committed
- Skips cleanup script when coding agent made no changes
- Preserves existing behavior for setup scripts (always proceed to coding agent)
- Added informative logging when cleanup is skipped
### **Behavior**
**Before:**
```
CodingAgent (no changes) → try_commit_changes() → CleanupScript (always runs)
```
**After:**
```
CodingAgent (no changes) → try_commit_changes() returns false → Skip CleanupScript ✅
CodingAgent (has changes) → try_commit_changes() returns true → CleanupScript runs ✅
```
### **Safety Features**
- **Conservative error handling**: Commit failures are treated as "changes made" to ensure cleanup runs
- **Preserved workflows**: Setup scripts always proceed to coding agent (unchanged)
- **Informative logging**: Clear indication when cleanup is skipped
- **Type safety**: Compiler enforces correct return types throughout the call chain
### **Verification**
- ✅ Code compiles successfully
- ✅ All existing tests pass (47/47)
- ✅ Type checker passes
- ✅ No breaking changes to other parts of the codebase
The implementation is complete and ready for use!
* Cleanup script changes for task attempt 92b80e80-dbc1-470c-a3c8-172c38549b61
* Cleanup script changes for task attempt 92b80e80-dbc1-470c-a3c8-172c38549b61
* ## Task Status Fix Complete ✅
I've successfully fixed the issue where tasks weren't transitioning from `InProgress` to `InReview` when cleanup scripts are skipped.
### **Changes Made**
1. **Created [`finalize_task()` helper method](file:///private/var/folders/m1/9q_ct1913z10v6wbnv54j25r0000gn/T/vibe-kanban/worktrees/vk-92b8-skip-runni/crates/local-deployment/src/container.rs#L116-L128)**:
```rust
async fn finalize_task(
db: &DBService,
config: &Arc<RwLock<Config>>,
ctx: &ExecutionContext,
) {
// Updates task status to InReview
// Sends notifications via NotificationService
}
```
2. **Added manual finalization when skipping cleanup** ([lines 389-391](file:///private/var/folders/m1/9q_ct1913z10v6wbnv54j25r0000gn/T/vibe-kanban/worktrees/vk-92b8-skip-runni/crates/local-deployment/src/container.rs#L389-L391)):
```rust
} else {
tracing::info!("Skipping cleanup script - no changes made by coding agent");
// Manually finalize task since we're bypassing normal execution flow
Self::finalize_task(&db, &config, &ctx).await;
}
```
3. **Refactored existing finalization** to use the helper method ([line 395](file:///private/var/folders/m1/9q_ct1913z10v6wbnv54j25r0000gn/T/vibe-kanban/worktrees/vk-92b8-skip-runni/crates/local-deployment/src/container.rs#L395-L397)):
```rust
if Self::should_finalize(&ctx) {
Self::finalize_task(&db, &config, &ctx).await;
}
```
### **Fixed Flow**
**Before (Broken):**
```
CodingAgent (no changes) → Skip cleanup → should_finalize() = false → Task stuck in InProgress ❌
```
**After (Fixed):**
```
CodingAgent (no changes) → Skip cleanup → Manual finalize_task() → Task → InReview ✅
CodingAgent (has changes) → Cleanup runs → should_finalize() = true → Task → InReview ✅
```
### **Benefits**
- ✅ **Fixes the bug**: Tasks now properly transition to `InReview` when cleanup is skipped
- ✅ **DRY principle**: Reuses finalization logic instead of duplicating
- ✅ **No double finalization**: Helper is idempotent and safely reusable
- ✅ **Preserves notifications**: Same notification behavior as normal cleanup completion
- ✅ **Clean separation**: `should_finalize()` logic unchanged for normal flows
### **Verification**
- ✅ Code compiles successfully
- ✅ All tests pass (47/47)
- ✅ Type checker passes
- ✅ Same finalization behavior for both paths
The complete feature is now implemented: cleanup scripts are skipped when no changes are made during coding agent execution, AND tasks properly transition to `InReview` status in both scenarios!
* Cleanup script changes for task attempt 92b80e80-dbc1-470c-a3c8-172c38549b61
* ## UI Copy Updates Complete ✅
I've successfully updated the project settings UI to clearly communicate that the cleanup script only runs when changes are made by the coding agent.
### **Changes Made**
1. **Updated description text** in [`project-form-fields.tsx`](file:///private/var/folders/m1/9q_ct1913z10v6wbnv54j25r0000gn/T/vibe-kanban/worktrees/vk-92b8-skip-runni/frontend/src/components/projects/project-form-fields.tsx#L249-L253):
```diff
- This script will run after coding agent execution is complete.
+ This script runs after coding agent execution only if changes were made.
+ Use it for quality assurance tasks like running linters, formatters, tests,
+ or other validation steps. If no changes are made, this script is skipped.
```
2. **Updated Unix placeholder** in [`script-placeholders.ts`](file:///private/var/folders/m1/9q_ct1913z10v6wbnv54j25r0000gn/T/vibe-kanban/worktrees/vk-92b8-skip-runni/frontend/src/utils/script-placeholders.ts#L36-L38):
```diff
- # This runs after coding agent execution
+ # This runs after coding agent execution - only if changes were made
```
3. **Updated Windows placeholder** in [`script-placeholders.ts`](file:///private/var/folders/m1/9q_ct1913z10v6wbnv54j25r0000gn/T/vibe-kanban/worktrees/vk-92b8-skip-runni/frontend/src/utils/script-placeholders.ts#L20-L22):
```diff
- REM This runs after coding agent execution
+ REM This runs after coding agent execution - only if changes were made
```
### **User Experience**
Now when users configure a cleanup script in project settings, they will see:
**Label**: "Cleanup Script (Optional)"
**Description**:
> This script runs after coding agent execution **only if changes were made**. Use it for quality assurance tasks like running linters, formatters, tests, or other validation steps. If no changes are made, this script is skipped.
**Placeholder text**:
```bash
#!/bin/bash
# Add cleanup commands here...
# This runs after coding agent execution - only if changes were made
```
### **Benefits**
- ✅ **Clear expectations**: Users understand the conditional behavior upfront
- ✅ **Emphasized condition**: "only if changes were made" is bolded for visibility
- ✅ **Comprehensive coverage**: Updated both description and placeholder text
- ✅ **Cross-platform**: Updated both Unix and Windows placeholders
- ✅ **TypeScript verified**: Frontend code compiles successfully
Users will now have clear visibility into when their cleanup scripts will and won't run, preventing any confusion about the new conditional execution behavior!
* Cleanup script changes for task attempt 92b80e80-dbc1-470c-a3c8-172c38549b61
* ## Implementation Complete!
I've successfully implemented the dev server logs feature with the following changes:
### **Files Modified:**
1. **Created Context Files:**
- [`TabNavigationContext.tsx`](file:///private/var/folders/m1/9q_ct1913z10v6wbnv54j25r0000gn/T/vibe-kanban/worktrees/vk-5e98-dev-server/frontend/src/contexts/TabNavigationContext.tsx) - For tab switching
- [`ProcessSelectionContext.tsx`](file:///private/var/folders/m1/9q_ct1913z10v6wbnv54j25r0000gn/T/vibe-kanban/worktrees/vk-5e98-dev-server/frontend/src/contexts/ProcessSelectionContext.tsx) - For process pre-selection
2. **Updated [`TaskDetailsPanel.tsx`](file:///private/var/folders/m1/9q_ct1913z10v6wbnv54j25r0000gn/T/vibe-kanban/worktrees/vk-5e98-dev-server/frontend/src/components/tasks/TaskDetailsPanel.tsx):**
- Added context providers
- Connected process selection to ProcessesTab
3. **Updated [`CurrentAttempt.tsx`](file:///private/var/folders/m1/9q_ct1913z10v6wbnv54j25r0000gn/T/vibe-kanban/worktrees/vk-5e98-dev-server/frontend/src/components/tasks/Toolbar/CurrentAttempt.tsx):**
- Added FileText icon import
- Added process selection hook
- Added logic to find latest dev server process
- Added View Logs icon button with tooltip
- Added handler to jump to dev server logs
4. **Updated [`ProcessesTab.tsx`](file:///private/var/folders/m1/9q_ct1913z10v6wbnv54j25r0000gn/T/vibe-kanban/worktrees/vk-5e98-dev-server/frontend/src/components/tasks/TaskDetails/ProcessesTab.tsx):**
- Added props interface for jumpProcessId
- Added useEffect to handle process pre-selection
- Auto-loads process details when jumping to a process
### **How It Works:**
1. **Button Visibility**: View Logs button (📄 icon) appears next to the dev server button only when a dev server process exists
2. **Smart Process Selection**: Finds the latest dev server process (running preferred, falls back to completed)
3. **Seamless Navigation**: Clicking switches to Processes tab and opens the dev server process logs automatically
4. **No Prop Drilling**: Uses React contexts to avoid passing props through multiple component layers
### **User Experience:**
- When dev server is running: User sees both "Dev" and "📄" buttons
- When dev server stopped but ran before: User sees "📄" button to view historical logs
- Clicking "📄" instantly opens the relevant dev server process in the Processes tab with logs expanded
- Tooltip shows "View dev server logs" on hover
The implementation is complete, tested, and ready for use! The build passes all TypeScript checks.
* Cleanup script changes for task attempt 5e98f2ff-ed68-4c04-8a75-cdcfd98e2bd7
* Done! Changed the icon from FileText to ScrollText (📜). The View Logs button now uses the scroll-text icon which is more appropriate for viewing logs.
* ## Refactoring Complete! ✅
The refactoring to more React-like patterns is now complete. Here's what was changed:
### **Key Improvements**
1. **Eliminated Callback Pattern**: Removed the un-React-like `onProcessJumped={() => setJumpProcessId(null)}` callback
2. **Single Source of Truth**: `selectedProcessId` now lives in `ProcessSelectionContext` instead of being split between parent and child
3. **Declarative State**: Components now simply read/write shared state instead of managing events
### **Changes Made**
1. **`ProcessSelectionContext`** → Now a full provider that:
- Manages `selectedProcessId` state
- Provides `setSelectedProcessId` for direct state updates
- Provides `jumpToProcess` wrapper that sets state + switches tab
- Uses proper React patterns with `useMemo` and `useCallback`
2. **`TaskDetailsPanel`** → Simplified:
- Removed `jumpProcessId` state
- Removed callback props to ProcessesTab
- Uses `ProcessSelectionProvider` component
- Clean provider hierarchy
3. **`ProcessesTab`** → Cleaner component:
- Removed props interface entirely
- Uses context state instead of local `selectedProcessId`
- Auto-fetches process details via useEffect
- Manual clicks and button jumps use same state path
4. **`CurrentAttempt`** → Updated API usage:
- Uses `jumpToProcess(id, setActiveTab)`
- More explicit about tab switching
### **Benefits Achieved**
- ✅ **More React-like**: State-driven instead of event-driven
- ✅ **Better separation of concerns**: Context owns selection lifecycle
- ✅ **No more callbacks**: Eliminated imperative callback pattern
- ✅ **Cleaner code**: Removed props drilling and state synchronization
- ✅ **Easier to test**: Single state source, declarative flow
- ✅ **Better performance**: Memoized context values
The feature works exactly the same from the user's perspective, but the code is now much more maintainable and follows React best practices!
* Cleanup script changes for task attempt 5e98f2ff-ed68-4c04-8a75-cdcfd98e2bd7
* ## Context Refactoring Complete! ✅
The refactoring to improve context architecture is now complete. Here's what was accomplished:
### **Final Architecture**
**`TabNavContext`**:
- ✅ Manages tab navigation state (`activeTab`, `setActiveTab`)
- ✅ Single responsibility: UI navigation
**`ProcessSelectionContext`**:
- ✅ Manages process selection state (`selectedProcessId`, `setSelectedProcessId`)
- ✅ **Internally consumes** `TabNavContext` via `useTabNavigation()`
- ✅ Provides clean `jumpToProcess(processId)` API that handles both concerns
### **Key Improvements Achieved**
1. **Clean API**: `jumpToProcess(processId)` - no parameters needed
2. **Better Separation**: Each context owns its domain, but they coordinate properly
3. **Performance**: Minimal rerender fanout - tab changes don't rerender process consumers
4. **Developer Experience**: Simple, discoverable API
5. **Maintainability**: Easy to add more coordinated actions in the future
### **Usage Examples**
```typescript
// Before (awkward)
const { jumpToProcess } = useProcessSelection();
const { setActiveTab } = useTabNavigation();
jumpToProcess(processId, setActiveTab);
// After (clean)
const { jumpToProcess } = useProcessSelection();
jumpToProcess(processId);
```
### **Provider Hierarchy**
```jsx
<TabNavContext.Provider>
<ProcessSelectionProvider> {/* ← Uses useTabNavigation internally */}
<ProcessesTab /> {/* ← Gets clean jumpToProcess API */}
<CurrentAttempt /> {/* ← Simple jumpToProcess(id) call */}
</ProcessSelectionProvider>
</TabNavContext.Provider>
```
The architecture now follows React best practices with proper context boundaries, optimal performance, and excellent developer ergonomics. The feature works identically from the user's perspective, but the code is much cleaner and more maintainable!
* Cleanup script changes for task attempt 5e98f2ff-ed68-4c04-8a75-cdcfd98e2bd7
* fmt
* Perfect! Let me summarize what has been successfully implemented:
## ✅ Implementation Complete
I've successfully implemented a **unified log rendering architecture** with ANSI support across the entire application:
### 🎯 What Was Accomplished
1. **✅ Added `fancy-ansi` dependency** - React 18 compatible ANSI rendering library
2. **✅ Created `RawLogText` component** - Single, unified component for all raw log rendering
3. **✅ Added ANSI color CSS classes** - Consistent theming with Tailwind classes
4. **✅ Refactored all log rendering components**:
- **StdoutEntry.tsx** - Now uses RawLogText with `channel="stdout"`
- **StderrEntry.tsx** - Now uses RawLogText with `channel="stderr"`
- **ProcessLogsViewer.tsx** - Replaced `formatLogLine()` with RawLogText
- **ProcessCard.tsx** - Updated raw log display to use RawLogText
5. **✅ Added comprehensive tests** - Unit tests for the RawLogText component
6. **✅ Verified build success** - All TypeScript checks pass
### 🌟 Key Features
- **ANSI Escape Code Rendering**: Raw logs like `[0m[1][0m [32m[1mVITE[22m v5.4.19[39m` now render with proper colors
- **Smart STDERR Handling**: Only applies red fallback color when no ANSI codes are present
- **Flexible HTML Elements**: Supports both `<div>` and `<span>` rendering
- **Performance Optimized**: Uses `memo()` and efficient ANSI detection
- **Consistent Styling**: Single source of truth for all log rendering with proper whitespace preservation
### 📁 Files Modified
- `frontend/package.json` - Added `fancy-ansi` dependency
- `frontend/src/components/common/RawLogText.tsx` - **New unified component**
- `frontend/src/styles/index.css` - Added ANSI color CSS classes
- `frontend/src/components/logs/StdoutEntry.tsx` - Refactored to use RawLogText
- `frontend/src/components/logs/StderrEntry.tsx` - Refactored to use RawLogText
- `frontend/src/components/tasks/TaskDetails/ProcessLogsViewer.tsx` - Refactored to use RawLogText
- `frontend/src/components/tasks/TaskDetails/ProcessCard.tsx` - Refactored to use RawLogText
- `frontend/src/components/common/__tests__/RawLogText.test.tsx` - **New test file**
The implementation follows all the best practices identified by the Oracle and provides a robust, maintainable solution for ANSI log rendering across the entire application. Raw logs will now display with proper colors, formatting, and styling instead of showing escape codes as plain text.
* Cleanup script changes for task attempt 287442b9-2ddf-4f29-9b91-ddc18e4a96b7
* lockfile
* delete test
* feat: allow pushing updates to open PRs (#470)
PR push after creation (vibe-kanban c22efac9)
In the last commit, we added the ability to push new changes after a PR has been created. Is there a good way to only show this if there are actually new changes?
feat: allow pushing updates to open PRs (#470)
Commit changes from coding agent for task attempt 771ed0db-8c90-4556-b732-5888b665c42b
refactor: simplify unpushed commits check by focusing on origin/branch_name
PR creation review (vibe-kanban 89c2ecdd)
In the last two commits, we added the ability to push new changes after a PR has been created.
Please review this and explain potential shortcomings
* Fix git push frontend
* Use GitService provided by deployment
* Fix ssh auth failing blocking BranchStatus request
* Fix refspec
* Fix frontend to reflect disconnected
* wip: backend todo normalisation
* fe implementation
* remove unused dep
* cursor return ActionType::TodoManagement
* use lucide icons rather than emojis in the todo list
* review comments
* Commit changes from coding agent for task attempt faf9032c-6400-46f5-a1b8-7fa39dc79f0a
* Commit changes from coding agent for task attempt faf9032c-6400-46f5-a1b8-7fa39dc79f0a
* Commit changes from coding agent for task attempt faf9032c-6400-46f5-a1b8-7fa39dc79f0a
* Commit changes from coding agent for task attempt faf9032c-6400-46f5-a1b8-7fa39dc79f0a
* edit profiles.json
* move default crate configuration to a default_profiles.json
button to open mcp config in editor
initialse empty mcp config files
fix test
new JSON structure
remove editor buttons
fmt and types
* feat: add profile field to follow-up attempt (#442)
* move default crate configuration to a default_profiles.json
* new JSON structure
* feat: add profile field to follow-up attempt; fix follow ups using wrong session id at 2nd+ follow up
fmt
Profile selection (vibe-kanban cf714482)
Right now in the frontend, when viewing a task card, we show the base_coding_agent from the task attempt. We should also show the currently selected profile there in the same way
feat: add watchkill support to CommandBuilder and integrate with Claude executor
feat: refactor profile handling to use ProfileVariant across executors and requests
feat: restructure command modes in default_profiles.json for clarity and consistency
update profile handling to use ProfileVariant across components and add mode selection
fmt
feat: refactor profile handling to use variants instead of modes across components and update related structures
Fix frontend
* Refactor coding agent representation in task and task attempt models
- Changed `base_coding_agent` field to `profile` in `TaskWithAttemptStatus` and `TaskAttempt` structs.
- Updated SQL queries and data handling to reflect the new `profile` field.
- Modified related API endpoints and request/response structures to use `profile` instead of `base_coding_agent`.
- Adjusted frontend API calls and components to align with the updated data structure.
- Removed unused `BaseCodingAgent` enum and related type guards from the frontend.
- Enhanced MCP server configuration handling to utilize the new profile-based approach.
feat: Introduce MCP configuration management
- Added `McpConfig` struct for managing MCP server configurations.
- Implemented reading and writing of agent config files in JSON and TOML formats.
- Refactored MCP server handling in the `McpServers` component to utilize the new configuration structure.
- Removed deprecated `agent_config.rs` and updated related imports.
- Enhanced error handling for MCP server operations.
- Updated frontend strategies to accommodate the new MCP configuration structure.
feat: Introduce MCP configuration management
- Added `McpConfig` struct for managing MCP server configurations.
- Implemented reading and writing of agent config files in JSON and TOML formats.
- Refactored MCP server handling in the `McpServers` component to utilize the new configuration structure.
- Removed deprecated `agent_config.rs` and updated related imports.
- Enhanced error handling for MCP server operations.
- Updated frontend strategies to accommodate the new MCP configuration structure.
Best effort migration; add missing feature flag
feat: refactor execution process handling and introduce profile variant extraction
feat: add default follow-up variant handling in task details context
feat: enhance profile variant selection with dropdown menus in onboarding and task sections
fmt, types
* refactor: rename ProfileVariant to ProfileVariantLabel; Modified AgentProfile to wrap AgentProfileVariant
Fmt, clippy
* Fix rebase issues
* refactor: replace OnceLock with RwLock for AgentProfiles caching; update profile retrieval in executors and routes
---------
Co-authored-by: Gabriel Gordon-Hall <ggordonhall@gmail.com>
Fmt
Fix tests
refactor: clean up unused imports and default implementations in executor modules
Move profiles to profiles.rs
* rename profile to profile_variant_label for readability
rename AgentProfile to ProfileConfig, AgentProfileVariant to VariantAgentConfig
* remove duplicated profile state
* Amp yolo
---------
Co-authored-by: Alex Netsch <alex@bloop.ai>
* add copy files setting
* DB prepare
* Move copy_project_files into the container trait so we remember to implement on cloud
* Autocomplete on the FE for files
* Clippy
* Lint and fmt
---------
Co-authored-by: Louis Knight-Webb <louis@bloop.ai>
* Increase broadcast channel size
* Use stdout_lines_stream
* WIP fix amp logs containing all previous conversation turns
* Mark raw and normalized log streams from the DB as finished
* Update event source manager to handle removed entries
* Clippy
* Cargo fmt
* Add collapsible agent log headers
- Make process headers (Setup Script, Coding Agent, Cleanup Script) clickable to hide/show logs
- Add chevron icon with rotation animation to indicate collapsed state
- Filter log entries to hide those from collapsed processes while preserving virtualization
- Maintain scroll position and follow-output behavior when toggling collapse
- Support keyboard navigation (Enter/Space) for accessibility
Amp-Thread: https://ampcode.com/threads/T-f44b0256-de19-45e1-96cb-df755553716d
Co-authored-by: Amp <amp@ampcode.com>
* Cleanup script changes for task attempt 990e23da-53ff-4203-ac58-f5b28653bc1f
* Commit changes from coding agent for task attempt 990e23da-53ff-4203-ac58-f5b28653bc1f
* Cleanup (and adjust lint)
* Enhance agent log collapsibility with auto-hide and dev server filtering
- Filter dev server processes from logs tab to reduce noise
- Auto-collapse completed setup/cleanup scripts on initial load for cleaner UX
- Auto-expand scripts that restart after completion
- Add process constants for type safety and consistency
- Separate auto-collapsed and user-collapsed state management
- Maintain scroll position and user preferences throughout
Amp-Thread: https://ampcode.com/threads/T-f44b0256-de19-45e1-96cb-df755553716d
Co-authored-by: Amp <amp@ampcode.com>
* Cleanup script changes for task attempt 990e23da-53ff-4203-ac58-f5b28653bc1f
* Add coding agent auto-collapse for cleaner log focus
- Auto-collapse all non-latest coding agents on task load for focused viewing
- Detect new coding agent starts (follow-ups) and collapse previous agents
- Latest coding agent always remains expanded for active monitoring
- Robust latest agent detection with timestamp tie-breaking
- One-shot initial collapse prevents duplicate processing
- Smart follow-up detection tracks new running agents
- User manual toggles permanently override auto-collapse behavior
- Comprehensive state reset on attempt changes
Amp-Thread: https://ampcode.com/threads/T-f44b0256-de19-45e1-96cb-df755553716d
Co-authored-by: Amp <amp@ampcode.com>
* Cleanup script changes for task attempt 990e23da-53ff-4203-ac58-f5b28653bc1f
* Fix timing issue with coding agent auto-collapse
- Only mark initial collapse as complete when coding agents are actually processed
- Prevents race condition where flag was set before real data arrived
- Ensures auto-collapse logic runs after data loads, not during empty state
- Fixes issue where all coding agents remained expanded instead of latest-only
Amp-Thread: https://ampcode.com/threads/T-f44b0256-de19-45e1-96cb-df755553716d
Co-authored-by: Amp <amp@ampcode.com>
* Cleanup script changes for task attempt 990e23da-53ff-4203-ac58-f5b28653bc1f
* refactor
* lints
* prettier
---------
Co-authored-by: Amp <amp@ampcode.com>
* init deployment
* refactor state
* pre executor app state refactor
* deployment in app state
* clone
* fix executors
* fix dependencies
* command runner via app_state
* clippy
* remove dependency on ENVIRONMENT from command_runner
* remove dependency on ENVIRONMENT from command_runner
* build fix
* clippy
* fmt
* featues
* vscode lints for cloud
* change streaming to SSE (#338)
Remove debug logging
Cleanup streaming logic
feat: add helper function for creating SSE stream responses for stdout/stderr
* update vscode guidance
* move start
* Fix executors
* Move command executor to separate file
* Fix imports for executors
* Partial fix test_remote
* Fix
* fmt
* Clippy
* Add back GitHub cloud only routes
* cleanup and shared types
* Prepare for separate cloud crate
* Init backend-common workspace
* Update
* WIP
* WIP
* WIP
* WIP
* WIP
* WIP
* Projects (and sqlx)
* Tasks
* WIP
* Amp
* Backend executor structs
* Task attempts outline
* Move to crates folder
* Cleanup frontend dist
* Split out executors into separate crate
* Config and sentry
* Create deployment method helper
* Router
* Config endpoints
* Projects, analytics
* Update analytics paths when keys not provided
* Tasks, task context
* Middleware, outline task attempts
* Delete backend common
* WIP container
* WIP container
* Migrate worktree_path to container_ref (generic)
* WIP container service create
* Launch container
* Fix create task
* Create worktree
* Move logic into container
* Execution outline
* Executor selection
* Use enum_dispatch to route spawn tree
* Update route errors
* Implement child calling
* Move running executions to container
* Add streaming with history
* Drop cloud WIP
* Logs
* Logs
* Refactor container logic to execution tracker
* Chunk based streaming and cleanup
* Alex/mirgate task templates (#350)
* Re-enable task templates; migrate routes; migrate args and return types
* Refactor task template routes; consolidate list functions into get_templates with query support
* Fix get_templates function
* Implement amp executor
* Gemini WIP
* Make streaming the event store reusable
* Rewrite mutex to rwlock
* Staging for normalised logs impl
* Store custom LogMsg instead of event as more flexible
* Cleanup
* WIP newline stream for amp (tested and working, needs store impl)
* refactor: move stranded `git2` logic out of `models` (#352)
* remove legacy command_executor; move git2 logic into GitService
* remove legacy cloud runner
* put back config get route
* remove dead logic
* WIP amp normalisation
* Normalized logs now save to save msg store as raw
* Refactor auth endpoints (#355)
* Re-enable auth;Change auth to use deployment
Add auth service
Move auth logic to service
Add auth router and service integration to deployment
Refactor auth service and routes to use octocrab
Refactor auth error handling and improve token validation responses
* rename auth_router to router for consistency
* refactor: rename auth_service to auth for consistency (#356)
* Refactor filesystem endpoints (#357)
* feat: implement filesystem service with directory listing and git repo detection
* refactor: update filesystem routes; sort repos by last modfied
* Gemini executor logs normalization
* feat: add sound file serving endpoint and implement sound file loading (#358)
* Gemini executor followup (#360)
* Sync logs to db (#359)
* Exit monitor
* Outline stream logs to DB
* Outline read from the message store
* Add execution_process_logs, store logs in DB
* Stream logs from DB
* Normalized logs from DB
* Remove eronious .sqlx cache
* Remove execution process stdout and stderr
* Update execution process record on completion
* Emit session event for amp
* Update session ID when event is emitted
* Split local/common spawn fn
* Create initial executor session
* Move normalized logs into executors
* Store executor action
* Refactor updated_at to use micro seconds
* Follow up executions (#363)
* Follow up request handler scaffold
Rename coding agent initial / follow up actions
* Follow ups
* Response for follow up
* Simplify execution actions for coding agents
* fix executor selection (#362)
* refactor: move logic out of `TaskAttempt` (#361)
* re-enable /diff /pr /rebase /merge /branch-status /open-editor /delete-file endpoints
* address review comments
* remove relic
* Claude Code (#365)
* Use ApiError rather than DeploymentError type in routes (#366)
* Fix fe routes (#367)
* /api/filesystem/list -> /api/filesystem/directory
* /api/projects/:project_id/tasks -> /api/tasks
* Remove with-branch
* /api/projects/:project_id/tasks/:task_id -> /api/tasks/:task_id
* Post tasks
* Update template routes
* Update BE for github poll endpoint, FE still needs updating
* WIP freeze old types
* File picker fix
* Project types
* Solve tsc warna
* Remove constants and FE cloud mode
* Setup for /api/info refactor
* WIP config refactor
* Remove custom mapping to coding agents
* Update settings to fix code editor
* Config fix (will need further changes once attempts types migrated)
* Tmp fix types
* Config auto deserialisation
* Alex/refactor background processes (#369)
* feat: add cleanup for orphaned executions at startup
* Fix worktree cleanup; re add worktree cleanup queries
* refactor worktree cleanup for orphaned and externally deleted worktrees
* Fix compile error
* refactor: container creation lifecycle (#368)
* Consolidate worktree logic in the WorktreeManager
* move auxiliary logic into worktree manager
* fix compile error
* Rename core crate to server
* Fix npm run dev
* Fix fe routes 2 (#371)
* Migrate config paths
* Update sounds, refactor lib.rs
* Project FE types
* Branch
* Cleanup sound constants
* Template types
* Cleanup file search and other unused types
* Handle errors
* wip: basic mcp config editing (#351)
* Re-add notification service, move assets to common dir (#373)
add config to containter, add notifications into exit monitor
Refctor notification service
Refactor notifications
* Stderr support (#372)
Refactor plain-text log processing and resuse it for gemini, stderr, and potentially other executors.
* Fix fe routes 3 (#378)
* Task attempts
* Task types
* Get single task attempt endpoint
* Task attempt response
* Branch status
* More task attempt endpoints
* Task attempt children
* Events WIP
* Stream events when task, task attempt and execution process change status
* Fixes
* Cleanup logs
* Alex/refactor pr monitor (#377)
* Refactor task status updates and add PR monitoring functionality
* Add PR monitoring service and integrate it into deployment flow
Refactor GitHub token retrieval in PR creation and monitoring services
Fix github pr regex
* Fix types
* refactor: dev server logic (#374)
* reimplement start dev server logic
* robust process group killing
* Fix fe routes 4 (#383)
* Add endpoint to get execution processes
* Update types for execution process
* Further execution process type cleanup
* Wipe existing logs display
* Further process related cleanup
* Update get task attempt endpoint
* Frozen type removal
* Diff types
* Display raw logs WIP
* fix: extract session id once per execution (#386)
* Fix fe routes 5 (#387)
* Display normalized logs
* Add execution-process info endpoint
* WIP load into virtualized
* Simplified unified logs
* Raw logs also use json patch now (simplifies FE keys)
* WIP
* Fix FE rendering
* Remove timestamps
* Fix conversation height
* Cleanup entry display
* Spacing
* Mark the boundaries between different execution processes in the logs
* Deduplicate entries
* Fix replace
* Fmt
* put back stop execution process endpoint (#384)
* Fix fe routes 6 (#391)
* WIP cleanup to remove related tasks and plans
* Refactor active tab
* Remove existing diff FE logic
* Rename tab
* WIP stream file events
* WIP track FS events
* Respect gitignore
* Debounced event
* Deduplicate events
* Refactor git diff
* WIP stream diffs
* Resolve issue with unstaged changes
* Diff filter by files
* Stream ongoing changes
* Remove entries when reset and json patch safe entry ids
* Update the diff tab
* Cleanup logs
* Cleanup
* Error enum
* Update create PR attempt URL
* Follow up and open in IDE
* Fix merge
* refactor: introduce `AgentProfiles` (#388)
* automatically schedule coding agent execution after setup script
* profiles implementation
* add next_action field to ExecutorAction type
* make start_next_action generic to action type
Remove ProfilesManager and DefaultCommandBuilder structs
* store executor_action_type in the DB
* update shared types
* rename structs
* fix compile error
* Refactor remaining task routes (#389)
* Implement deletion functionality for execution processes and task attempts, including recursive deletion of associated logs.
refactor: deletion process for task attempts and associated entities
feat: Refactor task and task attempt models to remove executor field
- Removed the `executor` field from the `task_attempt` model and related queries.
- Updated the `CreateTaskAndStart` struct to encapsulate task and attempt creation.
- Modified the task creation and starting logic to accommodate the new structure.
- Adjusted SQL queries and migration scripts to reflect the removal of the executor.
- Enhanced notification service to handle executor types dynamically.
- Updated TypeScript types to align with the changes in the Rust models.
refactor: remove CreateTaskAndStart type and update related code
Add TaskAttemptWithLatestProfile and alias in frontend
Fix silent failure of sqlx builder
Remove db migration
Fix rebase errors
* Remove unneeded delete logic; move common container logic to service
* Profiles fe (#398)
* Get things compiling
* Refactor the config
* WIP fix task attempt creation
* Further config fixes
* Sounds and executors in settings
* Fix sounds
* Display profile config
* Onboarding
* Remove hardcoded agents
* Move follow up attempt params to shared
* Remove further shared types
* Remove comment (#400)
* Codex (#380)
* only trigger error message when RunReason is SetupScript (#396)
* Opencode (#385)
* Restore Gemini followups (#392)
* fix task killing (#395)
* commit changes after successful execution (#403)
* Claude-code-router (#410)
* Amp tool use (#407)
* Config upgrades (#405)
* Versioned config
* Upgrade fixes
* Save config after migration
* Scoping
* Update Executor types
* Theme types fix
* Cleanup
* Change theme selector to an enum
* Rename config schema version field
* Diff improve (#412)
* Ensure container exists
* Safe handling when ExecutorAction isn't valid JSON in DB
* Reset data when endpoint changes
* refactor: conditional notification (#408)
* conditional notification
* fix next action run_reason
* remove redundant log
* Fix GitHub auth frontend (#404)
* fix frontend github auth
* Add GitHub error handling and update dependencies
- Introduced GitHubMagicErrorStrings enum for consistent error messaging related to GitHub authentication and permissions.
- Updated the GitHubService to include a check_token method for validating tokens.
- Refactored auth and task_attempts routes to utilize the new error handling.
- Added strum_macros dependency in Cargo.toml for enum display.
* Refactor GitHub error handling and API response structure to use CreateGitHubPRErrorData
* Refactor API response handling in CreatePRDialog and update attemptsApi to return structured results
* Refactor tasksApi.createAndStart to remove projectId parameter from API call
* use SCREAMING_SNAKE_CASE for consistency
* Refactor GitHub error handling to replace CreateGitHubPRErrorData with GitHubServiceError across the codebase
* Update crates/utils/src/response.rs
Co-authored-by: Gabriel Gordon-Hall <gabriel@bloop.ai>
* Fix compile error
* Fix types
---------
Co-authored-by: Gabriel Gordon-Hall <gabriel@bloop.ai>
* Fix: (#415)
- Config location
- Serve FE from BE in prod
- Create config when doesn't exist
- Tmp disable building the MCP
* Fix dev server route (#417)
* remove legacy logic and unused crates (#418)
* update CLAUDE.md for new project structure (#420)
* fix mcp settings page (#419)
* Fix cards not updating (vibe-kanban) (#416)
* Commit changes from coding agent for task attempt 774a2cae-a763-4117-af0e-1287a043c462
* Commit changes from coding agent for task attempt 774a2cae-a763-4117-af0e-1287a043c462
* Commit changes from coding agent for task attempt 774a2cae-a763-4117-af0e-1287a043c462
* feat: update task status management in container service
* refactor: simplify notification logic and finalize context checks in LocalContainerService
* Task attempt fe fixes (#422)
* Style tweaks
* Refactor
* Fix auto scroll
* Implement stop endpoint for all execution processed in a task attempt
* Weird race condition with amp
* Remove log
* Fix follow ups
* Re-add stop task attempt endpoint (#421)
* Re-add stop task attempt endpoint; remove legacy comments for implemented functionality
* Fix kill race condition; fix state change when dev server
* Ci fixes (#425)
* Eslint fix
* Remove #[ts(export)]
* Fix tests
* Clippy
* Prettier
* Fmt
* Version downgrade
* Fix API response
* Don't treat clippy warnings as errors
* Change crate name
* Update cargo location
* Update further refs
* Reset versions
* Bump versions
* Update binary names
* Branch fix
* Prettier
* Ensure finished event sends data (#434)
* use option_env! when reading analytics vars (#435)
* remove dead logic (#436)
* update crate version across workspace (#437)
* add all crates across the workspace
* chore: bump version to 0.0.56
---------
Co-authored-by: Alex Netsch <alex@bloop.ai>
Co-authored-by: Gabriel Gordon-Hall <gabriel@bloop.ai>
Co-authored-by: Solomon <abcpro11051@disroot.org>
Co-authored-by: Gabriel Gordon-Hall <ggordonhall@gmail.com>
Co-authored-by: GitHub Action <action@github.com>
