From fdb75dc7f446d511dcd72903394bcd9721125442 Mon Sep 17 00:00:00 2001 From: Britannio Jarrett <33752528+britannio@users.noreply.github.com> Date: Thu, 23 Oct 2025 10:46:50 +0100 Subject: [PATCH] Done! I've restored the custom command input field for the custom IDE option: (#1089) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ✅ Added the input field to [GeneralSettings.tsx](file:///private/var/folders/5q/5vgq75y92dz0k7n62z93299r0000gn/T/vibe-kanban/worktrees/28ec-restore-custom-c/frontend/src/pages/settings/GeneralSettings.tsx#L471-L493) that appears when Custom editor is selected ✅ Added localization strings to all languages (English, Spanish, Japanese, Korean) ✅ Type checks passed --- frontend/src/i18n/locales/en/settings.json | 4 ++++ frontend/src/i18n/locales/es/settings.json | 4 ++++ frontend/src/i18n/locales/ja/settings.json | 4 ++++ frontend/src/i18n/locales/ko/settings.json | 4 ++++ .../src/pages/settings/GeneralSettings.tsx | 24 +++++++++++++++++++ 5 files changed, 40 insertions(+) diff --git a/frontend/src/i18n/locales/en/settings.json b/frontend/src/i18n/locales/en/settings.json index b333ccec..ebabc3aa 100644 --- a/frontend/src/i18n/locales/en/settings.json +++ b/frontend/src/i18n/locales/en/settings.json @@ -53,6 +53,10 @@ "label": "Editor Type", "placeholder": "Select editor", "helper": "Choose your preferred code editor interface." + }, + "customCommand": { + "label": "Custom Editor Command", + "helper": "Enter the command to launch your custom editor. This will be used to open files." } }, "github": { diff --git a/frontend/src/i18n/locales/es/settings.json b/frontend/src/i18n/locales/es/settings.json index 8cdb89b3..5a65279d 100644 --- a/frontend/src/i18n/locales/es/settings.json +++ b/frontend/src/i18n/locales/es/settings.json @@ -53,6 +53,10 @@ "label": "Tipo de Editor", "placeholder": "Seleccionar editor", "helper": "Elige tu editor de código preferido." + }, + "customCommand": { + "label": "Comando de Editor Personalizado", + "helper": "Ingresa el comando para lanzar tu editor personalizado. Se utilizará para abrir archivos." } }, "github": { diff --git a/frontend/src/i18n/locales/ja/settings.json b/frontend/src/i18n/locales/ja/settings.json index 70652aed..c8252a30 100644 --- a/frontend/src/i18n/locales/ja/settings.json +++ b/frontend/src/i18n/locales/ja/settings.json @@ -53,6 +53,10 @@ "label": "エディタータイプ", "placeholder": "エディターを選択", "helper": "お好みのコードエディターインターフェースを選択してください。" + }, + "customCommand": { + "label": "カスタムエディターコマンド", + "helper": "カスタムエディターを起動するコマンドを入力してください。ファイルを開くために使用されます。" } }, "github": { diff --git a/frontend/src/i18n/locales/ko/settings.json b/frontend/src/i18n/locales/ko/settings.json index f75b6223..3fb82fc5 100644 --- a/frontend/src/i18n/locales/ko/settings.json +++ b/frontend/src/i18n/locales/ko/settings.json @@ -53,6 +53,10 @@ "label": "에디터 유형", "placeholder": "에디터 선택", "helper": "선호하는 코드 에디터 인터페이스를 선택하세요." + }, + "customCommand": { + "label": "사용자 정의 에디터 명령", + "helper": "사용자 정의 에디터를 실행하는 명령을 입력하세요. 파일을 여는 데 사용됩니다." } }, "github": { diff --git a/frontend/src/pages/settings/GeneralSettings.tsx b/frontend/src/pages/settings/GeneralSettings.tsx index 18f67299..dc3968a7 100644 --- a/frontend/src/pages/settings/GeneralSettings.tsx +++ b/frontend/src/pages/settings/GeneralSettings.tsx @@ -467,6 +467,30 @@ export function GeneralSettings() { {t('settings.general.editor.type.helper')}

+ + {draft?.editor.editor_type === EditorType.CUSTOM && ( +
+ + + updateDraft({ + editor: { + ...draft!.editor, + custom_command: e.target.value || null, + }, + }) + } + /> +

+ {t('settings.general.editor.customCommand.helper')} +

+
+ )}