From e73c1b4bff9b317af2c0d192757fe88a46ce8970 Mon Sep 17 00:00:00 2001 From: Alex Netsch Date: Fri, 9 Jan 2026 11:31:29 +0000 Subject: [PATCH] All done. Here's a summary of the fix: (#1875) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Summary Fixed PR comment labels showing raw translation keys instead of translated text. **Problem:** The `CommentWidgetLine.tsx` and `ReviewCommentRenderer.tsx` components were using translation keys that didn't exist in the translation files: - `comments.addReviewComment` - `comments.addPlaceholder` - `comments.editPlaceholder` - `actions.cancel` - `actions.saveChanges` - `actions.copied` **Solution:** Added the missing translation keys to `common.json` in all 6 locales: - English (en) - Spanish (es) - Japanese (ja) - Korean (ko) - Simplified Chinese (zh-Hans) - Traditional Chinese (zh-Hant) **Verification:** - ✅ `pnpm run check` passes (TypeScript and Rust checks) - ✅ i18n check script confirms translation keys are consistent across all locales - ✅ No duplicate JSON keys --- frontend/src/i18n/locales/en/common.json | 10 +++++++++- frontend/src/i18n/locales/es/common.json | 10 +++++++++- frontend/src/i18n/locales/ja/common.json | 10 +++++++++- frontend/src/i18n/locales/ko/common.json | 10 +++++++++- frontend/src/i18n/locales/zh-Hans/common.json | 10 +++++++++- frontend/src/i18n/locales/zh-Hant/common.json | 10 +++++++++- 6 files changed, 54 insertions(+), 6 deletions(-) diff --git a/frontend/src/i18n/locales/en/common.json b/frontend/src/i18n/locales/en/common.json index 3b9af1fe..518ab60e 100644 --- a/frontend/src/i18n/locales/en/common.json +++ b/frontend/src/i18n/locales/en/common.json @@ -169,7 +169,15 @@ "viewInChangesPanel": "View in changes panel", "copyPath": "Copy path", "copyWorktreePath": "Copy worktree path", - "openInIde": "Open in IDE" + "openInIde": "Open in IDE", + "cancel": "Cancel", + "saveChanges": "Save Changes", + "copied": "Copied" + }, + "comments": { + "addReviewComment": "Add Review Comment", + "addPlaceholder": "Add a comment...", + "editPlaceholder": "Edit comment..." }, "confirm": { "defaultConfirm": "Confirm", diff --git a/frontend/src/i18n/locales/es/common.json b/frontend/src/i18n/locales/es/common.json index 4982a45d..4c447dcc 100644 --- a/frontend/src/i18n/locales/es/common.json +++ b/frontend/src/i18n/locales/es/common.json @@ -169,7 +169,15 @@ "viewInChangesPanel": "Ver en panel de cambios", "copyPath": "Copiar ruta", "copyWorktreePath": "Copiar ruta del worktree", - "openInIde": "Abrir en IDE" + "openInIde": "Abrir en IDE", + "cancel": "Cancelar", + "saveChanges": "Guardar cambios", + "copied": "Copiado" + }, + "comments": { + "addReviewComment": "Agregar comentario de revisión", + "addPlaceholder": "Agregar un comentario...", + "editPlaceholder": "Editar comentario..." }, "confirm": { "defaultConfirm": "Confirmar", diff --git a/frontend/src/i18n/locales/ja/common.json b/frontend/src/i18n/locales/ja/common.json index 709a0fde..86cad25b 100644 --- a/frontend/src/i18n/locales/ja/common.json +++ b/frontend/src/i18n/locales/ja/common.json @@ -169,7 +169,15 @@ "viewInChangesPanel": "変更パネルで表示", "copyPath": "パスをコピー", "copyWorktreePath": "ワークツリーパスをコピー", - "openInIde": "IDEで開く" + "openInIde": "IDEで開く", + "cancel": "キャンセル", + "saveChanges": "変更を保存", + "copied": "コピーしました" + }, + "comments": { + "addReviewComment": "レビューコメントを追加", + "addPlaceholder": "コメントを追加...", + "editPlaceholder": "コメントを編集..." }, "confirm": { "defaultConfirm": "確認", diff --git a/frontend/src/i18n/locales/ko/common.json b/frontend/src/i18n/locales/ko/common.json index 521640dd..d881ef79 100644 --- a/frontend/src/i18n/locales/ko/common.json +++ b/frontend/src/i18n/locales/ko/common.json @@ -169,7 +169,15 @@ "viewInChangesPanel": "변경사항 패널에서 보기", "copyPath": "워크트리 경로 복사", "copyWorktreePath": "워크트리 경로 복사", - "openInIde": "IDE에서 열기" + "openInIde": "IDE에서 열기", + "cancel": "취소", + "saveChanges": "변경사항 저장", + "copied": "복사됨" + }, + "comments": { + "addReviewComment": "리뷰 코멘트 추가", + "addPlaceholder": "코멘트 추가...", + "editPlaceholder": "코멘트 편집..." }, "confirm": { "defaultConfirm": "확인", diff --git a/frontend/src/i18n/locales/zh-Hans/common.json b/frontend/src/i18n/locales/zh-Hans/common.json index a7c84d33..824c1979 100644 --- a/frontend/src/i18n/locales/zh-Hans/common.json +++ b/frontend/src/i18n/locales/zh-Hans/common.json @@ -169,7 +169,15 @@ "viewInChangesPanel": "在更改面板中查看", "copyPath": "复制路径", "copyWorktreePath": "复制工作树路径", - "openInIde": "在IDE中打开" + "openInIde": "在IDE中打开", + "cancel": "取消", + "saveChanges": "保存更改", + "copied": "已复制" + }, + "comments": { + "addReviewComment": "添加审查评论", + "addPlaceholder": "添加评论...", + "editPlaceholder": "编辑评论..." }, "confirm": { "defaultConfirm": "确认", diff --git a/frontend/src/i18n/locales/zh-Hant/common.json b/frontend/src/i18n/locales/zh-Hant/common.json index 6cf661e6..ea1136c4 100644 --- a/frontend/src/i18n/locales/zh-Hant/common.json +++ b/frontend/src/i18n/locales/zh-Hant/common.json @@ -169,7 +169,15 @@ "viewInChangesPanel": "在變更面板中檢視", "copyPath": "複製路徑", "copyWorktreePath": "複製工作樹路徑", - "openInIde": "在IDE中開啟" + "openInIde": "在IDE中開啟", + "cancel": "取消", + "saveChanges": "儲存變更", + "copied": "已複製" + }, + "comments": { + "addReviewComment": "新增審查評論", + "addPlaceholder": "新增評論...", + "editPlaceholder": "編輯評論..." }, "confirm": { "defaultConfirm": "確認",