daonanchao/vibe-kanban
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: copy images to agent_working_dir when set (#1752)

Browse Source 
* fix: copy images to agent_working_dir when set

When agent_working_dir is configured, copy images to
<workspace>/<agent_working_dir>/.vibe-images/ instead of
<workspace>/.vibe-images/ so that relative paths work
correctly for the AI agent.

Closes #1727

Signed-off-by: majiayu000 <1835304752@qq.com>

* optionally append agent working directory in other image routes

---------

Signed-off-by: majiayu000 <1835304752@qq.com>
Co-authored-by: Gabriel Gordon-Hall <ggordonhall@gmail.com>
This commit is contained in:
lif
2026-01-08 20:14:02 +08:00
committed by GitHub
parent cefb4fb0a2
commit dcaa8b8769
3 changed files with 28 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
crates/server/src/routes/task_attempts/images.rs
View File

@@ -51,9 +51,13 @@ pub async fn upload_image(
.ensure_container_exists(&workspace)
.await?;
let workspace_path = std::path::PathBuf::from(container_ref);
let base_path = match workspace.agent_working_dir.as_deref() {
Some(dir) if !dir.is_empty() => workspace_path.join(dir),
_ => workspace_path,
};
deployment
.image()
.copy_images_by_ids_to_worktree(&workspace_path, &[image_response.id])
.copy_images_by_ids_to_worktree(&base_path, &[image_response.id])
.await?;
Ok(ResponseJson(ApiResponse::success(image_response)))
@@ -95,7 +99,11 @@ pub async fn get_image_metadata(
.ensure_container_exists(&workspace)
.await?;
let workspace_path = std::path::PathBuf::from(container_ref);
let full_path = workspace_path.join(&query.path);
let base_path = match workspace.agent_working_dir.as_deref() {
Some(dir) if !dir.is_empty() => workspace_path.join(dir),
_ => workspace_path,
};
let full_path = base_path.join(&query.path);
// Check if file exists
let metadata = match tokio::fs::metadata(&full_path).await {
@@ -154,8 +162,11 @@ pub async fn serve_image(
.ensure_container_exists(&workspace)
.await?;
let workspace_path = std::path::PathBuf::from(container_ref);
let vibe_images_dir = workspace_path.join(utils::path::VIBE_IMAGES_DIR);
let base_path = match workspace.agent_working_dir.as_deref() {
Some(dir) if !dir.is_empty() => workspace_path.join(dir),
_ => workspace_path,
};
let vibe_images_dir = base_path.join(utils::path::VIBE_IMAGES_DIR);
let full_path = vibe_images_dir.join(&path);
// Security: Canonicalize and verify path is within .vibe-images