From cf078e81d142cf2cedb7c996a8b312159e3858e9 Mon Sep 17 00:00:00 2001 From: Louis Knight-Webb Date: Wed, 29 Oct 2025 12:10:03 +0000 Subject: [PATCH] Fix profiles (#1122) * fix profiles * change warn to error --- Cargo.lock | 14 +++++++------- crates/executors/src/executors/mod.rs | 11 +++++++++++ crates/executors/src/profile.rs | 2 +- 3 files changed, 19 insertions(+), 8 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index 13e52f4d..06c69160 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -933,7 +933,7 @@ checksum = "2a2330da5de22e8a3cb63252ce2abb30116bf5265e89c0e01bc17015ce30a476" [[package]] name = "db" -version = "0.0.111" +version = "0.0.112" dependencies = [ "anyhow", "async-trait", @@ -969,7 +969,7 @@ dependencies = [ [[package]] name = "deployment" -version = "0.0.111" +version = "0.0.112" dependencies = [ "anyhow", "async-trait", @@ -1261,7 +1261,7 @@ dependencies = [ [[package]] name = "executors" -version = "0.0.111" +version = "0.0.112" dependencies = [ "agent-client-protocol", "async-trait", @@ -2406,7 +2406,7 @@ dependencies = [ [[package]] name = "local-deployment" -version = "0.0.111" +version = "0.0.112" dependencies = [ "anyhow", "async-stream", @@ -4013,7 +4013,7 @@ dependencies = [ [[package]] name = "server" -version = "0.0.111" +version = "0.0.112" dependencies = [ "anyhow", "async-trait", @@ -4059,7 +4059,7 @@ dependencies = [ [[package]] name = "services" -version = "0.0.111" +version = "0.0.112" dependencies = [ "anyhow", "async-trait", @@ -5234,7 +5234,7 @@ checksum = "b6c140620e7ffbb22c2dee59cafe6084a59b5ffc27a8859a5f0d494b5d52b6be" [[package]] name = "utils" -version = "0.0.111" +version = "0.0.112" dependencies = [ "async-stream", "axum", diff --git a/crates/executors/src/executors/mod.rs b/crates/executors/src/executors/mod.rs index 58eddf71..ef900fda 100644 --- a/crates/executors/src/executors/mod.rs +++ b/crates/executors/src/executors/mod.rs @@ -79,6 +79,7 @@ pub enum CodingAgent { Codex, Opencode, #[serde(alias = "CURSOR")] + #[strum_discriminants(serde(alias = "CURSOR"))] #[strum_discriminants(strum(serialize = "CURSOR", serialize = "CURSOR_AGENT"))] CursorAgent, QwenCode, @@ -227,5 +228,15 @@ mod tests { "CURSOR should be valid for backwards compatibility" ); assert_eq!(result.unwrap(), BaseCodingAgent::CursorAgent); + + // Test serde deserialization for CURSOR_AGENT + let result: Result = serde_json::from_str(r#""CURSOR_AGENT""#); + assert!(result.is_ok(), "CURSOR_AGENT should deserialize via serde"); + assert_eq!(result.unwrap(), BaseCodingAgent::CursorAgent); + + // Test serde deserialization for legacy CURSOR + let result: Result = serde_json::from_str(r#""CURSOR""#); + assert!(result.is_ok(), "CURSOR should deserialize via serde"); + assert_eq!(result.unwrap(), BaseCodingAgent::CursorAgent); } } diff --git a/crates/executors/src/profile.rs b/crates/executors/src/profile.rs index 671c8893..188370df 100644 --- a/crates/executors/src/profile.rs +++ b/crates/executors/src/profile.rs @@ -227,7 +227,7 @@ impl ExecutorConfigs { Self::merge_with_defaults(defaults, user_overrides) } Err(e) => { - tracing::warn!( + tracing::error!( "Failed to parse user profiles.json: {}, using defaults only", e );