fix: follow up bug (#656)

* separate conds

* fmt
This commit is contained in:
Gabriel Gordon-Hall
2025-09-08 18:55:45 +01:00
committed by GitHub
parent 5a4e02d332
commit ce14ee9341

View File

@@ -108,7 +108,8 @@ export function TaskFollowUpSection({
// Get the profile from the attempt data
const selectedProfile = selectedAttemptProfile;
const canSendFollowUp = useMemo(() => {
// Separate logic for when textarea should be disabled vs when send button should be disabled
const canTypeFollowUp = useMemo(() => {
if (
!selectedAttemptId ||
attemptData.processes.length === 0 ||
@@ -127,16 +128,22 @@ export function TaskFollowUpSection({
}
}
// Allow sending if either review comments exist OR follow-up message is present
return Boolean(reviewMarkdown || followUpMessage.trim());
return true;
}, [
selectedAttemptId,
attemptData.processes,
isSendingFollowUp,
branchStatus?.merges,
reviewMarkdown,
followUpMessage,
]);
const canSendFollowUp = useMemo(() => {
if (!canTypeFollowUp) {
return false;
}
// Allow sending if either review comments exist OR follow-up message is present
return Boolean(reviewMarkdown || followUpMessage.trim());
}, [canTypeFollowUp, reviewMarkdown, followUpMessage]);
const currentProfile = useMemo(() => {
if (!selectedProfile || !profiles) return null;
return profiles?.[selectedProfile];
@@ -267,7 +274,7 @@ export function TaskFollowUpSection({
}
}}
className="flex-1 min-h-[40px] resize-none"
disabled={!canSendFollowUp}
disabled={!canTypeFollowUp}
projectId={projectId}
rows={1}
maxRows={6}