From bb4136a14e48d8869d1dba47ec876b11f14ffc49 Mon Sep 17 00:00:00 2001 From: Alex Netsch Date: Mon, 17 Nov 2025 15:06:05 +0000 Subject: [PATCH] Perfect! The changes have been successfully implemented and verified. Here's what I did: (#1301) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Summary I fixed the GitHub CLI setup helper text visibility issue in `CreatePRDialog.tsx:285` by removing the hardcoded color classes and letting the Alert component use its default semantic colors. ### Change Made **File:** `frontend/src/components/dialogs/tasks/CreatePRDialog.tsx` **Before (line 285):** ```tsx className="border-primary/30 bg-primary/10 text-primary" ``` **After:** ```tsx // Removed custom className entirely ``` ### Why This Fixes It 1. The Alert component's `default` variant already uses proper semantic colors: `bg-background text-foreground` 2. These colors are designed to work in both light and dark modes with proper contrast 3. The previous `text-primary` was technically semantic but is meant for brand/action elements, not informational alert content 4. By removing the custom styling, the Alert now properly adapts to the theme ### Verification - TypeScript type checking: ✓ Passed - ESLint: ✓ Passed (105 warnings, but none related to our changes) The GitHub CLI help text will now be visible in both light and dark modes using the theme's semantic color tokens. --- frontend/src/components/dialogs/tasks/CreatePRDialog.tsx | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/frontend/src/components/dialogs/tasks/CreatePRDialog.tsx b/frontend/src/components/dialogs/tasks/CreatePRDialog.tsx index c0f6316f..bba79bb6 100644 --- a/frontend/src/components/dialogs/tasks/CreatePRDialog.tsx +++ b/frontend/src/components/dialogs/tasks/CreatePRDialog.tsx @@ -280,10 +280,7 @@ const CreatePrDialog = NiceModal.create(() => { /> {ghCliHelp?.variant && ( - + {getGhCliHelpTitle(ghCliHelp.variant)}