This commit is contained in:
Louis Knight-Webb
2025-12-05 10:48:16 +00:00
committed by GitHub
parent 32c689dfc5
commit 89c0f1b0ef
4 changed files with 13 additions and 6 deletions

View File

@@ -25,10 +25,12 @@ const TaskAttemptPanel = ({
} }
return ( return (
<EntriesProvider> <EntriesProvider key={attempt.id}>
<RetryUiProvider attemptId={attempt.id}> <RetryUiProvider attemptId={attempt.id}>
{children({ {children({
logs: <VirtualizedList attempt={attempt} task={task} />, logs: (
<VirtualizedList key={attempt.id} attempt={attempt} task={task} />
),
followUp: ( followUp: (
<TaskFollowUpSection task={task} selectedAttemptId={attempt.id} /> <TaskFollowUpSection task={task} selectedAttemptId={attempt.id} />
), ),

View File

@@ -599,8 +599,14 @@ export function TaskFollowUpSection({
refetchAttemptBranch, refetchAttemptBranch,
]); ]);
if (!selectedAttemptId) { if (!selectedAttemptId) return null;
return null;
if (isScratchLoading) {
return (
<div className="flex items-center justify-center h-full">
<Loader2 className="animate-spin h-6 w-6" />
</div>
);
} }
return ( return (

View File

@@ -6,6 +6,5 @@ export function useTaskAttempt(attemptId?: string) {
queryKey: ['taskAttempt', attemptId], queryKey: ['taskAttempt', attemptId],
queryFn: () => attemptsApi.get(attemptId!), queryFn: () => attemptsApi.get(attemptId!),
enabled: !!attemptId, enabled: !!attemptId,
placeholderData: (previousData) => previousData,
}); });
} }

View File

@@ -287,7 +287,7 @@ export function ProjectTasks() {
}, [projectId, taskId, isLoading, selectedTask, navigate]); }, [projectId, taskId, isLoading, selectedTask, navigate]);
const effectiveAttemptId = attemptId === 'latest' ? undefined : attemptId; const effectiveAttemptId = attemptId === 'latest' ? undefined : attemptId;
const isTaskView = !!taskId && !effectiveAttemptId && attemptId !== 'latest'; const isTaskView = !!taskId && !effectiveAttemptId;
const { data: attempt } = useTaskAttempt(effectiveAttemptId); const { data: attempt } = useTaskAttempt(effectiveAttemptId);
const { data: branchStatus } = useBranchStatus(attempt?.id); const { data: branchStatus } = useBranchStatus(attempt?.id);