fix: use gitignore-aware selective watching to reduce memory usage (#1399)
* fix: skip watching heavy directories to avoid memory leak * fix: reduce memory usage in filesystem watcher for pnpm projects Use gitignore-aware directory collection to prevent OS-level watchers from being set up on heavy directories like node_modules. Changes: - Use WalkBuilder's git_ignore(true) to respect .gitignore when collecting watch directories - Use NonRecursive watch mode for each directory instead of single Recursive watch - Simplify ALWAYS_SKIP_DIRS to only contain .git (not in .gitignore but should be skipped) This fixes high memory usage when running vibe-kanban on pnpm-managed repositories, which contain many symlinks in node_modules. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * fix: simplify filesystem watcher error handling and fix clippy warnings - Remove debug logs that were added during development - Fail fast on watch errors instead of continuing in a partially broken state - Collapse nested if statements to satisfy clippy::collapsible_if 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * fix: check only parent directories in path_allowed Only check parent directory names against ALWAYS_SKIP_DIRS since should_skip_dir is meant for directories, not file names. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * fix: add watch directories changes * Stop leaking filesystem watcher Use weak references so the background thread exits once the diff stream releases the debouncer. * Memoize ignored-descendant scan Cache per-directory results so collecting watch targets stays linear. * Improve watcher gitignore classification Use real metadata when available, fall back to the old heuristic only when the file is already gone, and document the limitation. * Handle directory renames in watcher * Deduplicate watch directories more efficiently Sort once and do a single sweep instead of quadratic filtering. * Document gitignore watcher limitation * Cascade watcher removal on directory delete Drop all descendant watchers when a parent directory disappears so stale handles don’t linger. * Watch subdirectories when new directories are added Track recursive parent watchers so we skip redundant child watches and prune them when a parent becomes recursive. * Always ignore node_modules * Use a high-performance line count diff implementation The `similar` diff stat implementation was causing cpu spikes of up to 600% over 10 seconds. * exclude node_modules from git diff commands --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Solomon <abcpro11051@disroot.org>
This commit is contained in:
ukwksk
GitHub
@@ -1,25 +1,29 @@
|
||||
use std::{
|
||||
collections::{HashMap, HashSet},
|
||||
path::{Path, PathBuf},
|
||||
sync::Arc,
|
||||
sync::{Arc, Mutex},
|
||||
time::Duration,
|
||||
};
|
||||
|
||||
use futures::{
|
||||
SinkExt,
|
||||
SinkExt, StreamExt,
|
||||
channel::mpsc::{Receiver, channel},
|
||||
};
|
||||
use ignore::{
|
||||
WalkBuilder,
|
||||
gitignore::{Gitignore, GitignoreBuilder},
|
||||
};
|
||||
use notify::{RecommendedWatcher, RecursiveMode};
|
||||
use notify::{
|
||||
RecommendedWatcher, RecursiveMode,
|
||||
event::{EventKind, ModifyKind, RenameMode},
|
||||
};
|
||||
use notify_debouncer_full::{
|
||||
DebounceEventResult, DebouncedEvent, Debouncer, RecommendedCache, new_debouncer,
|
||||
};
|
||||
use thiserror::Error;
|
||||
|
||||
pub type WatcherComponents = (
|
||||
Debouncer<RecommendedWatcher, RecommendedCache>,
|
||||
Arc<Mutex<Debouncer<RecommendedWatcher, RecommendedCache>>>,
|
||||
Receiver<DebounceEventResult>,
|
||||
PathBuf,
|
||||
);
|
||||
@@ -42,16 +46,43 @@ fn canonicalize_lossy(path: &Path) -> PathBuf {
|
||||
dunce::canonicalize(path).unwrap_or_else(|_| path.to_path_buf())
|
||||
}
|
||||
|
||||
/// Directories that should always be skipped regardless of gitignore.
|
||||
/// .git is not in .gitignore but should never be watched.
|
||||
pub const ALWAYS_SKIP_DIRS: &[&str] = &[".git", "node_modules"];
|
||||
|
||||
fn should_skip_dir(name: &str) -> bool {
|
||||
ALWAYS_SKIP_DIRS.contains(&name)
|
||||
}
|
||||
|
||||
/// Check if the platform supports efficient native recursive watching.
|
||||
/// macOS (FSEvents) and Windows (ReadDirectoryChangesW) support recursive watching natively.
|
||||
/// Linux (inotify) does not - it requires a watch descriptor per directory.
|
||||
fn platform_supports_native_recursive() -> bool {
|
||||
cfg!(target_os = "macos") || cfg!(target_os = "windows")
|
||||
}
|
||||
|
||||
fn build_gitignore_set(root: &Path) -> Result<Gitignore, FilesystemWatcherError> {
|
||||
let mut builder = GitignoreBuilder::new(root);
|
||||
|
||||
// Walk once to collect all .gitignore files under root
|
||||
// Use git_ignore(true) to avoid walking into gitignored directories
|
||||
WalkBuilder::new(root)
|
||||
.follow_links(false)
|
||||
.hidden(false) // we *want* to see .gitignore
|
||||
.git_ignore(true) // Respect gitignore to skip heavy directories
|
||||
.filter_entry(|entry| {
|
||||
let is_dir = entry.file_type().map(|ft| ft.is_dir()).unwrap_or(false);
|
||||
|
||||
// Skip .git directory
|
||||
if is_dir
|
||||
&& let Some(name) = entry.file_name().to_str()
|
||||
&& should_skip_dir(name)
|
||||
{
|
||||
return false;
|
||||
}
|
||||
|
||||
// only recurse into directories and .gitignore files
|
||||
entry.file_type().map(|ft| ft.is_dir()).unwrap_or(false)
|
||||
is_dir
|
||||
|| entry
|
||||
.file_name()
|
||||
.to_str()
|
||||
@@ -101,9 +132,27 @@ fn path_allowed(path: &Path, gi: &Gitignore, canonical_root: &Path) -> bool {
|
||||
}
|
||||
};
|
||||
|
||||
// Heuristic: assume paths without extensions are directories
|
||||
// This works for most cases and avoids filesystem syscalls
|
||||
let is_dir = relative_path.extension().is_none();
|
||||
// Check if path is inside any of the always-skip directories
|
||||
if let Some(parent) = relative_path.parent() {
|
||||
for component in parent.components() {
|
||||
if let std::path::Component::Normal(name) = component
|
||||
&& let Some(name_str) = name.to_str()
|
||||
&& should_skip_dir(name_str)
|
||||
{
|
||||
return false;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
let is_dir = if let Ok(metadata) = std::fs::metadata(&canonical_path) {
|
||||
metadata.is_dir()
|
||||
} else {
|
||||
// File may already be gone (e.g., remove event). Fall back to the
|
||||
// old extension heuristic so directory-only rules still match.
|
||||
// FIXME: capture file-type information earlier (e.g., when we add
|
||||
// watches) so we don't have to guess after the fact.
|
||||
relative_path.extension().is_none()
|
||||
};
|
||||
let matched = gi.matched_path_or_any_parents(relative_path, is_dir);
|
||||
|
||||
!matched.is_ignore()
|
||||
@@ -122,45 +171,453 @@ fn debounced_should_forward(event: &DebouncedEvent, gi: &Gitignore, canonical_ro
|
||||
.all(|path| path_allowed(path, gi, canonical_root))
|
||||
}
|
||||
|
||||
/// Represents a directory to watch with its recursive mode.
|
||||
#[derive(Debug, Clone)]
|
||||
struct WatchTarget {
|
||||
path: PathBuf,
|
||||
recursive: RecursiveMode,
|
||||
}
|
||||
|
||||
#[derive(Default)]
|
||||
struct WatchedDirs {
|
||||
all: HashSet<PathBuf>,
|
||||
recursive: HashSet<PathBuf>,
|
||||
}
|
||||
|
||||
impl WatchedDirs {
|
||||
fn contains(&self, path: &Path) -> bool {
|
||||
self.all.contains(path)
|
||||
}
|
||||
|
||||
fn has_recursive_cover(&self, path: &Path) -> bool {
|
||||
self.recursive
|
||||
.iter()
|
||||
.any(|ancestor| ancestor != path && path.starts_with(ancestor))
|
||||
}
|
||||
|
||||
fn insert(&mut self, path: PathBuf, mode: RecursiveMode) {
|
||||
if matches!(mode, RecursiveMode::Recursive) {
|
||||
self.recursive.insert(path.clone());
|
||||
} else {
|
||||
self.recursive.remove(&path);
|
||||
}
|
||||
self.all.insert(path);
|
||||
}
|
||||
|
||||
fn remove_dir_and_children<F>(&mut self, prefix: &Path, f: F)
|
||||
where
|
||||
F: FnMut(&Path),
|
||||
{
|
||||
self.remove_with_prefix(prefix, true, f);
|
||||
}
|
||||
|
||||
fn remove_children_only<F>(&mut self, prefix: &Path, f: F)
|
||||
where
|
||||
F: FnMut(&Path),
|
||||
{
|
||||
self.remove_with_prefix(prefix, false, f);
|
||||
}
|
||||
|
||||
fn remove_with_prefix<F>(&mut self, prefix: &Path, include_prefix: bool, mut f: F)
|
||||
where
|
||||
F: FnMut(&Path),
|
||||
{
|
||||
let to_remove: Vec<PathBuf> = self
|
||||
.all
|
||||
.iter()
|
||||
.filter(|path| path.starts_with(prefix) && (include_prefix || *path != prefix))
|
||||
.cloned()
|
||||
.collect();
|
||||
|
||||
for path in to_remove {
|
||||
self.all.remove(&path);
|
||||
self.recursive.remove(&path);
|
||||
f(&path);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/// Check if a directory or any of its descendants has gitignored directories.
|
||||
/// Used on macOS/Windows to determine if we can watch recursively.
|
||||
///
|
||||
/// This checks recursively to ensure we don't use Recursive mode on a directory
|
||||
/// that has gitignored descendants (e.g., packages/app1/node_modules).
|
||||
fn has_ignored_descendants(
|
||||
dir: &Path,
|
||||
gi: &Gitignore,
|
||||
canonical_root: &Path,
|
||||
allowed_dirs: &std::collections::HashSet<PathBuf>,
|
||||
cache: &mut HashMap<PathBuf, bool>,
|
||||
) -> bool {
|
||||
let key = dir.to_path_buf();
|
||||
if let Some(&cached) = cache.get(&key) {
|
||||
return cached;
|
||||
}
|
||||
|
||||
// Read immediate children
|
||||
let result = (|| {
|
||||
let Ok(entries) = std::fs::read_dir(dir) else {
|
||||
return false;
|
||||
};
|
||||
|
||||
for entry in entries.flatten() {
|
||||
let Ok(file_type) = entry.file_type() else {
|
||||
continue;
|
||||
};
|
||||
|
||||
if !file_type.is_dir() {
|
||||
continue;
|
||||
}
|
||||
|
||||
let path = entry.path();
|
||||
|
||||
// Check if this subdirectory should be skipped
|
||||
if let Some(name) = path.file_name().and_then(|n| n.to_str())
|
||||
&& should_skip_dir(name)
|
||||
{
|
||||
return true;
|
||||
}
|
||||
|
||||
// If it's not in allowed_dirs, it means WalkBuilder skipped it (gitignored)
|
||||
if !allowed_dirs.contains(&path) && !path_allowed(&path, gi, canonical_root) {
|
||||
return true;
|
||||
}
|
||||
|
||||
if has_ignored_descendants(&path, gi, canonical_root, allowed_dirs, cache) {
|
||||
return true;
|
||||
}
|
||||
}
|
||||
false
|
||||
})();
|
||||
|
||||
cache.insert(key, result);
|
||||
result
|
||||
}
|
||||
|
||||
/// Collect directories to watch, respecting gitignore and excluding .git.
|
||||
/// On macOS/Windows, use recursive mode for directories without ignored subdirectories.
|
||||
/// On Linux, use non-recursive mode for all directories.
|
||||
fn collect_watch_directories(root: &Path, gi: &Gitignore) -> Vec<WatchTarget> {
|
||||
let use_recursive = platform_supports_native_recursive();
|
||||
|
||||
let mut allowed_dirs: Vec<PathBuf> = WalkBuilder::new(root)
|
||||
.follow_links(false)
|
||||
.hidden(false)
|
||||
.git_ignore(true) // Respect gitignore to skip node_modules, target, etc.
|
||||
.filter_entry(|entry| {
|
||||
let is_dir = entry.file_type().map(|ft| ft.is_dir()).unwrap_or(false);
|
||||
if !is_dir {
|
||||
return false;
|
||||
}
|
||||
|
||||
if let Some(name) = entry.file_name().to_str()
|
||||
&& should_skip_dir(name)
|
||||
{
|
||||
return false;
|
||||
}
|
||||
|
||||
true
|
||||
})
|
||||
.build()
|
||||
.filter_map(|result| result.ok())
|
||||
.filter(|entry| entry.file_type().map(|ft| ft.is_dir()).unwrap_or(false))
|
||||
.map(|entry| entry.into_path())
|
||||
.collect();
|
||||
|
||||
allowed_dirs.sort();
|
||||
|
||||
let allowed_dirs_set: HashSet<PathBuf> = allowed_dirs.iter().cloned().collect();
|
||||
let mut ignored_cache = HashMap::new();
|
||||
let mut ancestor_stack: Vec<(PathBuf, bool)> = Vec::new();
|
||||
|
||||
allowed_dirs
|
||||
.into_iter()
|
||||
.filter_map(|path| {
|
||||
while ancestor_stack
|
||||
.last()
|
||||
.is_some_and(|(ancestor, _)| !path.starts_with(ancestor))
|
||||
{
|
||||
ancestor_stack.pop();
|
||||
}
|
||||
|
||||
if ancestor_stack
|
||||
.last()
|
||||
.is_some_and(|(_, is_recursive)| *is_recursive)
|
||||
{
|
||||
return None;
|
||||
}
|
||||
|
||||
let recursive_mode = if use_recursive {
|
||||
if has_ignored_descendants(&path, gi, root, &allowed_dirs_set, &mut ignored_cache) {
|
||||
RecursiveMode::NonRecursive
|
||||
} else {
|
||||
RecursiveMode::Recursive
|
||||
}
|
||||
} else {
|
||||
RecursiveMode::NonRecursive
|
||||
};
|
||||
|
||||
let is_recursive = matches!(recursive_mode, RecursiveMode::Recursive);
|
||||
ancestor_stack.push((path.clone(), is_recursive));
|
||||
|
||||
Some(WatchTarget {
|
||||
path,
|
||||
recursive: recursive_mode,
|
||||
})
|
||||
})
|
||||
.collect()
|
||||
}
|
||||
|
||||
/// Helper to determine watch mode for a directory (used for dynamically added directories).
|
||||
/// This does a simple check of immediate children only, since we don't have the full
|
||||
/// allowed_dirs set at runtime.
|
||||
fn determine_watch_mode(path: &Path, gi: &Gitignore, canonical_root: &Path) -> RecursiveMode {
|
||||
if !platform_supports_native_recursive() {
|
||||
return RecursiveMode::NonRecursive;
|
||||
}
|
||||
|
||||
let Ok(entries) = std::fs::read_dir(path) else {
|
||||
return RecursiveMode::Recursive;
|
||||
};
|
||||
|
||||
for entry in entries.flatten() {
|
||||
let Ok(file_type) = entry.file_type() else {
|
||||
continue;
|
||||
};
|
||||
|
||||
if !file_type.is_dir() {
|
||||
continue;
|
||||
}
|
||||
|
||||
let child_path = entry.path();
|
||||
|
||||
if let Some(name) = child_path.file_name().and_then(|n| n.to_str())
|
||||
&& should_skip_dir(name)
|
||||
{
|
||||
return RecursiveMode::NonRecursive;
|
||||
}
|
||||
|
||||
if !path_allowed(&child_path, gi, canonical_root) {
|
||||
return RecursiveMode::NonRecursive;
|
||||
}
|
||||
}
|
||||
|
||||
RecursiveMode::Recursive
|
||||
}
|
||||
|
||||
/// Add a watch for a newly created directory
|
||||
fn add_directory_watch(
|
||||
debouncer: &mut Debouncer<RecommendedWatcher, RecommendedCache>,
|
||||
watched_dirs: &mut WatchedDirs,
|
||||
dir_path: &Path,
|
||||
gi: &Gitignore,
|
||||
canonical_root: &Path,
|
||||
) {
|
||||
let canonical_dir = canonicalize_lossy(dir_path);
|
||||
|
||||
if !path_allowed(&canonical_dir, gi, canonical_root) {
|
||||
return;
|
||||
}
|
||||
|
||||
if watched_dirs.contains(&canonical_dir) || watched_dirs.has_recursive_cover(&canonical_dir) {
|
||||
return;
|
||||
}
|
||||
|
||||
let mode = determine_watch_mode(&canonical_dir, gi, canonical_root);
|
||||
|
||||
if let Err(e) = debouncer.watch(&canonical_dir, mode) {
|
||||
tracing::warn!("Failed to watch new directory {:?}: {}", canonical_dir, e);
|
||||
} else {
|
||||
if matches!(mode, RecursiveMode::Recursive) {
|
||||
watched_dirs.remove_children_only(&canonical_dir, |child| {
|
||||
if let Err(err) = debouncer.unwatch(child) {
|
||||
tracing::warn!("Could not unwatch covered directory {:?}: {}", child, err);
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
watched_dirs.insert(canonical_dir, mode);
|
||||
}
|
||||
}
|
||||
|
||||
/// Remove a watch for a deleted directory
|
||||
fn remove_directory_watch(
|
||||
debouncer: &mut Debouncer<RecommendedWatcher, RecommendedCache>,
|
||||
watched_dirs: &mut WatchedDirs,
|
||||
dir_path: &Path,
|
||||
) {
|
||||
let canonical_dir = canonicalize_lossy(dir_path);
|
||||
|
||||
watched_dirs.remove_dir_and_children(&canonical_dir, |path| {
|
||||
if let Err(e) = debouncer.unwatch(path) {
|
||||
tracing::warn!("Could not unwatch deleted directory {:?}: {}", path, e);
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
pub fn async_watcher(root: PathBuf) -> Result<WatcherComponents, FilesystemWatcherError> {
|
||||
let canonical_root = canonicalize_lossy(&root);
|
||||
let gi_set = Arc::new(build_gitignore_set(&canonical_root)?);
|
||||
let (mut tx, rx) = channel(64); // Increased capacity for error bursts
|
||||
// NOTE: changes to .gitignore aren’t picked up until the watcher is rebuilt.
|
||||
// Recomputing on every change would require rebuilding the full watcher fleet.
|
||||
|
||||
let (mut raw_tx, mut raw_rx) = channel::<DebounceEventResult>(64);
|
||||
let (mut filtered_tx, filtered_rx) = channel::<DebounceEventResult>(64);
|
||||
|
||||
let gi_clone = gi_set.clone();
|
||||
let root_clone = canonical_root.clone();
|
||||
let root_for_task = canonical_root.clone();
|
||||
|
||||
let mut debouncer = new_debouncer(
|
||||
let debouncer_unwrapped = new_debouncer(
|
||||
Duration::from_millis(200),
|
||||
None, // Use default config
|
||||
None,
|
||||
move |res: DebounceEventResult| {
|
||||
match res {
|
||||
futures::executor::block_on(async {
|
||||
raw_tx.send(res).await.ok();
|
||||
});
|
||||
},
|
||||
)?;
|
||||
|
||||
let debouncer = Arc::new(Mutex::new(debouncer_unwrapped));
|
||||
let debouncer_for_init = debouncer.clone();
|
||||
let debouncer_for_task = Arc::downgrade(&debouncer);
|
||||
|
||||
let watched_dirs: Arc<Mutex<WatchedDirs>> = Arc::new(Mutex::new(WatchedDirs::default()));
|
||||
let watched_dirs_for_task = watched_dirs.clone();
|
||||
|
||||
let watch_targets = collect_watch_directories(&canonical_root, &gi_set);
|
||||
{
|
||||
let mut debouncer_guard = debouncer_for_init.lock().unwrap();
|
||||
let mut watched = watched_dirs.lock().unwrap();
|
||||
|
||||
for target in &watch_targets {
|
||||
if let Err(e) = debouncer_guard.watch(&target.path, target.recursive) {
|
||||
tracing::warn!("Failed to watch {:?}: {}", target.path, e);
|
||||
} else {
|
||||
watched.insert(target.path.clone(), target.recursive);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
std::thread::spawn(move || {
|
||||
while let Some(result) = futures::executor::block_on(async { raw_rx.next().await }) {
|
||||
let Some(debouncer_arc) = debouncer_for_task.upgrade() else {
|
||||
break;
|
||||
};
|
||||
|
||||
match result {
|
||||
Ok(events) => {
|
||||
// Filter events and only send allowed ones
|
||||
let mut debouncer_guard = debouncer_arc.lock().unwrap();
|
||||
let mut watched = watched_dirs_for_task.lock().unwrap();
|
||||
|
||||
for event in &events {
|
||||
if event.kind.is_create() {
|
||||
for path in &event.paths {
|
||||
if path.is_dir() {
|
||||
add_directory_watch(
|
||||
&mut debouncer_guard,
|
||||
&mut watched,
|
||||
path,
|
||||
&gi_clone,
|
||||
&root_for_task,
|
||||
);
|
||||
}
|
||||
}
|
||||
} else if event.kind.is_remove() {
|
||||
for path in &event.paths {
|
||||
remove_directory_watch(&mut debouncer_guard, &mut watched, path);
|
||||
}
|
||||
} else if let EventKind::Modify(ModifyKind::Name(mode)) = &event.kind {
|
||||
match mode {
|
||||
RenameMode::From => {
|
||||
for path in &event.paths {
|
||||
remove_directory_watch(
|
||||
&mut debouncer_guard,
|
||||
&mut watched,
|
||||
path,
|
||||
);
|
||||
}
|
||||
}
|
||||
RenameMode::To => {
|
||||
for path in &event.paths {
|
||||
if path.is_dir() {
|
||||
add_directory_watch(
|
||||
&mut debouncer_guard,
|
||||
&mut watched,
|
||||
path,
|
||||
&gi_clone,
|
||||
&root_for_task,
|
||||
);
|
||||
}
|
||||
}
|
||||
}
|
||||
RenameMode::Both => {
|
||||
if let Some((from, rest)) = event.paths.split_first() {
|
||||
remove_directory_watch(
|
||||
&mut debouncer_guard,
|
||||
&mut watched,
|
||||
from,
|
||||
);
|
||||
|
||||
if let Some(to) = rest.last()
|
||||
&& to.is_dir()
|
||||
{
|
||||
add_directory_watch(
|
||||
&mut debouncer_guard,
|
||||
&mut watched,
|
||||
to,
|
||||
&gi_clone,
|
||||
&root_for_task,
|
||||
);
|
||||
}
|
||||
}
|
||||
}
|
||||
RenameMode::Any | RenameMode::Other => {
|
||||
for path in &event.paths {
|
||||
remove_directory_watch(
|
||||
&mut debouncer_guard,
|
||||
&mut watched,
|
||||
path,
|
||||
);
|
||||
}
|
||||
|
||||
for path in &event.paths {
|
||||
if path.is_dir() {
|
||||
add_directory_watch(
|
||||
&mut debouncer_guard,
|
||||
&mut watched,
|
||||
path,
|
||||
&gi_clone,
|
||||
&root_for_task,
|
||||
);
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
drop(debouncer_guard);
|
||||
drop(watched);
|
||||
|
||||
let filtered_events: Vec<DebouncedEvent> = events
|
||||
.into_iter()
|
||||
.filter(|ev| debounced_should_forward(ev, &gi_clone, &root_clone))
|
||||
.filter(|ev| debounced_should_forward(ev, &gi_set, &root_for_task))
|
||||
.collect();
|
||||
|
||||
if !filtered_events.is_empty() {
|
||||
let filtered_result = Ok(filtered_events);
|
||||
futures::executor::block_on(async {
|
||||
tx.send(filtered_result).await.ok();
|
||||
filtered_tx.send(Ok(filtered_events)).await.ok();
|
||||
});
|
||||
}
|
||||
}
|
||||
Err(errors) => {
|
||||
// Always forward errors
|
||||
futures::executor::block_on(async {
|
||||
tx.send(Err(errors)).await.ok();
|
||||
filtered_tx.send(Err(errors)).await.ok();
|
||||
});
|
||||
}
|
||||
}
|
||||
},
|
||||
)?;
|
||||
}
|
||||
});
|
||||
|
||||
// Start watching the root directory
|
||||
debouncer.watch(&canonical_root, RecursiveMode::Recursive)?;
|
||||
|
||||
Ok((debouncer, rx, canonical_root))
|
||||
Ok((debouncer, filtered_rx, canonical_root))
|
||||
}
|
||||
|
||||
@@ -24,7 +24,7 @@ use std::{
|
||||
use thiserror::Error;
|
||||
use utils::shell::resolve_executable_path_blocking; // TODO: make GitCli async
|
||||
|
||||
use crate::services::git::Commit;
|
||||
use crate::services::{filesystem_watcher::ALWAYS_SKIP_DIRS, git::Commit};
|
||||
|
||||
#[derive(Debug, Error)]
|
||||
pub enum GitCliError {
|
||||
@@ -156,7 +156,11 @@ impl GitCli {
|
||||
let _ = self.git_with_env(worktree_path, ["read-tree", "HEAD"], &envs)?;
|
||||
|
||||
// Stage all in temp index
|
||||
let _ = self.git_with_env(worktree_path, ["add", "-A"], &envs)?;
|
||||
let _ = self.git_with_env(
|
||||
worktree_path,
|
||||
Self::apply_default_excludes(["add", "-A"]),
|
||||
&envs,
|
||||
)?;
|
||||
|
||||
// git diff --cached
|
||||
let mut args: Vec<OsString> = vec![
|
||||
@@ -168,19 +172,7 @@ impl GitCli {
|
||||
"--name-status".into(),
|
||||
OsString::from(base_commit.to_string()),
|
||||
];
|
||||
if let Some(paths) = &opts.path_filter {
|
||||
let non_empty_paths: Vec<&str> = paths
|
||||
.iter()
|
||||
.map(|s| s.as_str())
|
||||
.filter(|p| !p.trim().is_empty())
|
||||
.collect();
|
||||
if !non_empty_paths.is_empty() {
|
||||
args.push("--".into());
|
||||
for p in non_empty_paths {
|
||||
args.push(OsString::from(p));
|
||||
}
|
||||
}
|
||||
}
|
||||
args = Self::apply_pathspec_filter(args, opts.path_filter.as_ref());
|
||||
let out = self.git_with_env(worktree_path, args, &envs)?;
|
||||
Ok(Self::parse_name_status(&out))
|
||||
}
|
||||
@@ -243,9 +235,13 @@ impl GitCli {
|
||||
|
||||
/// Stage all changes in the working tree (respects sparse-checkout semantics).
|
||||
pub fn add_all(&self, worktree_path: &Path) -> Result<(), GitCliError> {
|
||||
self.git(worktree_path, ["add", "-A"])?;
|
||||
self.git(
|
||||
worktree_path,
|
||||
Self::apply_default_excludes(vec!["add", "-A"]),
|
||||
)?;
|
||||
Ok(())
|
||||
}
|
||||
|
||||
pub fn list_worktrees(&self, repo_path: &Path) -> Result<Vec<WorktreeEntry>, GitCliError> {
|
||||
let out = self.git(repo_path, ["worktree", "list", "--porcelain"])?;
|
||||
let mut entries = Vec::new();
|
||||
@@ -689,6 +685,7 @@ impl GitCli {
|
||||
for a in args {
|
||||
cmd.arg(a);
|
||||
}
|
||||
tracing::debug!("Running git command: {:?}", cmd);
|
||||
let out = cmd
|
||||
.output()
|
||||
.map_err(|e| GitCliError::CommandFailed(e.to_string()))?;
|
||||
@@ -705,6 +702,49 @@ impl GitCli {
|
||||
}
|
||||
Ok(String::from_utf8_lossy(&out.stdout).to_string())
|
||||
}
|
||||
|
||||
fn apply_default_excludes<I, S>(args: I) -> Vec<OsString>
|
||||
where
|
||||
I: IntoIterator<Item = S>,
|
||||
S: AsRef<OsStr>,
|
||||
{
|
||||
Self::apply_pathspec_filter(args, None)
|
||||
}
|
||||
|
||||
fn apply_pathspec_filter<I, S>(args: I, pathspecs: Option<&Vec<String>>) -> Vec<OsString>
|
||||
where
|
||||
I: IntoIterator<Item = S>,
|
||||
S: AsRef<OsStr>,
|
||||
{
|
||||
let filters = Self::build_pathspec_filter(pathspecs);
|
||||
let mut args = args
|
||||
.into_iter()
|
||||
.map(|s| s.as_ref().to_os_string())
|
||||
.collect::<Vec<_>>();
|
||||
if !filters.is_empty() {
|
||||
args.push("--".into());
|
||||
args.extend(filters);
|
||||
}
|
||||
args
|
||||
}
|
||||
|
||||
fn build_pathspec_filter(pathspecs: Option<&Vec<String>>) -> Vec<OsString> {
|
||||
let mut filters = Vec::new();
|
||||
filters.extend(
|
||||
ALWAYS_SKIP_DIRS
|
||||
.iter()
|
||||
.map(|d| OsString::from(format!(":(glob,exclude)**/{d}/"))),
|
||||
);
|
||||
if let Some(pathspecs) = pathspecs {
|
||||
for p in pathspecs {
|
||||
if p.trim().is_empty() {
|
||||
continue;
|
||||
}
|
||||
filters.push(OsString::from(p));
|
||||
}
|
||||
}
|
||||
filters
|
||||
}
|
||||
}
|
||||
/// Parsed entry from `git status --porcelain`
|
||||
#[derive(Debug, Clone, PartialEq, Eq)]
|
||||
|
||||
Reference in New Issue
Block a user