i18n check detaches local git (vibe-kanban) (#967)

* Done! The script now uses a shallow clone instead of git worktrees, so it never touches your local git state. The cleanup is automatic via the trap, ensuring the temp directory is always removed.

* Done! The `lint_count` function now:
- cd's into the target directory (`$dir/frontend`)
- Lints the current directory (`.`)
- Uses `--prefix` to ensure ESLint uses the PR workspace's dependencies

This is clearer and fixes the empty PR_COUNT issue.

scripts/check-i18n.sh

@@ -4,7 +4,6 @@
 # Initial implementation: This script will show high violation counts until enforcement is enabled
 set -eo pipefail
 
-WORKTREE_BASE="$(mktemp -d)"
 RULE="i18next/no-literal-string"
 
 # Function that outputs violation count to stdout
@@ -17,9 +16,9 @@ lint_count() {
   
   (
     set -eo pipefail
-    cd "$REPO_ROOT/frontend"
-    # Use ESLint from main workspace but lint files in the target directory
-    LINT_I18N=true npx eslint "$dir/frontend" \
+    cd "$dir/frontend"
+    # Lint current directory using ESLint from PR workspace
+    LINT_I18N=true npx --prefix "$REPO_ROOT/frontend" eslint . \
       --ext ts,tsx \
       --format json \
       --output-file "$tmp" \
@@ -30,7 +29,7 @@ lint_count() {
   # Parse the clean JSON file
   jq --arg RULE "$RULE" \
      '[.[].messages[] | select(.ruleId == $RULE)] | length' "$tmp" \
-     || echo "0"
+     2>/dev/null || echo "0"
 }
 
 get_json_keys() {
@@ -138,26 +137,19 @@ REPO_ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
 PR_COUNT=$(lint_count "$REPO_ROOT")
 
 BASE_REF="${GITHUB_BASE_REF:-main}"
-echo "▶️  Checking out $BASE_REF for baseline..."
-git fetch --depth=1 origin "$BASE_REF" 2>/dev/null || git fetch --depth=1 origin "$BASE_REF"
-git worktree add "$WORKTREE_BASE" "origin/$BASE_REF" 2>/dev/null || {
-  echo "Could not create worktree, falling back to direct checkout"
-  TEMP_BRANCH="temp-i18n-check-$$"
-  git checkout -b "$TEMP_BRANCH" "origin/$BASE_REF" 2>/dev/null || git checkout "origin/$BASE_REF"
-  BASE_COUNT=$(lint_count "$REPO_ROOT")
-  git checkout - 2>/dev/null || true
-  git branch -D "$TEMP_BRANCH" 2>/dev/null || true
-}
+echo "▶️  Fetching $BASE_REF for baseline (shallow clone)..."
+REMOTE_URL=$(git -C "$REPO_ROOT" remote get-url origin)
+BASE_DIR="$(mktemp -d)"
+cleanup_base() { rm -rf "$BASE_DIR"; }
+trap cleanup_base EXIT
 
-# Get base count from worktree if it was created successfully
-if [ -d "$WORKTREE_BASE" ]; then
-  BASE_COUNT=$(lint_count "$WORKTREE_BASE")
-  git worktree remove "$WORKTREE_BASE" 2>/dev/null || rm -rf "$WORKTREE_BASE"
+if git clone --depth=1 --branch "$BASE_REF" --single-branch "$REMOTE_URL" "$BASE_DIR" >/dev/null 2>&1; then
+  BASE_COUNT=$(lint_count "$BASE_DIR")
+else
+  echo "⚠️  Could not clone $BASE_REF; defaulting baseline to 0."
+  BASE_COUNT=0
 fi
 
-# Ensure BASE_COUNT has a value
-BASE_COUNT="${BASE_COUNT:-0}"
-
 echo ""
 echo "📊 I18n Violation Summary:"
 echo "   Base branch ($BASE_REF): $BASE_COUNT violations"