Pre release doesn't update lockfile (Vibe Kanban) (#1123)
* ## Problem Analysis The workflow runs `cargo set-version` (line 103) which updates Cargo.lock, but the git commit (lines 113-114) doesn't stage Cargo.lock—only the package.json files and Cargo.toml files. ## Proposed Fix **Simplest approach:** Add `Cargo.lock` to line 113: ```yaml git add package.json pnpm-lock.yaml npx-cli/package.json frontend/package.json Cargo.lock git add $(find . -name Cargo.toml) ``` **Optional enhancement:** Run `cargo generate-lockfile` after `cargo set-version` (line 103) to ensure the lockfile is fully regenerated. The Oracle confirmed this is correct. Ready to proceed? * Done! I've fixed the pre-release workflow by: 1. Adding `Cargo.lock` to the `git add` command (line 113) 2. Adding `cargo generate-lockfile` after `cargo set-version` (line 104) to ensure the lockfile is properly regenerated This ensures Cargo.lock gets committed with all the version changes. * Done! Removed the `cargo generate-lockfile` line.
This commit is contained in:
committed by
GitHub
parent
5805ab9fc9
commit
0e2653a2c3
2
.github/workflows/pre-release.yml
vendored
2
.github/workflows/pre-release.yml
vendored
@@ -110,7 +110,7 @@ jobs:
|
||||
run: |
|
||||
git config --local user.email "action@github.com"
|
||||
git config --local user.name "GitHub Action"
|
||||
git add package.json pnpm-lock.yaml npx-cli/package.json frontend/package.json
|
||||
git add package.json pnpm-lock.yaml npx-cli/package.json frontend/package.json Cargo.lock
|
||||
git add $(find . -name Cargo.toml)
|
||||
git commit -m "chore: bump version to ${{ steps.version.outputs.new_version }}"
|
||||
git tag -a ${{ steps.version.outputs.new_tag }} -m "Release ${{ steps.version.outputs.new_tag }}"
|
||||
|
||||
Reference in New Issue
Block a user