From 0c8426ce7238be6fdf7f3dce4b271f69d1e8f388 Mon Sep 17 00:00:00 2001 From: Gabriel Gordon-Hall Date: Tue, 7 Oct 2025 14:24:49 +0100 Subject: [PATCH] Removed the diff view toggle from conversation diff entries so they always render inline, simplifying the conversation log UI. (#959) **Changes** - `frontend/src/components/NormalizedConversation/EditDiffRenderer.tsx:14` drops the global diff-mode store and toggle import so the conversation view no longer renders the inline/split selector bar. - `frontend/src/components/NormalizedConversation/EditDiffRenderer.tsx:119` locks `DiffView` to `DiffModeEnum.Unified`, guaranteeing inline diffs regardless of other toggles elsewhere. **Tests** - `pnpm run frontend:check` (fails: repository missing `node_modules`; `tsc` command unavailable). **Next Steps** 1. Reinstall frontend dependencies and rerun `pnpm run frontend:check` to verify the TypeScript build. --- .../NormalizedConversation/EditDiffRenderer.tsx | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/frontend/src/components/NormalizedConversation/EditDiffRenderer.tsx b/frontend/src/components/NormalizedConversation/EditDiffRenderer.tsx index 11b3019c..c7da1c7f 100644 --- a/frontend/src/components/NormalizedConversation/EditDiffRenderer.tsx +++ b/frontend/src/components/NormalizedConversation/EditDiffRenderer.tsx @@ -11,8 +11,6 @@ import { getHighLightLanguageFromPath } from '@/utils/extToLanguage'; import { getActualTheme } from '@/utils/theme'; import '@/styles/diff-style-overrides.css'; import '@/styles/edit-diff-overrides.css'; -import { useDiffViewMode } from '@/stores/useDiffViewStore'; -import DiffViewSwitch from '@/components/diff-view-switch'; import { cn } from '@/lib/utils'; type Props = { @@ -77,8 +75,6 @@ function EditDiffRenderer({ const effectiveExpanded = forceExpanded || expanded; const theme = getActualTheme(config?.theme); - const globalMode = useDiffViewMode(); - const { hunks, hideLineNumbers, additions, deletions, isValidDiff } = useMemo( () => processUnifiedDiff(unifiedDiff, hasLineNumbers), [path, unifiedDiff, hasLineNumbers] @@ -121,20 +117,13 @@ function EditDiffRenderer({ {effectiveExpanded && (
-
- -
{isValidDiff ? ( ) : (