From 053d5513d694869c84dca2c959f7e0e300164f0e Mon Sep 17 00:00:00 2001
From: Louis Knight-Webb <louis@bloop.ai>
Date: Sun, 22 Jun 2025 21:31:18 +0100
Subject: [PATCH] Task attempt 5b1ff1ea-5eac-4b84-9ce5-c94932e6d99a - Final
 changes

---
 .../src/components/tasks/TaskDetailsPanel.tsx | 22 +++++++++----------
 frontend/src/lib/keyboard-shortcuts.ts        |  5 +++--
 2 files changed, 13 insertions(+), 14 deletions(-)

diff --git a/frontend/src/components/tasks/TaskDetailsPanel.tsx b/frontend/src/components/tasks/TaskDetailsPanel.tsx
index f97866d3..649f1846 100644
--- a/frontend/src/components/tasks/TaskDetailsPanel.tsx
+++ b/frontend/src/components/tasks/TaskDetailsPanel.tsx
@@ -1,4 +1,5 @@
 import { useState, useEffect, useMemo } from "react";
+import { Link } from "react-router-dom";
 import {
   X,
   History,
@@ -608,18 +609,15 @@ export function TaskDetailsPanel({
                         <Code className="h-4 w-4 mr-1" />
                         Editor
                       </Button>
-                      <Button
-                        variant="outline"
-                        size="sm"
-                        onClick={() =>
-                          window.open(
-                            `/projects/${projectId}/tasks/${task.id}/attempts/${selectedAttempt.id}/compare`,
-                            "_blank"
-                          )
-                        }
-                      >
-                        <FileText className="h-4 w-4 mr-1" />
-                        Changes
+                      <Button variant="outline" size="sm" asChild>
+                        <Link
+                          to={`/projects/${projectId}/tasks/${task.id}/attempts/${selectedAttempt.id}/compare`}
+                          target="_blank"
+                          rel="noopener noreferrer"
+                        >
+                          <FileText className="h-4 w-4 mr-1" />
+                          Changes
+                        </Link>
                       </Button>
                     </div>
                   )}
diff --git a/frontend/src/lib/keyboard-shortcuts.ts b/frontend/src/lib/keyboard-shortcuts.ts
index ea13c399..827451f2 100644
--- a/frontend/src/lib/keyboard-shortcuts.ts
+++ b/frontend/src/lib/keyboard-shortcuts.ts
@@ -1,5 +1,5 @@
 import { useEffect, useCallback } from 'react';
-import { useNavigate } from 'react-router-dom';
+import { useNavigate, useLocation } from 'react-router-dom';
 
 // Define available keyboard shortcuts
 export interface KeyboardShortcut {
@@ -16,6 +16,7 @@ export interface KeyboardShortcutContext {
   openCreateTask?: () => void;
   currentPath?: string;
   hasOpenDialog?: boolean;
+  location?: ReturnType<typeof useLocation>;
 }
 
 // Centralized shortcut definitions
@@ -32,7 +33,7 @@ export const createKeyboardShortcuts = (context: KeyboardShortcutContext): Recor
       
       // Otherwise, navigate back
       if (context.navigate) {
-        const currentPath = context.currentPath || window.location.pathname;
+        const currentPath = context.currentPath || context.location?.pathname || '/';
         
         // Navigate back based on current path
         if (currentPath.includes('/attempts/') && currentPath.includes('/compare')) {